BrowscapPHP\Util\Logfile\ReaderFactory

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

90%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	factory()	0	10	2
A	getReaders()	0	10	2

<?php
/**
 * This file is part of the browscap-php package.
 *
 * Copyright (c) 1998-2017, Browser Capabilities Project
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types = 1);
namespace BrowscapPHP\Util\Logfile;

/**
 * abstract parent class for all readers
 */
final class ReaderFactory
{
    /**
     * @var ReaderInterface[]
     */
    private static $readers = [];

    /**
     * @return \BrowscapPHP\Util\Logfile\ReaderCollection
     */
    public static function factory() : ReaderCollection
    {
        $collection = new ReaderCollection();

        foreach (self::getReaders() as $reader) {
            $collection->addReader($reader);
        }

        return $collection;
    }

    /**
     * @return \BrowscapPHP\Util\Logfile\ReaderInterface[]
     */
    private static function getReaders() : array
    {
        if (self::$readers) {

The expression self::$readers of type BrowscapPHP\Util\Logfile\ReaderInterface[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return self::$readers;
        }

        self::$readers[] = new ApacheCommonLogFormatReader();

        return self::$readers;
    }
}