bristol-su / upload-file

app/CompletionConditions/NumberOfDocumentsSubmitted.php

<?php

Missing file doc comment

namespace BristolSU\Module\UploadFile\CompletionConditions;

use BristolSU\Module\UploadFile\Models\File;
use BristolSU\Support\ActivityInstance\ActivityInstance;
use BristolSU\Support\Completion\Contracts\CompletionCondition;
use BristolSU\Support\ModuleInstance\Contracts\ModuleInstance;
use FormSchema\Schema\Form;

class NumberOfDocumentsSubmitted extends CompletionCondition

Missing doc comment for class NumberOfDocumentsSubmitted

{
    
    public function isComplete($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): bool

Missing doc comment for function isComplete()

    {
        return File::forResource($activityInstance->id, $moduleInstance->id())->count() >= $settings['number_of_files'];
    }

    public function percentage($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): int

Missing doc comment for function percentage()

    {
        $count = File::forResource($activityInstance->id, $moduleInstance->id)->count();

Accessing id on the interface BristolSU\Support\ModuleInstance\Contracts\ModuleInstance suggest that you code against a concrete implementation. How about adding an instanceof check?

        $needed = ( $settings['number_of_files'] ?? 1);

        $percentage = (int) round(($count/$needed) * 100, 0);

        if($percentage > 100) {

Expected "if (...) {\n"; found "if(...) {\n"

            return 100;
        }
        return $percentage;
    }


    public function options(): Form

Missing doc comment for function options()

    {
        return \FormSchema\Generator\Form::make()->withField(
            \FormSchema\Generator\Field::input('number_of_files')->inputType('number')->label('Number of Files')
                ->required(true)->default(1)->hint('The number of files that must be submitted')
                ->help('The number of documents that need to be submitted for the module to be marked as complete.')
        )->getSchema();
    }

    public function name(): string

Missing doc comment for function name()

    {
        return 'A number of documents have been submitted';
    }

    public function description(): string

Missing doc comment for function description()

    {
        return 'Complete when a given number of documents have been submitted';
    }

    public function alias(): string

Missing doc comment for function alias()

    {
        return 'number_of_files_submitted';
    }
}