FileController::show() - Code Metrics - Inspection of "Add ability for admins to edit and delete files" - bristol-su/upload-file - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ec7d81...f16a76 )

by Toby

created 2020-04-07 08:38 UTC

FileController::show() A

↳ Parent: FileController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	3
dl	0
loc	5
ccs	3
cts	3
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php


namespace BristolSU\Module\UploadFile\Http\Controllers\AdminApi;

use BristolSU\Module\UploadFile\Events\DocumentDeleted;
use BristolSU\Module\UploadFile\Events\DocumentUpdated;
use BristolSU\Module\UploadFile\Events\DocumentUploaded;
use BristolSU\Module\UploadFile\Http\Controllers\Controller;
use BristolSU\Module\UploadFile\Http\Requests\AdminApi\FileController\StoreRequest;
use BristolSU\Module\UploadFile\Models\File;
use BristolSU\Support\Activity\Activity;
use BristolSU\Support\ActivityInstance\Contracts\ActivityInstanceResolver;
use BristolSU\Support\Authentication\Contracts\Authentication;
use BristolSU\Support\ModuleInstance\ModuleInstance;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\Request;
use Illuminate\Support\Arr;

class FileController extends Controller

{

    public function index()

    {
        $this->authorize('admin.file.index');
        
        return File::forModuleInstance()->with(['statuses', 'comments'])->get();
    }

    public function show(Activity $activity, ModuleInstance $moduleInstance, File $file)
    public function show(Activity $activity, /** @scrutinizer ignore-unused */ ModuleInstance $moduleInstance, File $file)
    {
        $this->authorize('admin.file.index');
        
        return $file->load(['statuses', 'comments']);
    }

    public function store(StoreRequest $request, Authentication $authentication)

    {
        $fileMetadata = collect();

        foreach (Arr::wrap($request->file('file')) as $file) {

            $path = $file->store('uploadfile');

            $fileMetadata->push($tempFileMeta = File::create([

                'title' => $request->input('title'),
                'description' => $request->input('description'),
                'filename' => $file->getClientOriginalName(),
                'mime' => $file->getClientMimeType(),
                'path' => $path,
                'size' => $file->getSize(),
                'uploaded_by' => $authentication->getUser()->id(),
                'activity_instance_id' => $request->input('activity_instance_id')
            ]));
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

            event(new DocumentUploaded($tempFileMeta));
        }

        return $fileMetadata;
    }

    public function destroy(Request $request, Activity $activity, ModuleInstance $moduleInstance, File $file)

    {
        $this->authorize('admin.file.destroy');

        $file->delete();
        $file->refresh();

        event(new DocumentDeleted($file));

        return $file->refresh();
    }

    public function update(Request $request, Activity $activity, ModuleInstance $moduleInstance, File $file)
    public function update(Request $request, Activity $activity, /** @scrutinizer ignore-unused */ ModuleInstance $moduleInstance, File $file)
    {
        $this->authorize('admin.file.update');

        $file->title = $request->input('title', $file->title);
        $file->description = $request->input('description', $file->description);
        $file->activity_instance_id = $request->input('activity_instance_id', $file->activity_instance_id);

        $file->save();

        event(new DocumentUpdated($file));

        return $file;
    }
    
}

bristol-su / upload-file

GitHub Access Token became invalid

Push — master ( ec7d81...f16a76 )

FileController::show() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like