BristolSU\Module\UploadFile\Http\Controllers\Participant\DownloadFileController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	download()	0	11	2
A	downloadOld()	0	11	2

<?php

Missing file doc comment

namespace BristolSU\Module\UploadFile\Http\Controllers\Participant;

use BristolSU\Module\UploadFile\Http\Controllers\Controller;
use BristolSU\Module\UploadFile\Models\File;
use BristolSU\Support\Activity\Activity;
use BristolSU\Support\ModuleInstance\ModuleInstance;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Storage;
use Symfony\Component\HttpKernel\Exception\HttpException;

class DownloadFileController extends Controller

Missing doc comment for class DownloadFileController

{

    public function download(Request $request, Activity $activity, ModuleInstance $moduleInstance, File $file)

The parameter $moduleInstance is not used and could be removed.

The parameter $activity is not used and could be removed.

The parameter $request is not used and could be removed.

Missing doc comment for function download()

    {
        $this->authorize('file.download');
        
        if(Storage::exists($file->path)) {

Expected "if (...) {\n"; found "if(...) {\n"

            return Storage::download($file->path, $file->filename, [

The opening parenthesis of a multi-line function call should be the last content on the line.

                'X-Vapor-Base64-Encode' => 'True'
            ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        }
        
        throw new HttpException(404, 'File not found');
    }

    public function downloadOld(Request $request, Activity $activity, ModuleInstance $moduleInstance, File $file)

The parameter $request is not used and could be removed.

The parameter $moduleInstance is not used and could be removed.

The parameter $activity is not used and could be removed.

Missing doc comment for function downloadOld()

    {
        $this->authorize('file.download');

        if(Storage::exists($file->path)) {

Expected "if (...) {\n"; found "if(...) {\n"

            return Storage::download($file->path, $file->filename, [

The opening parenthesis of a multi-line function call should be the last content on the line.

                'X-Vapor-Base64-Encode' => 'True'
            ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        }

        throw new HttpException(404, 'File not found');
    }
    
}