BristolSU\Module\UploadFile\Http\Controllers\AdminApi\FileController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	5	1
A	index()	0	9	1
A	update()	0	13	1
A	destroy()	0	10	1
A	store()	0	24	2

<?php

Missing file doc comment

namespace BristolSU\Module\UploadFile\Http\Controllers\AdminApi;

use BristolSU\Module\UploadFile\Events\DocumentDeleted;
use BristolSU\Module\UploadFile\Events\DocumentUpdated;
use BristolSU\Module\UploadFile\Events\DocumentUploaded;
use BristolSU\Module\UploadFile\Http\Controllers\Controller;
use BristolSU\Module\UploadFile\Http\Requests\AdminApi\FileController\StoreRequest;
use BristolSU\Module\UploadFile\Models\File;
use BristolSU\Support\Activity\Activity;
use BristolSU\Support\ActivityInstance\Contracts\ActivityInstanceResolver;
use BristolSU\Support\Authentication\Contracts\Authentication;
use BristolSU\Support\ModuleInstance\ModuleInstance;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\Request;
use Illuminate\Support\Arr;

class FileController extends Controller

Missing doc comment for class FileController

{

    public function index()

Missing doc comment for function index()

    {
        $this->authorize('admin.file.index');
        
        return File::forModuleInstance()->with(['statuses', 'comments'])->get()->map(function(File $file) {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 space after FUNCTION keyword; 0 found

            $activityInstance = $file->activityInstance();
            $file = $file->toArray();
            $file['activity_instance'] = $activityInstance;
            return $file;
        });

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    public function show(Activity $activity, ModuleInstance $moduleInstance, File $file)

The parameter $moduleInstance is not used and could be removed.

The parameter $activity is not used and could be removed.

Missing doc comment for function show()

    {
        $this->authorize('admin.file.index');
        
        return $file->load(['statuses', 'comments']);
    }

    public function store(StoreRequest $request, Authentication $authentication)

Missing doc comment for function store()

    {
        $fileMetadata = collect();

        foreach (Arr::wrap($request->file('file')) as $file) {

            $path = $file->store('uploadfile');

            $fileMetadata->push($tempFileMeta = File::create([

The opening parenthesis of a multi-line function call should be the last content on the line.

                'title' => $request->input('title'),
                'description' => $request->input('description'),
                'filename' => $file->getClientOriginalName(),
                'mime' => $file->getClientMimeType(),
                'path' => $path,
                'size' => $file->getSize(),
                'uploaded_by' => $authentication->getUser()->id(),
                'activity_instance_id' => $request->input('activity_instance_id'),
                'tags' => settings('new_tags', [])
            ]));

For multi-line function calls, the closing parenthesis should be on a new line.

            event(new DocumentUploaded($tempFileMeta));
        }

        return $fileMetadata;
    }

    public function destroy(Request $request, Activity $activity, ModuleInstance $moduleInstance, File $file)

Missing doc comment for function destroy()

    {
        $this->authorize('admin.file.destroy');

        $file->delete();
        $file->refresh();

        event(new DocumentDeleted($file));

        return $file->refresh();
    }

    public function update(Request $request, Activity $activity, ModuleInstance $moduleInstance, File $file)

The parameter $moduleInstance is not used and could be removed.

The parameter $activity is not used and could be removed.

Missing doc comment for function update()

    {
        $this->authorize('admin.file.update');

        $file->title = $request->input('title', $file->title);
        $file->description = $request->input('description', $file->description);
        $file->activity_instance_id = $request->input('activity_instance_id', $file->activity_instance_id);

        $file->save();

        event(new DocumentUpdated($file));

        return $file;
    }
    
}