BristolSU\Module\StaticPage\Http\Controllers\Api\Participant\ButtonController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

88.89%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	12	3
A	store()	0	11	1
A	index()	0	5	1

<?php

Missing file doc comment

namespace BristolSU\Module\StaticPage\Http\Controllers\Api\Participant;

use BristolSU\Module\StaticPage\Events\ButtonSubmitted;
use BristolSU\Module\StaticPage\Events\ButtonUnsubmitted;
use BristolSU\Module\StaticPage\Http\Controllers\Controller;
use BristolSU\Module\StaticPage\Models\ButtonClick;
use BristolSU\Support\Activity\Activity;
use BristolSU\Support\ActivityInstance\Contracts\ActivityInstanceResolver;
use BristolSU\Support\Authentication\Contracts\Authentication;
use BristolSU\Support\ModuleInstance\ModuleInstance;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\Response;
use Illuminate\Validation\ValidationException;

class ButtonController extends Controller

Missing doc comment for class ButtonController

{

    public function store(Authentication $authentication)

Missing doc comment for function store()

    {
        $this->authorize('click-button');

        $buttonClick = ButtonClick::create([

The opening parenthesis of a multi-line function call should be the last content on the line.

          'clicked_by' => $authentication->getUser()->id()

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 10.

        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        event(new ButtonSubmitted($buttonClick));

        return $buttonClick;
    }

    public function index()

Missing doc comment for function index()

    {
        $this->authorize('view-page');

        return ButtonClick::forResource()->get();
    }

    public function destroy(Activity $activity, ModuleInstance $moduleInstance, ButtonClick $buttonClick, ActivityInstanceResolver  $activityInstanceResolver)

The parameter $activity is not used and could be removed.

The parameter $moduleInstance is not used and could be removed.

Missing doc comment for function destroy()

    {
        $this->authorize('delete-button-click');
        if($activityInstanceResolver->getActivityInstance()->id !== (int) $buttonClick->activity_instance_id) {

Expected "if (...) {\n"; found "if(...) {\n"

            throw new AuthorizationException('The button click does not belong to your activity instance');
        }
        if($buttonClick->delete()) {

Expected "if (...) {\n"; found "if(...) {\n"

            event(new ButtonUnsubmitted($buttonClick));
            return Response::create('', Response::HTTP_NO_CONTENT);
        } else {
            throw ValidationException::withMessages([

The opening parenthesis of a multi-line function call should be the last content on the line.

              'button' => ['Could not delete the button click']

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 14.

            ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        }
    }

}