BristolSU\ControlDB\Observers\PositionObserverCascadeDelete::deleteRoles()

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	2.1481

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function deleteRoles(Position $position)

Private method name "PositionObserverCascadeDelete::deleteRoles" must be prefixed with an underscore

Missing doc comment for function deleteRoles()

    {
        foreach($this->roleRepository->allThroughPosition($position) as $role) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            $this->roleRepository->delete($role->id());
        }
}