BristolSU\ControlDB\Export\Formatter\Shared\SortByColumn

Complexity

Total Complexity

17

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

70.37%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	compareStrings()	0	3	1
A	handles()	0	3	1
A	compareInts()	0	6	3
B	format()	0	25	11
A	formatItem()	0	3	1

<?php

Missing file doc comment

namespace BristolSU\ControlDB\Export\Formatter\Shared;

use BristolSU\ControlDB\Export\FormattedItem;
use BristolSU\ControlDB\Export\Formatter\Formatter;

class SortByColumn extends Formatter

Missing doc comment for class SortByColumn

{

    public function format($items)

Missing doc comment for function format()

    {
        $column = $this->config('column', 'id');
        
        usort($items, function($a, $b) use ($column) {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 space after FUNCTION keyword; 0 found

            $aVal = $a->getItem($column);
            $bVal = $b->getItem($column);
            if(is_null($aVal) && is_null($bVal)) {

Expected "if (...) {\n"; found "if(...) {\n"

                return 0;
            }
            if(is_null($aVal) && !is_null($bVal)) {

Expected "if (...) {\n"; found "if(...) {\n"

                return 1;
            }
            if(!is_null($aVal) && is_null($bVal)) {

Expected "if (...) {\n"; found "if(...) {\n"

                return -1;
            }
            if(is_string($aVal) || is_string($bVal)) {

Expected "if (...) {\n"; found "if(...) {\n"

                return $this->compareStrings($aVal, $bVal);
            }
            if(is_int($aVal) || is_int($bVal)) {

Expected "if (...) {\n"; found "if(...) {\n"

                return $this->compareInts($aVal, $bVal);
            }
            return 0;
        });

For multi-line function calls, the closing parenthesis should be on a new line.

        return $items;
    }
    
    private function compareStrings(string $a, string $b): int 

Private method name "SortByColumn::compareStrings" must be prefixed with an underscore

Missing doc comment for function compareStrings()

    {
        return strcmp($a, $b);
    }

    public function compareInts(int $a, int $b): int

Missing doc comment for function compareInts()

    {
        if ($a == $b) {
            return 0;
        }
        return ($a < $b) ? -1 : 1;
    }
 
    public function formatItem(FormattedItem $formattedItem): FormattedItem

Missing doc comment for function formatItem()

    {
        return $formattedItem;
    }

    public function handles(): string

Missing doc comment for function handles()

    {
        return static::ALL;
    }
}