GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#13)
by Toby
16:48 queued 03:24
created

PositionController::search()   A

Complexity

Conditions 5
Paths 12

Size

Total Lines 19
Code Lines 12

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 30

Importance

Changes 0
Metric Value
eloc 12
c 0
b 0
f 0
dl 0
loc 19
ccs 0
cts 13
cp 0
rs 9.5555
cc 5
nc 12
nop 3
crap 30
1
<?php
2
0 ignored issues
show
Coding Style introduced by
Missing file doc comment
Loading history...
3
namespace BristolSU\ControlDB\Http\Controllers\Position;
4
5
use BristolSU\ControlDB\Http\Controllers\Controller;
6
use BristolSU\ControlDB\Http\Requests\Api\Position\StorePositionRequest;
7
use BristolSU\ControlDB\Http\Requests\Api\Position\UpdatePositionRequest;
8
use BristolSU\ControlDB\Contracts\Models\Position;
9
use BristolSU\ControlDB\Contracts\Repositories\DataPosition as DataPositionRepository;
10
use BristolSU\ControlDB\Contracts\Repositories\Position as PositionRepository;
11
use Illuminate\Http\Request;
12
use Illuminate\Pagination\LengthAwarePaginator;
13
use Illuminate\Support\Collection;
14
15
/**
16
 * Handles a position model
17
 */
0 ignored issues
show
Coding Style introduced by
Missing @category tag in class comment
Loading history...
Coding Style introduced by
Missing @package tag in class comment
Loading history...
Coding Style introduced by
Missing @author tag in class comment
Loading history...
Coding Style introduced by
Missing @license tag in class comment
Loading history...
Coding Style introduced by
Missing @link tag in class comment
Loading history...
18
class PositionController extends Controller
19
{
20
21
    /**
22
     * Get all positions
23
     *
24
     * @param Request $request
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Expected 12 spaces after parameter type; 1 found
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
25
     * @param PositionRepository $positionRepository
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
26
     * @return LengthAwarePaginator
0 ignored issues
show
Coding Style introduced by
Tag @return cannot be grouped with parameter tags in a doc comment
Loading history...
27
     */
28 2
    public function index(Request $request, PositionRepository $positionRepository)
29
    {
30 2
        $perPage = $request->input('per_page', 10);
31 2
        $page = $request->input('page', 1);
32
33 2
        return $this->paginationResponse(
34 2
            $positionRepository->paginate($page, $perPage),
35 2
            $positionRepository->count()
36
        );
37
    }
38
39
    public function search(Request $request, PositionRepository $positionRepository, DataPositionRepository $dataPositionRepository)
0 ignored issues
show
Unused Code introduced by
The parameter $positionRepository is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

39
    public function search(Request $request, /** @scrutinizer ignore-unused */ PositionRepository $positionRepository, DataPositionRepository $dataPositionRepository)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Coding Style introduced by
Missing doc comment for function search()
Loading history...
40
    {
41
42
        $search = [];
43
        if($request->has('name')) {
0 ignored issues
show
Coding Style introduced by
Expected "if (...) {\n"; found "if(...) {\n"
Loading history...
44
            $search['name'] = $request->input('name');
45
        }
46
        if($request->has('description')) {
0 ignored issues
show
Coding Style introduced by
Expected "if (...) {\n"; found "if(...) {\n"
Loading history...
47
            $search['description'] = $request->input('description');
48
        }
49
        $dataPositions = $dataPositionRepository->getAllWhere($search);
50
        $positions = new Collection();
51
        foreach($dataPositions as $dataPosition) {
0 ignored issues
show
Coding Style introduced by
Expected "foreach (...) {\n"; found "foreach(...) {\n"
Loading history...
52
            $position = $dataPosition->position();
53
            if($position !== null) {
0 ignored issues
show
Coding Style introduced by
Expected "if (...) {\n"; found "if(...) {\n"
Loading history...
54
                $positions->push($position);
55
            }
56
        }
57
        return $this->paginate($positions);
58
    }
59
60
    /**
61
     * Return information about a single position
62
     * 
63
     * @param Position $position
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
64
     * @return Position
0 ignored issues
show
Coding Style introduced by
Tag @return cannot be grouped with parameter tags in a doc comment
Loading history...
65
     */
66 1
    public function show(Position $position)
67
    {
68 1
    	return $position;
0 ignored issues
show
Coding Style introduced by
Line indented incorrectly; expected at least 8 spaces, found 5
Loading history...
69
    }
70
71
    /**
72
     * Create a new position
73
     * 
74
     * @param StorePositionRequest $request
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Expected 3 spaces after parameter type; 1 found
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
75
     * @param PositionRepository $positionRepository
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Expected 5 spaces after parameter type; 1 found
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
76
     * @param DataPositionRepository $dataPositionRepository
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
77
     * @return Position
0 ignored issues
show
Coding Style introduced by
Tag @return cannot be grouped with parameter tags in a doc comment
Loading history...
78
     */
79 2
    public function store(StorePositionRequest $request, PositionRepository $positionRepository, DataPositionRepository $dataPositionRepository)
80
    {
81 2
        $dataPosition = $dataPositionRepository->create(
82 2
            $request->input('name'),
83 2
            $request->input('description')
84
        );
85 2
        foreach($dataPosition->getAdditionalAttributes() as $additionalAttribute) {
0 ignored issues
show
Coding Style introduced by
Expected "foreach (...) {\n"; found "foreach(...) {\n"
Loading history...
86 1
            if($request->has($additionalAttribute)) {
0 ignored issues
show
Coding Style introduced by
Expected "if (...) {\n"; found "if(...) {\n"
Loading history...
87 1
                $dataPosition->saveAdditionalAttribute($additionalAttribute, $request->input($additionalAttribute));
88
            }
89
        }
90
91 2
        return $positionRepository->create($dataPosition->id());
92
    }
93
94
    /**
95
     * Update a position
96
     * 
97
     * @param Position $position
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Expected 15 spaces after parameter type; 1 found
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
98
     * @param UpdatePositionRequest $request
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Expected 2 spaces after parameter type; 1 found
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
99
     * @param PositionRepository $positionRepository
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Expected 5 spaces after parameter type; 1 found
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
100
     * @param DataPositionRepository $dataPositionRepository
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Tag value for @param tag indented incorrectly; expected 2 spaces but found 1
Loading history...
101
     * @return Position
0 ignored issues
show
Coding Style introduced by
Tag @return cannot be grouped with parameter tags in a doc comment
Loading history...
102
     */
103 2
    public function update(Position $position, UpdatePositionRequest $request, PositionRepository $positionRepository, DataPositionRepository $dataPositionRepository)
0 ignored issues
show
Unused Code introduced by
The parameter $dataPositionRepository is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

103
    public function update(Position $position, UpdatePositionRequest $request, PositionRepository $positionRepository, /** @scrutinizer ignore-unused */ DataPositionRepository $dataPositionRepository)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $positionRepository is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

103
    public function update(Position $position, UpdatePositionRequest $request, /** @scrutinizer ignore-unused */ PositionRepository $positionRepository, DataPositionRepository $dataPositionRepository)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
104
    {
105 2
        $dataPosition = $position->data();
106
107 2
        if($request->input('name') !== null) {
0 ignored issues
show
Coding Style introduced by
Expected "if (...) {\n"; found "if(...) {\n"
Loading history...
108 2
            $dataPosition->setName($request->input('name'));
109
        }
110 2
        if($request->input('description') !== null) {
0 ignored issues
show
Coding Style introduced by
Expected "if (...) {\n"; found "if(...) {\n"
Loading history...
111 2
            $dataPosition->setDescription($request->input('description'));
112
        }
113 2
        foreach($dataPosition->getAdditionalAttributes() as $additionalAttribute) {
0 ignored issues
show
Coding Style introduced by
Expected "foreach (...) {\n"; found "foreach(...) {\n"
Loading history...
114 1
            if($request->has($additionalAttribute)) {
0 ignored issues
show
Coding Style introduced by
Expected "if (...) {\n"; found "if(...) {\n"
Loading history...
115 1
                $dataPosition->saveAdditionalAttribute($additionalAttribute, $request->input($additionalAttribute));
116
            }
117
        }
118
        
119 2
        return $position;
120
    }
121
122
    /**
123
     * Delete a position
124
     * 
125
     * @param Position $position
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
Coding Style introduced by
Expected 11 spaces after parameter type; 1 found
Loading history...
126
     * @param PositionRepository $positionRepository
0 ignored issues
show
Coding Style introduced by
Missing parameter comment
Loading history...
127
     */
0 ignored issues
show
Coding Style introduced by
Missing @return tag in function comment
Loading history...
128 1
    public function destroy(Position $position, PositionRepository $positionRepository)
129
    {
130 1
        $positionRepository->delete((int) $position->id());
131 1
    }
132
133
}