ObserverStore::detach() - Code Metrics - Inspection of "Merge pull request #14 from bristol-su/develop" - bristol-su/control - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0c5c4d...5cc6ab )

by Toby

created 2020-04-27 14:28 UTC

ObserverStore::detach() A

↳ Parent: ObserverStore

Complexity

Conditions	3
Paths	3

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	4
c	1
b	0
f	0
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	10
cc	3
nc	3
nop	2
crap	3

<?php


namespace BristolSU\ControlDB\Observers\NotifyObservers\Framework;

class ObserverStore

{

    private $observers = [];

    
    public function attach($notifier, $observer): void

    {
        if(!array_key_exists($notifier, $this->observers)) {

            $this->observers[$notifier] = [];
        }
        $this->observers[$notifier][] = $observer;
    }

    public function detach($notifier, $observer): void

    {
        if (array_key_exists($notifier, $this->observers)) {
            if (($key = array_search($observer, $this->observers[$notifier])) !== false) {
                unset($this->observers[$notifier][$key]);
                $this->observers[$notifier] = array_values($this->observers[$notifier]);
            }
        }
    }
    
    public function forNotifier($notifier): array

    {
        if(array_key_exists($notifier, $this->observers)) {

            return $this->observers[$notifier];
        }
        return [];
    }
}

1		<?php
2
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3		namespace BristolSU\ControlDB\Observers\NotifyObservers\Framework;
4
5		class ObserverStore
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing doc comment for class ObserverStore Loading history...
6		{
7
8		private $observers = [];
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Private member variable "observers" must be prefixed with an underscore Loading history...
9
10	796	public function attach($notifier, $observer): void
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing doc comment for function attach() Loading history...
11		{
12	796	if(!array_key_exists($notifier, $this->observers)) {
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Expected "if (...) {\n"; found "if(...) {\n" Loading history...
13	796	$this->observers[$notifier] = [];
14		}
15	796	$this->observers[$notifier][] = $observer;
16	796	}
17
18	1	public function detach($notifier, $observer): void
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing doc comment for function detach() Loading history...
19		{
20	1	if (array_key_exists($notifier, $this->observers)) {
21	1	if (($key = array_search($observer, $this->observers[$notifier])) !== false) {
22	1	unset($this->observers[$notifier][$key]);
23	1	$this->observers[$notifier] = array_values($this->observers[$notifier]);
24		}
25		}
26	1	}
27
28	154	public function forNotifier($notifier): array
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing doc comment for function forNotifier() Loading history...
29		{
30	154	if(array_key_exists($notifier, $this->observers)) {
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Expected "if (...) {\n"; found "if(...) {\n" Loading history...
31	154	return $this->observers[$notifier];
32		}
33		return [];
34		}
35		}

bristol-su / control

GitHub Access Token became invalid

Push — master ( 0c5c4d...5cc6ab )

ObserverStore::detach() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like