DataGroup::update() - Code Metrics - Inspection of "Merge pull request #14 from bristol-su/develop" - bristol-su/control - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0c5c4d...5cc6ab )

by Toby

created 2020-04-27 14:28 UTC

DataGroup::update() A

↳ Parent: DataGroup

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	1
c	1
b	0
f	0
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
cc	1
nc	1
nop	3
crap	1

<?php


namespace BristolSU\ControlDB\Cache;

use BristolSU\ControlDB\Contracts\Repositories\DataGroup as DataGroupRepository;
use Illuminate\Contracts\Cache\Repository;
use Illuminate\Support\Collection;

class DataGroup implements DataGroupRepository

{

    /**

     * @var DataGroupRepository
     */
    private $dataGroupRepository;

    /**

     * @var Repository
     */
    private $cache;


    public function __construct(DataGroupRepository $dataGroupRepository, Repository $cache)

    {
        $this->dataGroupRepository = $dataGroupRepository;
        $this->cache = $cache;
    }

    /**
     * Get a data group by ID
     *
     * @param int $id

     * @return \BristolSU\ControlDB\Contracts\Models\DataGroup

     */
    public function getById(int $id): \BristolSU\ControlDB\Contracts\Models\DataGroup
    {
        return $this->cache->rememberForever(static::class . '@getById:' . $id, function() use ($id) {

            return $this->dataGroupRepository->getById($id);
        });
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    /**
     * Get a data group where the given attributes match, including additional attributes.
     *
     * @param array $attributes

     * @return \BristolSU\ControlDB\Contracts\Models\DataGroup

     */
    public function getWhere($attributes = []): \BristolSU\ControlDB\Contracts\Models\DataGroup
    {
        return $this->dataGroupRepository->getWhere($attributes);
    }
    
    /**
     * Get all data groups where the given attributes match, including additional attributes.
     *
     * @param array $attributes

     * @return Collection|\BristolSU\ControlDB\Contracts\Models\DataGroup[]

     */
    public function getAllWhere($attributes = []): Collection
    {
        return $this->dataGroupRepository->getAllWhere($attributes);
    }

    /**
     * Create a data group with the given attributes
     *
     * @param string|null $name Name of the group

     * @param string|null $email Email of the group
     *
     * @return \BristolSU\ControlDB\Contracts\Models\DataGroup
     */
    public function create(?string $name = null, ?string $email = null): \BristolSU\ControlDB\Contracts\Models\DataGroup
    {
        return $this->dataGroupRepository->create($name, $email);
    }

    /**
     * Update a group with the given attributes
     *
     * @param int $id

     * @param string|null $name Name of the group

     * @param string|null $email Email of the group
     * @return \BristolSU\ControlDB\Contracts\Models\DataGroup

     */
    public function update(int $id, ?string $name = null, ?string $email = null): \BristolSU\ControlDB\Contracts\Models\DataGroup
    {
        return $this->dataGroupRepository->update($id, $name, $email);
    }
}

1		<?php
2
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3		namespace BristolSU\ControlDB\Cache;
4
5		use BristolSU\ControlDB\Contracts\Repositories\DataGroup as DataGroupRepository;
6		use Illuminate\Contracts\Cache\Repository;
7		use Illuminate\Support\Collection;
8
9		class DataGroup implements DataGroupRepository
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing doc comment for class DataGroup Loading history...
10		{
11
12		/**
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
13		* @var DataGroupRepository
14		*/
15		private $dataGroupRepository;
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Private member variable "dataGroupRepository" must be prefixed with an underscore Loading history...
16		/**
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
17		* @var Repository
18		*/
19		private $cache;
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Private member variable "cache" must be prefixed with an underscore Loading history...
20
21	20	public function __construct(DataGroupRepository $dataGroupRepository, Repository $cache)
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing doc comment for function __construct() Loading history...
22		{
23	20	$this->dataGroupRepository = $dataGroupRepository;
24	20	$this->cache = $cache;
25	20	}
26
27		/**
28		* Get a data group by ID
29		*
30		* @param int $id
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
31		* @return \BristolSU\ControlDB\Contracts\Models\DataGroup
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Tag @return cannot be grouped with parameter tags in a doc comment Loading history...
32		*/
33	14	public function getById(int $id): \BristolSU\ControlDB\Contracts\Models\DataGroup
34		{
35		return $this->cache->rememberForever(static::class . '@getById:' . $id, function() use ($id) {
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history... Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
36	14	return $this->dataGroupRepository->getById($id);
37	14	});
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
38		}
39
40		/**
41		* Get a data group where the given attributes match, including additional attributes.
42		*
43		* @param array $attributes
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
44		* @return \BristolSU\ControlDB\Contracts\Models\DataGroup
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Tag @return cannot be grouped with parameter tags in a doc comment Loading history...
45		*/
46	1	public function getWhere($attributes = []): \BristolSU\ControlDB\Contracts\Models\DataGroup
47		{
48	1	return $this->dataGroupRepository->getWhere($attributes);
49		}
50
51		/**
52		* Get all data groups where the given attributes match, including additional attributes.
53		*
54		* @param array $attributes
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
55		* @return Collection\|\BristolSU\ControlDB\Contracts\Models\DataGroup[]
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Tag @return cannot be grouped with parameter tags in a doc comment Loading history...
56		*/
57	1	public function getAllWhere($attributes = []): Collection
58		{
59	1	return $this->dataGroupRepository->getAllWhere($attributes);
60		}
61
62		/**
63		* Create a data group with the given attributes
64		*
65		* @param string\|null $name Name of the group
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Expected 2 spaces after parameter name; 1 found Loading history...
66		* @param string\|null $email Email of the group
67		*
68		* @return \BristolSU\ControlDB\Contracts\Models\DataGroup
69		*/
70	3	public function create(?string $name = null, ?string $email = null): \BristolSU\ControlDB\Contracts\Models\DataGroup
71		{
72	3	return $this->dataGroupRepository->create($name, $email);
73		}
74
75		/**
76		* Update a group with the given attributes
77		*
78		* @param int $id
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history... Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Expected 9 spaces after parameter type; 1 found Loading history...
79		* @param string\|null $name Name of the group
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Expected 2 spaces after parameter name; 1 found Loading history...
80		* @param string\|null $email Email of the group
81		* @return \BristolSU\ControlDB\Contracts\Models\DataGroup
		0 ignored issues – show Coding Style introduced 2020-04-24 16:49 UTC by Report Bug Copy Issue Report Tag @return cannot be grouped with parameter tags in a doc comment Loading history...
82		*/
83	5	public function update(int $id, ?string $name = null, ?string $email = null): \BristolSU\ControlDB\Contracts\Models\DataGroup
84		{
85	5	return $this->dataGroupRepository->update($id, $name, $email);
86		}
87		}

bristol-su / control

GitHub Access Token became invalid

Push — master ( 0c5c4d...5cc6ab )

DataGroup::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like