UserController::update() - Code Metrics - Inspection of "Merge pull request #13 from bristol-su/develop" - bristol-su/control - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 348781...c5b82c )

by Toby

created 2020-04-22 13:29 UTC

UserController::update() B

↳ Parent: UserController

Complexity

Conditions	8
Paths	96

Size

Total Lines	27
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	8

Importance

Changes

Metric	Value
eloc	15
dl	0
loc	27
ccs	16
cts	16
cp	1
rs	8.4444
c	0
b	0
f	0
cc	8
nc	96
nop	4
crap	8

<?php


namespace BristolSU\ControlDB\Http\Controllers\User;

use BristolSU\ControlDB\Contracts\Repositories\DataUser;
use BristolSU\ControlDB\Http\Controllers\Controller;
use BristolSU\ControlDB\Http\Requests\Api\User\StoreUserRequest;
use BristolSU\ControlDB\Contracts\Repositories\DataUser as DataUserRepository;
use BristolSU\ControlDB\Contracts\Repositories\User as UserRepository;
use BristolSU\ControlDB\Contracts\Models\User;
use Carbon\Carbon;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;

/**
 * Handle the user model
 */

class UserController extends Controller
{

    /**
     * Get all users
     *
     * @param Request $request

     * @param UserRepository $userRepository

     * @return LengthAwarePaginator

     */
    public function index(Request $request, UserRepository $userRepository)
    {
        $perPage = $request->input('per_page', 10);
        $page = $request->input('page', 1);
        
        return $this->paginationResponse(
            $userRepository->paginate($page, $perPage),
            $userRepository->count()
        );
    }
    
    public function search(Request $request, UserRepository $userRepository, DataUserRepository $dataUserRepository)
    public function search(Request $request, /** @scrutinizer ignore-unused */ UserRepository $userRepository, DataUserRepository $dataUserRepository)
    {
        $search = [];
        if($request->has('first_name')) {

            $search['first_name'] = $request->input('first_name');
        }
        if($request->has('last_name')) {

            $search['last_name'] = $request->input('last_name');
        }
        if($request->has('email')) {

            $search['email'] = $request->input('email');
        }
        $dataUsers = $dataUserRepository->getAllWhere($search);
        $users = new Collection();
        foreach($dataUsers as $dataUser) {

            $user = $dataUser->user();
            if($user !== null) {

                $users->push($user);
            }
        }
        
        return $this->paginate($users);
    }
    
    /**
     * Get information about a specific user
     * 
     * @param User $user

     * @return User

     */
    public function show(User $user)
    {
        return $user;
    }

    /**
     * Create a new user
     * 
     * @param StoreUserRequest $request

     * @param UserRepository $userRepository

     * @param DataUserRepository $dataUserRepository

     * @return User

     */
    public function store(StoreUserRequest $request, UserRepository $userRepository, DataUserRepository $dataUserRepository)
    {
        $dataUser = $dataUserRepository->create(
            $request->input('first_name'),
            $request->input('last_name'),
            $request->input('email'),
            Carbon::make($request->input('dob')),
            $request->input('preferred_name')
        );

        foreach($dataUser->getAdditionalAttributes() as $additionalAttribute) {

            if($request->has($additionalAttribute)) {

                $dataUser->saveAdditionalAttribute($additionalAttribute, $request->input($additionalAttribute));
            }
        }
        
        return $userRepository->create($dataUser->id());
    }

    /**
     * Update a user
     * 
     * @param User $user

     * @param StoreUserRequest $request

     * @param UserRepository $userRepository

     * @param DataUserRepository $dataUserRepository

     * @return User

     */
    public function update(User $user, StoreUserRequest $request, UserRepository $userRepository, DataUserRepository $dataUserRepository)
    public function update(User $user, StoreUserRequest $request, UserRepository $userRepository, /** @scrutinizer ignore-unused */ DataUserRepository $dataUserRepository)
    {
        $dataUser = $user->data();

        if($request->input('first_name') !== null) {

            $dataUser->setFirstName($request->input('first_name'));
        }
        if($request->input('last_name') !== null) {

            $dataUser->setLastName($request->input('last_name'));
        }
        if($request->input('email') !== null) {

            $dataUser->setEmail($request->input('email'));
        }
        if($request->input('dob') !== null) {

            $dataUser->setDob(Carbon::make($request->input('dob')));
        }
        if($request->input('preferred_name') !== null) {

            $dataUser->setPreferredName($request->input('preferred_name'));
        }

        foreach($dataUser->getAdditionalAttributes() as $additionalAttribute) {

            if($request->has($additionalAttribute)) {

                $dataUser->saveAdditionalAttribute($additionalAttribute, $request->input($additionalAttribute));
            }
        }

        return $user;
    }

    /**
     * Delete a user
     * 
     * @param User $user

     * @param UserRepository $userRepository

     */

    public function destroy(User $user, UserRepository $userRepository)
    {
        $userRepository->delete((int) $user->id());
    }


}


bristol-su / control

GitHub Access Token became invalid

Push — master ( 348781...c5b82c )

UserController::update() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like