BristolSU\ControlDB\Export\Handler\Airtable\AirtableHandler

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	save()	0	13	2
A	clearTable()	0	18	2
A	createRows()	0	8	2

<?php

Missing file doc comment

namespace BristolSU\ControlDB\Export\Handler\Airtable;


use BristolSU\ControlDB\Export\FormattedItem;
use BristolSU\ControlDB\Export\Handler\Handler;
use Carbon\Carbon;
use Illuminate\Support\Collection;

class AirtableHandler extends Handler

Missing doc comment for class AirtableHandler

{

    /**
     * Save each item to AirTable
     * 
     * @param FormattedItem[] $items

Missing parameter comment

     * @return mixed|void

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    protected function save(array $items)
    {
        $creating = [];
        
        foreach($items as $item) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            $creating[] = [
                'fields' => $item->toArray()
            ];
        }
        
        $time = Carbon::now();
        $time = $this->clearTable($time);
        $this->createRows($creating, $time);
    }

    protected function createRows($creating, $time)

Missing doc comment for function createRows()

    {
        foreach (collect($creating)->chunk(10) as $fields) {
            dispatch(
                new CreateRows(['records' => $fields->values()->toArray(), 'typecast' => true], $this->config('apiKey'),

It seems like $this->config('apiKey') can also be of type null; however, parameter $apiKey of BristolSU\ControlDB\Export\Handler\Airtable\CreateRows::__construct() does only seem to accept string, maybe add an additional type check?

The opening parenthesis of a multi-line function call should be the last content on the line.

                    $this->config('baseId'), $this->config('tableName'))

It seems like $this->config('baseId') can also be of type null; however, parameter $baseId of BristolSU\ControlDB\Export\Handler\Airtable\CreateRows::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $this->config('tableName') can also be of type null; however, parameter $tableName of BristolSU\ControlDB\Export\Handler\Airtable\CreateRows::__construct() does only seem to accept string, maybe add an additional type check?

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 20.

For multi-line function calls, the closing parenthesis should be on a new line.

            )->delay($time);
            $time->addSeconds(2);
        }
    }

    protected function clearTable($time)

Missing doc comment for function clearTable()

    {
        $idRetriever = app(IdRetriever::class, [

The opening parenthesis of a multi-line function call should be the last content on the line.

            'baseId' => $this->config('baseId'),
            'tableName' => $this->config('tableName')
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $ids = $idRetriever->ids();

        foreach ($ids->chunk(10) as $idsToRemove) {
            dispatch(
                new DeleteRows(['records' => $idsToRemove->values()->toArray()],

The opening parenthesis of a multi-line function call should be the last content on the line.

                    $this->config('apiKey'), $this->config('baseId'),

It seems like $this->config('apiKey') can also be of type null; however, parameter $apiKey of BristolSU\ControlDB\Export\Handler\Airtable\DeleteRows::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $this->config('baseId') can also be of type null; however, parameter $baseId of BristolSU\ControlDB\Export\Handler\Airtable\DeleteRows::__construct() does only seem to accept string, maybe add an additional type check?

                    $this->config('tableName'))

It seems like $this->config('tableName') can also be of type null; however, parameter $tableName of BristolSU\ControlDB\Export\Handler\Airtable\DeleteRows::__construct() does only seem to accept string, maybe add an additional type check?

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 20.

For multi-line function calls, the closing parenthesis should be on a new line.

            )->delay($time);
            $time->addSeconds(2);
        }
        $idRetriever->saveIds([]);
        return $time;
    }


}