BristolSU\ControlDB\Repositories\DataPosition

Complexity

Total Complexity

11

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getAllWhere()	0	23	6
A	getWhere()	0	8	2
A	create()	0	5	1
A	getById()	0	3	1
A	update()	0	7	1

<?php

Missing file doc comment

namespace BristolSU\ControlDB\Repositories;


use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Support\Collection;

class DataPosition implements \BristolSU\ControlDB\Contracts\Repositories\DataPosition

Missing doc comment for class DataPosition

{

    /**
     * Get a data position by ID
     *
     * @param int $id

Missing parameter comment

     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function getById(int $id): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        return \BristolSU\ControlDB\Models\DataPosition::findOrFail($id);

The expression return BristolSU\ControlDB\Models\DataPosition::findOrFail($id) could return the type null which is incompatible with the type-hinted return BristolSU\ControlDB\Contracts\Models\DataPosition. Consider adding an additional type-check to rule them out.

    }

    /**
     * Get a data position with the given attributes, including additional attributes.
     *
     * @param array $attributes

Missing parameter comment

     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function getWhere($attributes = []): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        $positions = $this->getAllWhere($attributes);

        if($positions->count() > 0) {

Expected "if (...) {\n"; found "if(...) {\n"

            return $positions->first();
        }
        throw (new ModelNotFoundException())->setModel(DataPosition::class);
    }

    /**
     * Create a new data position
     *
     * @param string|null $name

Missing parameter comment

     * @param string|null $description

Missing parameter comment

     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function create(?string $name = null, ?string $description = null): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        return \BristolSU\ControlDB\Models\DataPosition::create([

The expression return BristolSU\ControlDB\Models\DataPosition::create(array('name' => $name, 'description' => $description)) could return the type null which is incompatible with the type-hinted return BristolSU\ControlDB\Contracts\Models\DataPosition. Consider adding an additional type-check to rule them out.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'name' => $name,
            'description' => $description,
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Get all data positions where the given attributes match, including additional attributes.
     *
     * @param array $attributes

Missing parameter comment

     * @return Collection

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function getAllWhere($attributes = []): Collection
    {
        $baseAttributes = $attributes;
        $additionalAttributes = [];
        foreach (\BristolSU\ControlDB\Models\DataPosition::getAdditionalAttributes() as $property) {
            if (array_key_exists($property, $baseAttributes)) {
                $additionalAttributes[$property] = $baseAttributes[$property];
                unset($baseAttributes[$property]);
            }
        }
        return \BristolSU\ControlDB\Models\DataPosition::where(function($query) use ($baseAttributes) {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 space after FUNCTION keyword; 0 found

            foreach($baseAttributes as $key => $value) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $query = $query->where($key, 'LIKE', '%' . $value . '%');
            }
            return $query;
        })->get()->filter(function (\BristolSU\ControlDB\Models\DataPosition $dataPosition) use ($additionalAttributes) {

For multi-line function calls, the closing parenthesis should be on a new line.

The opening parenthesis of a multi-line function call should be the last content on the line.

            foreach ($additionalAttributes as $additionalAttribute => $value) {
                if ($dataPosition->getAdditionalAttribute($additionalAttribute) !== $value) {
                    return false;
                }
            }
            return true;
        })->values();

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Update a data position with the given attributes
     *
     * @param int $id

Missing parameter comment

Expected 9 spaces after parameter type; 1 found

     * @param string|null $name Name of the position

Expected 8 spaces after parameter name; 1 found

     * @param string|null $description Description of the position
     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function update(int $id, ?string $name = null, ?string $description = null): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        $dataPosition = $this->getById($id)->fill([

The method fill() does not exist on BristolSU\ControlDB\Contracts\Models\DataPosition. Since it exists in all sub-types, consider adding an abstract or default implementation to BristolSU\ControlDB\Contracts\Models\DataPosition.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'name' => $name, 'description' => $description
        ]);  

For multi-line function calls, the closing parenthesis should be on a new line.

        $dataPosition->save();
        return $dataPosition;
    }
}