BristolSU\ControlDB\Observers\NotifyObservers\DataPositionNotifier

Complexity

Total Complexity

6

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Test Coverage

Coverage

78.95%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getById()	0	3	1
A	getAllWhere()	0	3	1
A	update()	0	6	1
A	getWhere()	0	3	1
A	create()	0	5	1

<?php

Missing file doc comment

namespace BristolSU\ControlDB\Observers\NotifyObservers;

use BristolSU\ControlDB\Contracts\Repositories\DataPosition as DataPositionRepository;
use BristolSU\ControlDB\Observers\NotifyObservers\Framework\Notifier;
use BristolSU\ControlDB\Observers\NotifyObservers\Framework\ObserverStore;
use Illuminate\Support\Collection;

class DataPositionNotifier extends Notifier implements DataPositionRepository

Missing doc comment for class DataPositionNotifier

{

    /**

Missing short description in doc comment

     * @var DataPositionRepository
     */
    private $dataPositionRepository;

Private member variable "dataPositionRepository" must be prefixed with an underscore

    public function __construct(DataPositionRepository $dataPositionRepository, ObserverStore $observerStore)

Missing doc comment for function __construct()

    {
        parent::__construct($observerStore, DataPositionRepository::class);
        $this->dataPositionRepository = $dataPositionRepository;
    }

    /**
     * Get a data position by ID
     *
     * @param int $id

Missing parameter comment

     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function getById(int $id): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        return $this->dataPositionRepository->getById($id);
    }

    /**
     * Get a data position where the given attributes match, including additional attributes.
     *
     * @param array $attributes

Missing parameter comment

     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function getWhere($attributes = []): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        return $this->dataPositionRepository->getWhere($attributes);
    }

    /**
     * Get all data positions where the given attributes match, including additional attributes.
     *
     * @param array $attributes

Missing parameter comment

     * @return Collection|\BristolSU\ControlDB\Contracts\Models\DataPosition[]

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function getAllWhere($attributes = []): Collection
    {
        return $this->dataPositionRepository->getAllWhere($attributes);
    }

    /**
     * Create a data position with the given attributes
     *
     * @param string|null $name Name of the position

Expected 8 spaces after parameter name; 1 found

     * @param string|null $description Description of the position
     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function create(?string $name = null, ?string $description = null): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        $dataPosition = $this->dataPositionRepository->create($name, $description);
        $this->notify('create', $dataPosition);
        return $dataPosition;
    }

    /**
     * Update a data position with the given attributes
     *
     * @param int $id

Missing parameter comment

Expected 9 spaces after parameter type; 1 found

     * @param string|null $name Name of the position

Expected 8 spaces after parameter name; 1 found

     * @param string|null $description Description of the position
     * @return \BristolSU\ControlDB\Contracts\Models\DataPosition

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function update(int $id, ?string $name = null, ?string $description = null): \BristolSU\ControlDB\Contracts\Models\DataPosition
    {
        $oldDataPosition = $this->getById($id);
        $newDataPosition = $this->dataPositionRepository->update($id, $name, $description);
        $this->notify('update', $oldDataPosition, $newDataPosition);
        return $newDataPosition;
    }
}