BristolSU\ControlDB\Http\Controllers\Role\RoleController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	8	1
A	store()	0	14	3
A	show()	0	3	1
A	update()	0	24	3
A	destroy()	0	3	1

<?php

Missing file doc comment

namespace BristolSU\ControlDB\Http\Controllers\Role;

use BristolSU\ControlDB\Http\Controllers\Controller;
use BristolSU\ControlDB\Http\Requests\Api\Role\StoreRoleRequest;
use BristolSU\ControlDB\Http\Requests\Api\Role\UpdateRoleRequest;
use BristolSU\ControlDB\Contracts\Repositories\DataRole as DataRoleRepository;
use BristolSU\ControlDB\Contracts\Repositories\Role as RoleRepository;
use BristolSU\ControlDB\Contracts\Models\Role;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;

/**
 * Handle roles
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @author tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class RoleController extends Controller
{

    /**
     * Get all roles
     *
     * @param Request $request

Missing parameter comment

Expected 8 spaces after parameter type; 1 found

     * @param RoleRepository $roleRepository

Missing parameter comment

     * @return LengthAwarePaginator

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function index(Request $request, RoleRepository $roleRepository)
    {
        $perPage = $request->input('per_page', 10);
        $page = $request->input('page', 1);

        return $this->paginationResponse(
            $roleRepository->paginate($page, $perPage),
            $roleRepository->count()
        );
    }

    /**
     * Get information about a specific role
     * 
     * @param Role $role

Missing parameter comment

     * @return Role

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function show(Role $role)
    {
        return $role;
    }

    /**
     * Create a new role
     * 
     * @param StoreRoleRequest $request

Missing parameter comment

Expected 3 spaces after parameter type; 1 found

     * @param RoleRepository $roleRepository

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

     * @param DataRoleRepository $dataRoleRepository

Missing parameter comment

     * @return Role

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function store(StoreRoleRequest $request, RoleRepository $roleRepository, DataRoleRepository $dataRoleRepository)
    {
        $dataRole = $dataRoleRepository->create(
            $request->input('role_name'),
            $request->input('email')
        );
        
        foreach($dataRole->getAdditionalAttributes() as $additionalAttribute) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            if($request->has($additionalAttribute)) {

Expected "if (...) {\n"; found "if(...) {\n"

                $dataRole->saveAdditionalAttribute($additionalAttribute, $request->input($additionalAttribute));
            }
        }
        
        return $roleRepository->create($request->input('position_id'), $request->input('group_id'), $dataRole->id());
    }

    /**
     * Update a role
     * 
     * @param Role $role

Missing parameter comment

Expected 15 spaces after parameter type; 1 found

     * @param UpdateRoleRequest $request

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

     * @param RoleRepository $roleRepository

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

     * @param DataRoleRepository $dataRoleRepository

Missing parameter comment

     * @return Role

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function update(Role $role, UpdateRoleRequest $request, RoleRepository $roleRepository, DataRoleRepository $dataRoleRepository)
    {
        $dataRole = $role->data();
        
        $dataRoleRepository->update(
            $dataRole->id(),
            $request->input('role_name', $dataRole->roleName()),
            $request->input('email', $dataRole->email()),
        );
        
        $roleRepository->update(
            $role->id(),
            $request->input('position_id', $role->positionId()),
            $request->input('group_id', $role->groupId()),
            $dataRole->id()
        );
        
        foreach($dataRole->getAdditionalAttributes() as $additionalAttribute) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            if($request->has($additionalAttribute)) {

Expected "if (...) {\n"; found "if(...) {\n"

                $dataRole->saveAdditionalAttribute($additionalAttribute, $request->input($additionalAttribute));
            }
        }
        
        return $roleRepository->getById($role->id());
    }

    /**
     * Delete a role
     * 
     * @param Role $role

Missing parameter comment

Expected 11 spaces after parameter type; 1 found

     * @param RoleRepository $roleRepository

Missing parameter comment

     */

Missing @return tag in function comment

    public function destroy(Role $role, RoleRepository $roleRepository)
    {
        $roleRepository->delete((int) $role->id());
    }


}