bristol-su / assign-roles

app/Http/Requests/ParticipantApi/AssignController/DestroyRequest.php

<?php

Missing file doc comment

namespace BristolSU\Module\AssignRoles\Http\Requests\ParticipantApi\AssignController;

use BristolSU\Module\AssignRoles\Rules\RoleBelongsToGroup;
use BristolSU\Module\AssignRoles\Rules\UserBelongsToRole;
use BristolSU\Module\AssignRoles\Rules\UserIsNotLoggedIntoRole;
use BristolSU\Support\Authentication\Contracts\Authentication;
use Illuminate\Contracts\Validation\Factory as ValidationFactory;
use Illuminate\Contracts\Validation\Validator;
use Illuminate\Foundation\Http\FormRequest;

class DestroyRequest extends FormRequest

Missing doc comment for class DestroyRequest

{

    public function validator(ValidationFactory $factory) 

Missing doc comment for function validator()

    {
        return $factory->make(
            ['role' => $this->route('role'), 'user' => $this->route('user')], 
            [
                'role' => ['required', app(RoleBelongsToGroup::class)],
                'user' => ['required', app(UserBelongsToRole::class, ['roleId' => $this->route('role')])]
            ]
        );
    }

    public function withValidator(Validator $validator)

Missing doc comment for function withValidator()

    {
        $validator->sometimes('role', app(UserIsNotLoggedIntoRole::class), function($input) {

app(BristolSU\Module\AssignRoles\Rules\UserIsNotLoggedIntoRole::class) of type BristolSU\Module\AssignRoles\Rules\UserIsNotLoggedIntoRole is incompatible with the type array|string expected by parameter $rules of Illuminate\Validation\Validator::sometimes().

The parameter $input is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 space after FUNCTION keyword; 0 found

            return app(Authentication::class)->getUser()->id() === (int) $this->route('user');
        });

For multi-line function calls, the closing parenthesis should be on a new line.

    }

}