RoleController::__construct() - Code Metrics - Inspection of "Optimize logic testing" - bristol-su/assign-roles - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 5dc10a...df61b8 )

by Toby

created 2020-03-30 16:59 UTC

RoleController::__construct() A

↳ Parent: RoleController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php


namespace BristolSU\Module\AssignRoles\Http\Controllers\ParticipantApi;

use BristolSU\ControlDB\Contracts\Repositories\DataRole;
use BristolSU\ControlDB\Contracts\Repositories\Role;
use BristolSU\Module\AssignRoles\Events\RoleCreated;
use BristolSU\Module\AssignRoles\Http\Controllers\Controller;
use BristolSU\Module\AssignRoles\Http\Requests\ParticipantApi\RoleController\DestroyRequest;
use BristolSU\Module\AssignRoles\Http\Requests\ParticipantApi\RoleController\StoreRequest;
use BristolSU\Module\AssignRoles\Http\Requests\ParticipantApi\RoleController\UpdateRequest;
use BristolSU\Support\Activity\Activity;
use BristolSU\Support\Authentication\Contracts\Authentication;
use BristolSU\Support\Logic\Contracts\LogicRepository;
use BristolSU\Support\Logic\Contracts\LogicTester;
use BristolSU\Support\ModuleInstance\ModuleInstance;

class RoleController extends Controller

{

    /**

     * @var LogicTester
     */
    private $logicTester;


    public function __construct(LogicTester $logicTester)

    {
        $this->logicTester = $logicTester;
    }

    public function index(Activity $activity, ModuleInstance $moduleInstance, Role $role, Authentication $authentication, LogicRepository $logicRepository)
    public function index(/** @scrutinizer ignore-unused */ Activity $activity, ModuleInstance $moduleInstance, Role $role, Authentication $authentication, LogicRepository $logicRepository)
    {
        $this->authorize('role.index');
        $roles = $role->allThroughGroup(
            $authentication->getGroup()
            /** @scrutinizer ignore-type */ $authentication->getGroup()
        );
        if(settings('logic_group', null) !== null) {

            $logic = $logicRepository->getById(settings('logic_group'));
            $logic = $logicRepository->getById(/** @scrutinizer ignore-type */ settings('logic_group'));
            
            $roles = $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($logic) {

                return $this->logicTester->evaluate($logic, null, $role->group(), $role);
            })->values();
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
        }
        
        return $roles->map(function(\BristolSU\ControlDB\Contracts\Models\Role $role) {

            $roleArray = $role->toArray();
            $roleArray['position'] = $role->position();
            $roleArray['users'] = $role->users();
            return $roleArray;
        });
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    public function store(Activity $activity, ModuleInstance $moduleInstance, StoreRequest $request, Role $roleRepository, DataRole $dataRoleRepository, Authentication $authentication)
    public function store(Activity $activity, /** @scrutinizer ignore-unused */ ModuleInstance $moduleInstance, StoreRequest $request, Role $roleRepository, DataRole $dataRoleRepository, Authentication $authentication)
    {
        $this->authorize('role.store');
        
        $dataRole = $dataRoleRepository->create(
            $request->input('role_name'),
            $request->input('email')
        );

        $role = $roleRepository->create(
            $request->input('position_id'),
            $authentication->getGroup()->id(),
            $dataRole->id()
        );
        
        event(new RoleCreated($role));
        
        return $role;
    }

    public function destroy(Activity $activity, ModuleInstance $moduleInstance, int $roleId, DestroyRequest $request, Role $roleRepository)
    public function destroy(Activity $activity, /** @scrutinizer ignore-unused */ ModuleInstance $moduleInstance, int $roleId, DestroyRequest $request, Role $roleRepository)
    {
        $this->authorize('role.delete');
        
        $roleRepository->delete($roleId);
    }

    public function update(Activity $activity, ModuleInstance $moduleInstance, int $roleId, UpdateRequest $request, Role $roleRepository, DataRole $dataRoleRepository)
    public function update(Activity $activity, ModuleInstance $moduleInstance, int $roleId, UpdateRequest $request, Role $roleRepository, /** @scrutinizer ignore-unused */ DataRole $dataRoleRepository)
    {
        $this->authorize('role.update');
        
        $role = $roleRepository->getById($roleId);
        $dataRole = $role->data();
        $dataRole->setEmail($request->input('email', $dataRole->email()));
        $dataRole->setRoleName($request->input('role_name', $dataRole->roleName()));
        return $dataRole;
    }
}

bristol-su / assign-roles

GitHub Access Token became invalid

Push — develop ( 5dc10a...df61b8 )

RoleController::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like