@@ -45,17 +45,17 @@ discard block |
||
| 45 | 45 | $remainingPositions = $this->positionsStillToFill($settings, $activityInstance, $moduleInstance); |
| 46 | 46 | } catch (SettingRetrievalException $e) { |
| 47 | 47 | Log::debug( |
| 48 | - sprintf( |
|
| 48 | + sprintf( |
|
| 49 | 49 | 'Setting could not be found for activity instance %d and module instance %d', |
| 50 | 50 | $activityInstance->id, |
| 51 | 51 | $moduleInstance->id() |
| 52 | - ) |
|
| 52 | + ) |
|
| 53 | 53 | ); |
| 54 | 54 | return false; |
| 55 | 55 | } |
| 56 | 56 | |
| 57 | 57 | Log::info('Result is ' . (count($remainingPositions) === 0 ? 'true' : 'false')); |
| 58 | - return count($remainingPositions) === 0; |
|
| 58 | + return count($remainingPositions) === 0; |
|
| 59 | 59 | } |
| 60 | 60 | |
| 61 | 61 | public function percentage($settings, ActivityInstance $activityInstance, ModuleInstance $moduleInstance): int |
@@ -93,7 +93,7 @@ discard block |
||
| 93 | 93 | |
| 94 | 94 | Log::info('Roles to be used: ' . json_encode($roles->map(function($role) { |
| 95 | 95 | return $role->id(); |
| 96 | - }))); |
|
| 96 | + }))); |
|
| 97 | 97 | |
| 98 | 98 | Log::info('Required positions ' . (string) collect($this->getRequiredPositions($settings, $group))); |
| 99 | 99 | return collect($this->getRequiredPositions($settings, $group))->filter(function(int $positionId) use ($roles) { |
@@ -183,8 +183,8 @@ discard block |
||
| 183 | 183 | { |
| 184 | 184 | $roles = $group->roles(); |
| 185 | 185 | Log::info('Roles through group pre logic filtering: ' . json_encode($roles->map(function($role) { |
| 186 | - return $role->id(); |
|
| 187 | - }))); |
|
| 186 | + return $role->id(); |
|
| 187 | + }))); |
|
| 188 | 188 | if($this->logicGroupId($moduleInstance) !== null) { |
| 189 | 189 | $logicGroup = app(LogicRepository::class)->getById($this->logicGroupId($moduleInstance)); |
| 190 | 190 | return $roles->filter(function(\BristolSU\ControlDB\Contracts\Models\Role $role) use ($moduleInstance, $logicGroup) { |
@@ -193,8 +193,8 @@ discard block |
||
| 193 | 193 | } |
| 194 | 194 | |
| 195 | 195 | Log::info('Roles through group post logic filtering: ' . json_encode($roles->map(function($role) { |
| 196 | - return $role->id(); |
|
| 197 | - }))); |
|
| 196 | + return $role->id(); |
|
| 197 | + }))); |
|
| 198 | 198 | |
| 199 | 199 | return $roles; |
| 200 | 200 | } |