BristolSU\Module\AssignRoles\Http\Controllers\ParticipantPageController::index()

Complexity

Conditions	2
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function index(Authentication $authentication)

Missing doc comment for function index()

    {
        $this->authorize('view-page');
        
        try {
            $setting = app(PositionSettingRetrieval::class)->getSettings(
                $authentication->getGroup()

It seems like $authentication->getGroup() can also be of type null; however, parameter $group of BristolSU\Module\AssignRoles\Support\PositionSettingRetrieval::getSettings() does only seem to accept BristolSU\ControlDB\Contracts\Models\Group, maybe add an additional type check?

            );
            $setting = app(PositionSettingRetrieval::class)->parse($setting);
        } catch (SettingRetrievalException $e) {
            return view('assign-roles::nosettings');
        }
        return view('assign-roles::participant')->with('positionSetting', $setting);
    }
}