BristolSU\AirTable\Jobs\FlushRows

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

96.3%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	withDebug()	0	4	1
A	handle()	0	16	2
A	__construct()	0	5	1
A	log()	0	4	2

<?php

Missing file doc comment

namespace BristolSU\AirTable\Jobs;

use BristolSU\AirTable\AirTable;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Support\Facades\Log;

class FlushRows implements ShouldQueue

Missing doc comment for class FlushRows

{
    use Dispatchable, Queueable;

    private string $apiKey;

Private member variable "apiKey" must be prefixed with an underscore

    private string $baseId;

Private member variable "baseId" must be prefixed with an underscore

    private string $tableName;

Private member variable "tableName" must be prefixed with an underscore

    private bool $debug = false;

Private member variable "debug" must be prefixed with an underscore

    public function __construct(string $apiKey, string $baseId, string $tableName)

Missing doc comment for function __construct()

    {
        $this->apiKey = $apiKey;
        $this->baseId = $baseId;
        $this->tableName = $tableName;
    }

    public function handle(AirTable $airTable)

Missing doc comment for function handle()

    {
        $airTable->setApiKey($this->apiKey);
        $airTable->setBaseId($this->baseId);
        $airTable->setTableName($this->tableName);
        $this->log('Retrieving IDs');
        $ids = $airTable->getIdsFromTable();
        $this->log('Retrieved IDs');
        $this->log('Deleting Rows');
        foreach(array_chunk($ids, 50) as $idsToDelete) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            dispatch((new DeleteRows(

The opening parenthesis of a multi-line function call should be the last content on the line.

                $idsToDelete,
                $this->apiKey,
                $this->baseId,
                $this->tableName)

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

For multi-line function calls, the closing parenthesis should be on a new line.

            )->withDebug($this->debug));

For multi-line function calls, the closing parenthesis should be on a new line.

        }
    }

    public function withDebug(bool $debug)

Missing doc comment for function withDebug()

    {
        $this->debug = $debug;
        return $this;
    }

    private function log(string $string)

Private method name "FlushRows::log" must be prefixed with an underscore

Missing doc comment for function log()

    {
        if($this->debug) {

Expected "if (...) {\n"; found "if(...) {\n"

            Log::debug($string);
        }
    }
}