BristolSU\AirTable\Control\AirtableHandler::save()

Complexity

Conditions	3
Paths	4

Size

Total Lines	31
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function save(array $items)
    {
        $creating = [];
        
        foreach($items as $item) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            $creating[] = $item->toArray();
        }

        $this->log('Flushing rows');
        
        dispatch_now(
            (new FlushRows(
                $this->config('apiKey'),

It seems like $this->config('apiKey') can also be of type null; however, parameter $apiKey of BristolSU\AirTable\Jobs\FlushRows::__construct() does only seem to accept string, maybe add an additional type check?

                $this->config('baseId'),

It seems like $this->config('baseId') can also be of type null; however, parameter $baseId of BristolSU\AirTable\Jobs\FlushRows::__construct() does only seem to accept string, maybe add an additional type check?

                $this->config('tableName')

It seems like $this->config('tableName') can also be of type null; however, parameter $tableName of BristolSU\AirTable\Jobs\FlushRows::__construct() does only seem to accept string, maybe add an additional type check?

            ))->withDebug($this->config('debug', false))

It seems like $this->config('debug', false) can also be of type null; however, parameter $debug of BristolSU\AirTable\Jobs\FlushRows::withDebug() does only seem to accept boolean, maybe add an additional type check?

        );

        $this->log('Flushed rows. Creating records');


        foreach(array_chunk($creating, 10) as $data) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            dispatch((new CreateRecords(

The opening parenthesis of a multi-line function call should be the last content on the line.

                $data,
                $this->config('apiKey'),

It seems like $this->config('apiKey') can also be of type null; however, parameter $apiKey of BristolSU\AirTable\Jobs\CreateRecords::__construct() does only seem to accept string, maybe add an additional type check?

                $this->config('baseId'),

It seems like $this->config('baseId') can also be of type null; however, parameter $baseId of BristolSU\AirTable\Jobs\CreateRecords::__construct() does only seem to accept string, maybe add an additional type check?

                $this->config('tableName')

It seems like $this->config('tableName') can also be of type null; however, parameter $tableName of BristolSU\AirTable\Jobs\CreateRecords::__construct() does only seem to accept string, maybe add an additional type check?

            ))->withDebug($this->config('debug', false)));

It seems like $this->config('debug', false) can also be of type null; however, parameter $debug of BristolSU\AirTable\Jobs\CreateRecords::withDebug() does only seem to accept boolean, maybe add an additional type check?

For multi-line function calls, the closing parenthesis should be on a new line.

        }

        $this->log('Created Records');