BringYourOwnIdeas\Maintenance\Tests\Util\SupportedAddonsLoaderTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testCallbackReturnsAddonsFromBody()	0	14	1
A	setUp()	0	7	1
A	testValueOfDoRequestIsReturned()	0	7	1
A	testCallsSupportedAddonsEndpoint()	0	9	1

<?php

namespace BringYourOwnIdeas\Maintenance\Tests\Util;

use BringYourOwnIdeas\Maintenance\Util\SupportedAddonsLoader;
use SilverStripe\Dev\SapphireTest;

class SupportedAddonsLoaderTest extends SapphireTest
{
    /**
     * @var SupportedAddonsLoader
     */
    protected $loader;

    protected function setUp()
    {
        parent::setUp();

        $this->loader = $this->getMockBuilder(SupportedAddonsLoader::class)

It seems like $this->getMockBuilder(BringYourOwnIdeas\Maintenance\Util\SupportedAddonsLoader::class)->setMethods(array('doRequest'))->getMock() of type PHPUnit_Framework_MockObject_MockObject is incompatible with the declared type BringYourOwnIdeas\Maintenance\Util\SupportedAddonsLoader of property $loader.

            ->setMethods(['doRequest'])
            ->getMock();
    }

    public function testCallsSupportedAddonsEndpoint()
    {
        $this->loader->expects($this->once())

The method expects() does not exist on BringYourOwnIdeas\Maintenance\Util\SupportedAddonsLoader. Since you implemented __call, consider adding a @method annotation.

            ->method('doRequest')
            ->with('addons.silverstripe.org/api/supported-addons', function () {
                // no-op
            });

        $this->loader->getAddonNames();
    }

    public function testCallbackReturnsAddonsFromBody()
    {
        $this->loader->expects($this->once())
            ->method('doRequest')
            ->with($this->isType('string'), $this->isType('callable'))
            ->will($this->returnArgument(1));

        $result = $this->loader->getAddonNames();
        $mockResponse = [
            'foo' => 'bar',
            'addons' => 'baz',
        ];

        $this->assertSame('baz', $result($mockResponse));
    }

    public function testValueOfDoRequestIsReturned()
    {
        $this->loader->expects($this->once())
            ->method('doRequest')
            ->willReturn('hello world');

        $this->assertSame('hello world', $this->loader->getAddonNames());
    }
}