SiteSummaryExtensionTest::setUpBeforeClass() - Code Metrics - Inspection of "FIX Always run SapphireTest::setUp even when skipp..." - bringyourownideas/silverstripe-composer-security-checker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 18138a...683a55 )

by Robbie

created 2018-06-12 03:03 UTC

SiteSummaryExtensionTest::setUpBeforeClass() A

↳ Parent: SiteSummaryExtensionTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	0
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace BringYourOwnIdeas\SecurityChecker\Tests\Extensions;

use BringYourOwnIdeas\Maintenance\Model\Package;
filter:
    dependency_paths: ["lib/*"]
use BringYourOwnIdeas\Maintenance\Reports\SiteSummary;
filter:
    dependency_paths: ["lib/*"]
use BringYourOwnIdeas\SecurityChecker\Tests\Stubs\SiteSummaryAlertStub;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\LiteralField;
use SilverStripe\View\SSViewer;
use Symbiote\QueuedJobs\Services\QueuedJobService;

class SiteSummaryExtensionTest extends SapphireTest
{
    protected static $fixture_file = 'PackageSecurityExtensionTest.yml';

    protected static $required_extensions = [
        SiteSummary::class => [SiteSummaryAlertStub::class]
    ];

    public static function setUpBeforeClass()
    {
        if (!class_exists(Package::class)) {
            static::$required_extensions = [];
        }
        return parent::setUpBeforeClass();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    protected function setUp()
    {
        if (!class_exists(Package::class)) {
            static::$fixture_file = null;
            parent::setUp();
            $this->markTestSkipped(
                'Module bringyourownideas/silverstripe-maintenance is required for this test, but is not present.'
            );
        }

        QueuedJobService::config()->set('use_shutdown_function', false);

        // The themes should not affect test results.
        // Ensure we use the default templates supplied with this module.
        Config::modify()->set(SSViewer::class, 'theme_enabled', false);

        parent::setUp();
    }

    public function testDisplayColumnsDoesNotIncludePrintingColumns()
    {
        $report = Injector::inst()->create(SiteSummary::class);
        // screen output should not include this summary field added by the extension
        $this->assertArrayNotHasKey('listSecurityAlertIdentifiers', $report->columns());
        // default summary fields are still used for print output (e.g. CSV export)
        $this->assertArrayHasKey('listSecurityAlertIdentifiers', Package::create()->summaryFields());
    }

    public function testUpdateAlerts()
    {
        /** @var SiteSummary $report */
        $report = Injector::inst()->create(SiteSummary::class);
        $fields = $report->getCMSFields();

        /** @var LiteralField $alertSummary */
        $alertSummary = $fields->fieldByName('AlertSummary');
        $this->assertInstanceOf(LiteralField::class, $alertSummary);

        $content = $alertSummary->getContent();
        $this->assertContains(
            'Sound the alarm!',
            $content,
            'ensure our extension doesn\'t override all others'
        );
        $this->assertContains(
            'site-summary__security-alerts',
            $content,
            'ensure content from our extension is present'
        );
        $this->assertContains(
            '<strong>2</strong>',
            $content,
            'ensure we are counting modules with alerts, not the total number of alerts'
        );
    }
}


1			<?php
2
3			namespace BringYourOwnIdeas\SecurityChecker\Tests\Extensions;
4
5			use BringYourOwnIdeas\Maintenance\Model\Package;
			0 ignored issues – show Bug introduced 2018-06-11 22:02 UTC by Report Bug Copy Issue Report The type `BringYourOwnIdeas\Maintenance\Model\Package` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use BringYourOwnIdeas\Maintenance\Reports\SiteSummary;
			0 ignored issues – show Bug introduced 2018-06-11 22:02 UTC by Report Bug Copy Issue Report The type `BringYourOwnIdeas\Maintenance\Reports\SiteSummary` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7			use BringYourOwnIdeas\SecurityChecker\Tests\Stubs\SiteSummaryAlertStub;
8			use SilverStripe\Core\Config\Config;
9			use SilverStripe\Core\Injector\Injector;
10			use SilverStripe\Dev\SapphireTest;
11			use SilverStripe\Forms\LiteralField;
12			use SilverStripe\View\SSViewer;
13			use Symbiote\QueuedJobs\Services\QueuedJobService;
14
15			class SiteSummaryExtensionTest extends SapphireTest
16			{
17			protected static $fixture_file = 'PackageSecurityExtensionTest.yml';
18
19			protected static $required_extensions = [
20			SiteSummary::class => [SiteSummaryAlertStub::class]
21			];
22
23			public static function setUpBeforeClass()
24			{
25			if (!class_exists(Package::class)) {
26			static::$required_extensions = [];
27			}
28			return parent::setUpBeforeClass();
			0 ignored issues – show Bug introduced 2018-06-12 03:05 UTC by Report Bug Copy Issue Report Are you sure the usage of `parent::setUpBeforeClass()` targeting `SilverStripe\Dev\SapphireTest::setUpBeforeClass()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
29			}
30
31			protected function setUp()
32			{
33			if (!class_exists(Package::class)) {
34			static::$fixture_file = null;
35			parent::setUp();
36			$this->markTestSkipped(
37			'Module bringyourownideas/silverstripe-maintenance is required for this test, but is not present.'
38			);
39			}
40
41			QueuedJobService::config()->set('use_shutdown_function', false);
42
43			// The themes should not affect test results.
44			// Ensure we use the default templates supplied with this module.
45			Config::modify()->set(SSViewer::class, 'theme_enabled', false);
46
47			parent::setUp();
48			}
49
50			public function testDisplayColumnsDoesNotIncludePrintingColumns()
51			{
52			$report = Injector::inst()->create(SiteSummary::class);
53			// screen output should not include this summary field added by the extension
54			$this->assertArrayNotHasKey('listSecurityAlertIdentifiers', $report->columns());
55			// default summary fields are still used for print output (e.g. CSV export)
56			$this->assertArrayHasKey('listSecurityAlertIdentifiers', Package::create()->summaryFields());
57			}
58
59			public function testUpdateAlerts()
60			{
61			/** @var SiteSummary $report */
62			$report = Injector::inst()->create(SiteSummary::class);
63			$fields = $report->getCMSFields();
64
65			/** @var LiteralField $alertSummary */
66			$alertSummary = $fields->fieldByName('AlertSummary');
67			$this->assertInstanceOf(LiteralField::class, $alertSummary);
68
69			$content = $alertSummary->getContent();
70			$this->assertContains(
71			'Sound the alarm!',
72			$content,
73			'ensure our extension doesn\'t override all others'
74			);
75			$this->assertContains(
76			'site-summary__security-alerts',
77			$content,
78			'ensure content from our extension is present'
79			);
80			$this->assertContains(
81			'<strong>2</strong>',
82			$content,
83			'ensure we are counting modules with alerts, not the total number of alerts'
84			);
85			}
86			}
87

bringyourownideas / silverstripe-composer-security-checker

Push — master ( 18138a...683a55 )

SiteSummaryExtensionTest::setUpBeforeClass() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like