CVECheckTaskTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	87
Duplicated Lines	43.68 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	getSecurityCheckerMock()	0	24	2
A	testUpdatesAreSaved()	0	14	1
A	testNoDuplicates()	19	19	1
A	testCVERemovals()	19	19	1

<?php

use SensioLabs\Security\SecurityChecker;

class CVECheckTaskTest extends SapphireTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $usesDatabase = true;

    /**
     * provide a mock to remove dependency on external service
     */
    protected function getSecurityCheckerMock($empty = false)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $mockOutput = <<<CVENOTICE
{
    "symfony\/symfony": {
        "version": "2.1.x-dev",
        "advisories": {
            "symfony\/symfony\/CVE-2013-1397.yaml": {
                "title": "Ability to enable\/disable object support in YAML parsing and dumping",
                "link": "http:\/\/symfony.com\/blog\/security-release-symfony-2-0-22-and-2-1-7-released",
                "cve": "CVE-2013-1397"
            }
        }
    }
}
CVENOTICE;

        $securityCheckerMock = $this->getMockBuilder(SecurityChecker::class)->setMethods(['check'])->getMock();

The method getMockBuilder() does not seem to exist on object<CVECheckTaskTest>.

        $securityCheckerMock->expects($this->any())->method('check')->will($this->returnValue(

The method any() does not seem to exist on object<CVECheckTaskTest>.

The method returnValue() does not seem to exist on object<CVECheckTaskTest>.

            $empty ? [] : json_decode($mockOutput, true)
        ));

        return $securityCheckerMock;
    }

    public function testUpdatesAreSaved()
    {
        $securityCheckerMock = $this->getSecurityCheckerMock();
        $checkTask = new CVECheckTask;
        $checkTask->setSecurityChecker($securityCheckerMock);

        $preCheck = CVE::get();
        $this->assertCount(0, $preCheck, 'database is empty to begin with');

The method assertCount() does not seem to exist on object<CVECheckTaskTest>.

        $checkTask->run(null);

        $postCheck = CVE::get();
        $this->assertCount(1, $postCheck, 'CVE has been stored');

The method assertCount() does not seem to exist on object<CVECheckTaskTest>.

    }

    public function testNoDuplicates()

This method seems to be duplicated in your project.

    {
        $securityCheckerMock = $this->getSecurityCheckerMock();
        $checkTask = new CVECheckTask;
        $checkTask->setSecurityChecker($securityCheckerMock);

        $preCheck = CVE::get();
        $this->assertCount(0, $preCheck, 'database is empty to begin with');

The method assertCount() does not seem to exist on object<CVECheckTaskTest>.

        $checkTask->run(null);

        $postCheck = CVE::get();
        $this->assertCount(1, $postCheck, 'CVE has been stored');

The method assertCount() does not seem to exist on object<CVECheckTaskTest>.

        
        $checkTask->run(null);

        $postCheck = CVE::get();
        $this->assertCount(1, $postCheck, 'The CVE isn\'t stored twice.');

The method assertCount() does not seem to exist on object<CVECheckTaskTest>.

    }

    public function testCVERemovals()

This method seems to be duplicated in your project.

    {
        $securityCheckerMock = $this->getSecurityCheckerMock();
        $checkTask = new CVECheckTask;
        $checkTask->setSecurityChecker($securityCheckerMock);

        $checkTask->run(null);

        $preCheck = CVE::get();
        $this->assertCount(1, $preCheck, 'database has stored CVEs');

The method assertCount() does not seem to exist on object<CVECheckTaskTest>.

        $securityCheckerMock = $this->getSecurityCheckerMock(true);
        $checkTask->setSecurityChecker($securityCheckerMock);

        $checkTask->run(null);

        $postCheck = CVE::get();
        $this->assertCount(0, $postCheck, 'database is empty to finish with');

The method assertCount() does not seem to exist on object<CVECheckTaskTest>.

    }
}