BrightNucleus\Dependency\AbstractDependencyHandler

Complexity

Total Complexity

4

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	3	1
	get_register_function()	0	1	?
A	enqueue()	0	3	1
	get_enqueue_function()	0	1	?
A	maybe_enqueue()	0	6	2
	is_registered()	0	1	?

<?php
/**
 * AbstractDependencyHandler Class
 *
 * @package   BrightNucleus\Dependency
 * @author    Alain Schlesser <alain.schlesser@gmail.com>
 * @license   GPL-2.0+
 * @link      http://www.brightnucleus.com/
 * @copyright 2015-2016 Alain Schlesser, Bright Nucleus
 */

namespace BrightNucleus\Dependency;

use BrightNucleus\Exception\InvalidArgumentException;
use BrightNucleus\Invoker\FunctionInvokerTrait;

/**
 * Abstract dependency.
 *
 * @since   0.1.0
 *
 * @package BrightNucleus\Dependency
 */
abstract class AbstractDependencyHandler implements DependencyHandlerInterface {

	use FunctionInvokerTrait;

	/**
	 * Register the dependency's assets.
	 *
	 * @since 0.1.0
	 *
	 * @param array $args               Optional. Array of arguments that is

Should the type for parameter $args not be array|null? Also, consider making the array more specific, something like array<String>, or String[].

	 *                                  passed to the registration function.
	 * @throws InvalidArgumentException If the register function could not be
	 *                                  called.
	 */
	public function register( $args = null ) {
		$this->invokeFunction( $this->get_register_function(), $args );

It seems like $args defined by parameter $args on line 38 can also be of type null; however, BrightNucleus\Invoker\FunctionInvokerTrait::invokeFunction() does only seem to accept array, maybe add an additional type check?

	}

	/**
	 * Get the name of the function that is used for registering the dependency.
	 *
	 * @since 0.1.0
	 *
	 * @return string Function name.
	 */
	abstract protected function get_register_function();

	/**
	 * Enqueue the dependency's assets.
	 *
	 * @since 0.1.0
	 *
	 * @param array $args               Optional. Array of arguments that is

Should the type for parameter $args not be array|null? Also, consider making the array more specific, something like array<String>, or String[].

	 *                                  passed to the enqueueing function.
	 * @throws InvalidArgumentException If the register function could not be
	 *                                  called.
	 */
	public function enqueue( $args = null ) {
		$this->invokeFunction( $this->get_enqueue_function(), $args );

It seems like $args defined by parameter $args on line 61 can also be of type null; however, BrightNucleus\Invoker\FunctionInvokerTrait::invokeFunction() does only seem to accept array, maybe add an additional type check?

	}

	/**
	 * Get the name of the function that is used for enqueueing the dependency.
	 *
	 * @since 0.1.0
	 *
	 * @return string Function name.
	 */
	abstract protected function get_enqueue_function();

	/**
	 * Maybe enqueue a dependency that has been registered outside of the
	 * Dependency Manager.
	 *
	 * @since 0.2.3
	 *
	 * @param string $handle Handle of the dependency to enqueue.
	 */
	public function maybe_enqueue( $handle ) {
		if ( $this->is_registered( $handle ) ) {
			$enqueue = $this->get_enqueue_function();
			$enqueue( $handle );
		}
	}

	/**
	 * Check whether a specific handle has been registered.
	 *
	 * @since 0.2.3
	 *
	 * @param string $handle The handle to check
	 * @return bool Whether it is registered or not.
	 */
	abstract protected function is_registered( $handle );
}