PreparesCustomRulesForServiceValidator - Code Metrics - Inspection of "Merge pull request #7 from devcircus/fixes-to-cust..." - bright-components/valid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4b1b4c...a4255f )

by Clayton

created 2018-07-24 22:05 UTC

PreparesCustomRulesForServiceValidator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	15
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	1
dl	15
loc	15
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	prepareCustomRules()	9	9	1

How to fix Duplicated Code

<?php

namespace BrightComponents\Valid\Traits;

use BrightComponents\Valid\CustomRule;

trait PreparesCustomRulesForServiceValidator

{
    /**
     * Set the validator and service validator properties on Custom Rules.
     */
    public function prepareCustomRules()
    {
        collect($this->rules())->each(function ($rules, $attribute) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            collect(array_wrap($rules))->whereInstanceOf(CustomRule::class)->each(function ($rule) {
                $rule::validator($this->getValidator());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $rule::service($this);
            });
        });
    }
}


1		<?php
2
3		namespace BrightComponents\Valid\Traits;
4
5		use BrightComponents\Valid\CustomRule;
6
7	View Code Duplication	trait PreparesCustomRulesForServiceValidator
		0 ignored issues – show Duplication introduced 2018-07-24 21:55 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		/**
10		* Set the validator and service validator properties on Custom Rules.
11		*/
12		public function prepareCustomRules()
13		{
14		collect($this->rules())->each(function ($rules, $attribute) {
		0 ignored issues – show Bug introduced 2018-07-09 01:19 UTC by Report Bug Copy Issue Report It seems like `rules()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Unused Code introduced 2018-07-09 01:19 UTC by Report Bug Copy Issue Report The parameter `$attribute` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
15		collect(array_wrap($rules))->whereInstanceOf(CustomRule::class)->each(function ($rule) {
16		$rule::validator($this->getValidator());
		0 ignored issues – show Bug introduced 2018-07-24 21:55 UTC by Report Bug Copy Issue Report It seems like `getValidator()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17		$rule::service($this);
18		});
19		});
20		}
21		}
22

bright-components / valid

Push — master ( 4b1b4c...a4255f )

PreparesCustomRulesForServiceValidator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like