Issues in ServiceMakeCommand.php (master) - Issues in master - bright-components/services - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Commands/ServiceMakeCommand.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace BrightComponents\Services\Commands;

use Illuminate\Support\Facades\Config;
use Illuminate\Console\GeneratorCommand;
use BrightComponents\Services\Exceptions\InvalidNamespaceException;

class ServiceMakeCommand extends GeneratorCommand
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'adr:service {name}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create new service definition and handler classes';

    /**
     * The type of class being generated.
     *
     * @var string
     */
    protected $type = 'Service';

    /**
     * Execute the console command.
     */
    public function handle()
    {
        if (false === parent::handle() && ! $this->option('force')) {
            return;
        }
    }

    /**
     * Get the stub file for the generator.
     *
     * @return string
     */
    protected function getStub()
    {
        return __DIR__.'/stubs/service.stub';
    }

    /**
     * Get the default namespace for the class.
     *
     * @param  string  $rootNamespace
     *
     * @return string
     */
    protected function getDefaultNamespace($rootNamespace)
    {
        $serviceRootNamespace = Config::get('service-classes.namespace');

        if (! $serviceRootNamespace) {
            throw InvalidNamespaceException::missingServiceNamespace();
        }

        return $rootNamespace.'\\'.$serviceRootNamespace;
    }

    /**
     * Get the method name for the class.
     *
     * @param  string  $rootNamespace
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return string
     */
    protected function getMethodName()
    {
        return Config::get('service-classes.method', 'run');
    }

    /**
     * Get the desired class name from the input.
     *
     * @return string
     */
    protected function getNameInput()
    {
        $input = $input = studly_case(trim($this->argument('name')));
        $suffix = Config::get('service-classes.suffix');

        if (Config::get('service-classes.override_duplicate_suffix')) {
            return str_finish($input, $suffix);
        }

        return $input.$suffix;
    }

    /**
     * Build the class with the given name.
     *
     * @param  string  $name
     *
     * @return string
     */
    protected function buildClass($name)
    {
        $stub = $this->files->get($this->getStub());

        return $this->replaceNamespace($stub, $name)->replaceMethod($stub)->replaceClass($stub, $name);
    }

    /**
     * Replace the method name in the given stub.
     *
     * @param  string  $stub
     * @param  string  $name
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return $this
     */
    protected function replaceMethod(&$stub)
    {
        $stub = str_replace(
            ['DummyMethod'],
            [$this->getMethodName()],
            $stub
        );

        return $this;
    }
}


1			<?php
2
3			namespace BrightComponents\Services\Commands;
4
5			use Illuminate\Support\Facades\Config;
6			use Illuminate\Console\GeneratorCommand;
7			use BrightComponents\Services\Exceptions\InvalidNamespaceException;
8
9			class ServiceMakeCommand extends GeneratorCommand
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'adr:service {name}';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Create new service definition and handler classes';
24
25			/**
26			* The type of class being generated.
27			*
28			* @var string
29			*/
30			protected $type = 'Service';
31
32			/**
33			* Execute the console command.
34			*/
35			public function handle()
36			{
37			if (false === parent::handle() && ! $this->option('force')) {
38			return;
39			}
40			}
41
42			/**
43			* Get the stub file for the generator.
44			*
45			* @return string
46			*/
47			protected function getStub()
48			{
49			return __DIR__.'/stubs/service.stub';
50			}
51
52			/**
53			* Get the default namespace for the class.
54			*
55			* @param string $rootNamespace
56			*
57			* @return string
58			*/
59			protected function getDefaultNamespace($rootNamespace)
60			{
61			$serviceRootNamespace = Config::get('service-classes.namespace');
62
63			if (! $serviceRootNamespace) {
64			throw InvalidNamespaceException::missingServiceNamespace();
65			}
66
67			return $rootNamespace.'\\'.$serviceRootNamespace;
68			}
69
70			/**
71			* Get the method name for the class.
72			*
73			* @param string $rootNamespace
			0 ignored issues – show Bug introduced 2018-07-08 04:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$rootNamespace`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
74			*
75			* @return string
76			*/
77			protected function getMethodName()
78			{
79			return Config::get('service-classes.method', 'run');
80			}
81
82			/**
83			* Get the desired class name from the input.
84			*
85			* @return string
86			*/
87			protected function getNameInput()
88			{
89			$input = $input = studly_case(trim($this->argument('name')));
90			$suffix = Config::get('service-classes.suffix');
91
92			if (Config::get('service-classes.override_duplicate_suffix')) {
93			return str_finish($input, $suffix);
94			}
95
96			return $input.$suffix;
97			}
98
99			/**
100			* Build the class with the given name.
101			*
102			* @param string $name
103			*
104			* @return string
105			*/
106			protected function buildClass($name)
107			{
108			$stub = $this->files->get($this->getStub());
109
110			return $this->replaceNamespace($stub, $name)->replaceMethod($stub)->replaceClass($stub, $name);
111			}
112
113			/**
114			* Replace the method name in the given stub.
115			*
116			* @param string $stub
117			* @param string $name
			0 ignored issues – show Bug introduced 2018-07-08 04:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$name`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
118			*
119			* @return $this
120			*/
121			protected function replaceMethod(&$stub)
122			{
123			$stub = str_replace(
124			['DummyMethod'],
125			[$this->getMethodName()],
126			$stub
127			);
128
129			return $this;
130			}
131			}
132

bright-components / services

Issues (8)

Security Analysis no request data

src/Commands/ServiceMakeCommand.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like