BrightComponents\Responder\Responder

Complexity

Total Complexity

5

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
	respond()	0	1	?
A	withPayload()	0	6	2
A	withRequest()	0	6	1
A	flash()	0	4	1

<?php

namespace BrightComponents\Responder;

use Illuminate\Http\Request;
use DevMarketer\LaraFlash\LaraFlash;
use BrightComponents\Common\Payloads\AbstractPayload;

abstract class Responder
{
    /**
     * The response payload.
     *
     * @var mixed
     */
    protected $payload;

    /**
     * Laraflash for flashing to session.
     *
     * @var \DevMarketer\LaraFlash\LaraFlash
     */
    protected $flash;

    /**
     * Construct a new base Responder.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \DevMarketer\LaraFlash\LaraFlash  $flash
     */
    public function __construct(Request $request, LaraFlash $flash)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;

The property request does not exist. Did you maybe forget to declare it?

        $this->flash = $flash;
    }

    /**
     * Send a response.
     *
     * @return mixed
     */
    abstract public function respond();

    /**
     * Add the payload to the response.
     *
     * @param  mixed  $payload
     *
     * @return $this
     */
    public function withPayload($payload)
    {
        $this->payload = $payload instanceof AbstractPayload ? $payload->getData() : $payload;

The class BrightComponents\Common\Payloads\AbstractPayload does not exist. Did you forget a USE statement, or did you not list all dependencies?

        return $this;
    }

    /**
     * Add the request to the response.
     *
     * @param  \Illuminate\Http\Request  $request
     *
     * @return $this
     */
    public function withRequest(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;

        return $this;
    }

    /**
     * Flash data to the session.
     *
     * @param  string $key

There is no parameter named $key. Was it maybe removed?

     * @param  mixed  $value

There is no parameter named $value. Was it maybe removed?

     */
    protected function flash($message, array $options = [])
    {
        return $this->flash->add($message, $options);
    }
}