Bag - Code Metrics - Inspection of "Rollback on env setting from webservice tests" - bricev/JobQueue - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v2 ( 9bff46...d4d6f5 )

by Brice

created 2018-03-07 14:07 UTC

Bag A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	12
dl	0
loc	111
rs	10
c	0
b	0
f	0
ccs	2
cts	25
cp	0.08

11 Methods

Rating	Name	Size	Complexity
A	key()	3	1
A	next()	3	1
A	unserialize()	3	1
A	__toArray()	3	1
A	valid()	3	1
A	serialize()	3	1
A	rewind()	3	1
A	count()	3	1
A	current()	3	1
A	seek()	7	2
A	jsonSerialize()	3	1

<?php

namespace JobQueue\Domain\Utils;

abstract class Bag implements \Countable, \SeekableIterator, \Serializable, \JsonSerializable
{
    /**
     *
     * @var array
     */
    protected $data = [];

    /**
     *
     * @return int
     */
    public function count(): int
    {
        return count($this->data);
    }


    /**
     *
     * @param int $key
     * @return int
     */
    public function seek($key)
    {
        if (!isset($this->data[$key])) {
            throw new \OutOfBoundsException;
        }

        return $key;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     *
     * @return mixed
     */
    public function current()
    {
        return current($this->data);
    }

    /**
     *
     * @return mixed
     */
    public function next()
    {
        return next($this->data);
    }

    /**
     *
     * @return mixed
     */
    public function key()
    {
        return key($this->data);
    }

    /**
     *
     * @return bool
     */
    public function valid(): bool
    {
        return null !== key($this->data);
    }

    /**
     *
     * @return mixed
     */
    public function rewind()
    {
        return reset($this->data);
    }

    /**
     *
     * @return string
     */
    public function serialize(): string
    {
        return serialize($this->data);
    }

    /**
     *
     * @param string $serialized
     */
    public function unserialize($serialized)
    {
        $this->data = unserialize($serialized);
    }

    /**
     *
     * @return array
     */
    public function jsonSerialize(): array
    {
        return $this->data;
    }

    /**
     *
     * @return array
     */
    public function __toArray(): array
    {
        return $this->data;
    }
}


1		<?php
2
3		namespace JobQueue\Domain\Utils;
4
5		abstract class Bag implements \Countable, \SeekableIterator, \Serializable, \JsonSerializable
6		{
7		/**
8		*
9		* @var array
10		*/
11		protected $data = [];
12
13		/**
14		*
15		* @return int
16		*/
17		public function count(): int
18		{
19		return count($this->data);
20		}
21
22
23		/**
24		*
25		* @param int $key
26		* @return int
27		*/
28		public function seek($key)
29		{
30		if (!isset($this->data[$key])) {
31		throw new \OutOfBoundsException;
32		}
33
34		return $key;
		0 ignored issues – show Bug Best Practice introduced 2018-03-07 14:10 UTC by Report Bug Copy Issue Report The expression `return $key` returns the type `integer` which is incompatible with the return type mandated by `SeekableIterator::seek()` of `void`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
35		}
36
37		/**
38		*
39		* @return mixed
40		*/
41		public function current()
42		{
43		return current($this->data);
44		}
45
46		/**
47		*
48		* @return mixed
49		*/
50		public function next()
51		{
52		return next($this->data);
53		}
54
55		/**
56		*
57		* @return mixed
58		*/
59		public function key()
60		{
61		return key($this->data);
62		}
63
64		/**
65		*
66		* @return bool
67		*/
68		public function valid(): bool
69		{
70		return null !== key($this->data);
71		}
72
73		/**
74		*
75		* @return mixed
76		*/
77		public function rewind()
78		{
79		return reset($this->data);
80		}
81
82		/**
83		*
84		* @return string
85		*/
86		public function serialize(): string
87		{
88		return serialize($this->data);
89		}
90
91		/**
92		*
93		* @param string $serialized
94		*/
95		public function unserialize($serialized)
96		{
97		$this->data = unserialize($serialized);
98		}
99
100		/**
101		*
102		* @return array
103		*/
104		public function jsonSerialize(): array
105		{
106		return $this->data;
107		}
108
109		/**
110		*
111		* @return array
112		*/
113	17	public function __toArray(): array
114		{
115	17	return $this->data;
116		}
117		}
118

bricev / JobQueue

Push — v2 ( 9bff46...d4d6f5 )

Bag A

Complexity

Size/Duplication

Test Coverage

Importance

11 Methods

Duplication Side-by-Side

Filter issues like