Issues in MetaProvider.php (master) - Issues in master - brianium/paratest - Measure and Improve Code Quality continuously with Scrutinizer

Issues (76)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Logging/MetaProvider.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace ParaTest\Logging;

/**
 * Class MetaProvider.
 *
 * Adds __call behavior to a logging object
 * for aggregating totals and messages
 */
abstract class MetaProvider
{
    /**
     * This pattern is used to see whether a missing
     * method is a "total" method or not.
     *
     * @var string
     */
    protected static $totalMethod = '/^getTotal([\w]+)$/';

    /**
     * This pattern is used to add message retrieval for a given
     * type - i.e getFailures() or getErrors().
     *
     * @var string
     */
    protected static $messageMethod = '/^get((Failure|Error)s)$/';

    /**
     * Simplify aggregation of totals or messages.
     *
     * @param mixed $method
     * @param mixed $args
     */
    public function __call(string $method, array $args)
    {
        if (preg_match(self::$totalMethod, $method, $matches) && $property = strtolower($matches[1])) {
            return $this->getNumericValue($property);
        }
        if (preg_match(self::$messageMethod, $method, $matches) && $type = strtolower($matches[1])) {
            return $this->getMessages($type);
        }
    }

    /**
     * Return a value as a float or integer.
     *
     * @param $property
     *
     * @return float|int
     */
    protected function getNumericValue(string $property)
    {
        return ($property === 'time')
            ? (float) ($this->suites[0]->$property)
class MyClass { }

$x = new MyClass();
$x->foo = true;
            : (int) ($this->suites[0]->$property);
    }

    /**
     * Return messages for a given type.
     *
     * @param $type
     *
     * @return array
     */
    protected function getMessages(string $type): array
    {
        $messages = [];
        $suites = $this->isSingle ? $this->suites : $this->suites[0]->suites;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        foreach ($suites as $suite) {
            $messages = array_merge($messages, array_reduce($suite->cases, function ($result, $case) use ($type) {
                return array_merge($result, array_reduce($case->$type, function ($msgs, $msg) {
                    $msgs[] = $msg['text'];

                    return $msgs;
                }, []));
            }, []));
        }

        return $messages;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ParaTest\Logging;
6
7		/**
8		* Class MetaProvider.
9		*
10		* Adds __call behavior to a logging object
11		* for aggregating totals and messages
12		*/
13		abstract class MetaProvider
14		{
15		/**
16		* This pattern is used to see whether a missing
17		* method is a "total" method or not.
18		*
19		* @var string
20		*/
21		protected static $totalMethod = '/^getTotal([\w]+)$/';
22
23		/**
24		* This pattern is used to add message retrieval for a given
25		* type - i.e getFailures() or getErrors().
26		*
27		* @var string
28		*/
29		protected static $messageMethod = '/^get((Failure\|Error)s)$/';
30
31		/**
32		* Simplify aggregation of totals or messages.
33		*
34		* @param mixed $method
35		* @param mixed $args
36		*/
37	22	public function __call(string $method, array $args)
38		{
39	22	if (preg_match(self::$totalMethod, $method, $matches) && $property = strtolower($matches[1])) {
40	14	return $this->getNumericValue($property);
41		}
42	10	if (preg_match(self::$messageMethod, $method, $matches) && $type = strtolower($matches[1])) {
43	10	return $this->getMessages($type);
44		}
45		}
46
47		/**
48		* Return a value as a float or integer.
49		*
50		* @param $property
51		*
52		* @return float\|int
53		*/
54	14	protected function getNumericValue(string $property)
55		{
56	14	return ($property === 'time')
57	2	? (float) ($this->suites[0]->$property)
		0 ignored issues – show Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `suites` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
58	14	: (int) ($this->suites[0]->$property);
59		}
60
61		/**
62		* Return messages for a given type.
63		*
64		* @param $type
65		*
66		* @return array
67		*/
68	10	protected function getMessages(string $type): array
69		{
70	10	$messages = [];
71	10	$suites = $this->isSingle ? $this->suites : $this->suites[0]->suites;
		0 ignored issues – show Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `isSingle` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
72	10	foreach ($suites as $suite) {
73		$messages = array_merge($messages, array_reduce($suite->cases, function ($result, $case) use ($type) {
74	10	return array_merge($result, array_reduce($case->$type, function ($msgs, $msg) {
75	10	$msgs[] = $msg['text'];
76
77	10	return $msgs;
78	10	}, []));
79	10	}, []));
80		}
81
82	10	return $messages;
83		}
84		}
85

brianium / paratest

Issues (76)

Security Analysis no request data

src/Logging/MetaProvider.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like