Complex classes like ResultPrinter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ResultPrinter, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class ResultPrinter |
||
| 15 | { |
||
| 16 | /** |
||
| 17 | * A collection of ExecutableTest objects |
||
| 18 | * |
||
| 19 | * @var array |
||
| 20 | */ |
||
| 21 | protected $suites = array(); |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var \ParaTest\Logging\LogInterpreter |
||
| 25 | */ |
||
| 26 | protected $results; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * The number of tests results currently printed. |
||
| 30 | * Used to determine when to tally current results |
||
| 31 | * and start a new row |
||
| 32 | * |
||
| 33 | * @var int |
||
| 34 | */ |
||
| 35 | protected $numTestsWidth; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Used for formatting results to a given width |
||
| 39 | * |
||
| 40 | * @var int |
||
| 41 | */ |
||
| 42 | protected $maxColumn; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * The total number of cases to be run |
||
| 46 | * |
||
| 47 | * @var int |
||
| 48 | */ |
||
| 49 | protected $totalCases = 0; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * The current column being printed to |
||
| 53 | * |
||
| 54 | * @var int |
||
| 55 | */ |
||
| 56 | protected $column = 0; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @var \PHP_Timer |
||
| 60 | */ |
||
| 61 | protected $timer; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * The total number of cases printed so far |
||
| 65 | * |
||
| 66 | * @var int |
||
| 67 | */ |
||
| 68 | protected $casesProcessed = 0; |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Whether to display a red or green bar |
||
| 72 | * |
||
| 73 | * @var bool |
||
| 74 | */ |
||
| 75 | protected $colors; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Warnings generated by the cases |
||
| 79 | * |
||
| 80 | * @var array |
||
| 81 | */ |
||
| 82 | protected $warnings = array(); |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Number of columns |
||
| 86 | * |
||
| 87 | * @var integer |
||
| 88 | */ |
||
| 89 | protected $numberOfColumns = 80; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * Number of skipped or incomplete tests |
||
| 93 | * |
||
| 94 | * @var integer |
||
| 95 | */ |
||
| 96 | protected $totalSkippedOrIncomplete = 0; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * Do we need to try to process skipped/incompleted tests. |
||
| 100 | * |
||
| 101 | * @var boolean |
||
| 102 | */ |
||
| 103 | protected $processSkipped = false; |
||
| 104 | |||
| 105 | 28 | public function __construct(LogInterpreter $results) |
|
| 106 | { |
||
| 107 | 28 | $this->results = $results; |
|
| 108 | 28 | $this->timer = new \PHP_Timer(); |
|
| 109 | 28 | } |
|
| 110 | |||
| 111 | /** |
||
| 112 | * Adds an ExecutableTest to the tracked results |
||
| 113 | * |
||
| 114 | * @param ExecutableTest $suite |
||
| 115 | * @return $this |
||
| 116 | */ |
||
| 117 | 16 | public function addTest(ExecutableTest $suite) |
|
| 118 | { |
||
| 119 | 16 | $this->suites[] = $suite; |
|
| 120 | 16 | $increment = $suite->getTestCount(); |
|
| 121 | 16 | $this->totalCases = $this->totalCases + $increment; |
|
| 122 | |||
| 123 | 16 | return $this; |
|
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Initializes printing constraints, prints header |
||
| 128 | * information and starts the test timer |
||
| 129 | * |
||
| 130 | * @param Options $options |
||
| 131 | */ |
||
| 132 | 9 | public function start(Options $options) |
|
| 133 | { |
||
| 134 | 9 | $this->numTestsWidth = strlen((string) $this->totalCases); |
|
| 135 | 9 | $this->maxColumn = $this->numberOfColumns |
|
| 136 | 9 | + (DIRECTORY_SEPARATOR == "\\" ? -1 : 0) // fix windows blank lines |
|
| 137 | 9 | - strlen($this->getProgress()); |
|
| 138 | 9 | printf( |
|
| 139 | 9 | "\nRunning phpunit in %d process%s with %s%s\n\n", |
|
| 140 | 9 | $options->processes, |
|
| 141 | 9 | $options->processes > 1 ? 'es' : '', |
|
| 142 | 9 | $options->phpunit, |
|
| 143 | 9 | $options->functional ? '. Functional mode is ON.' : '' |
|
| 144 | 9 | ); |
|
| 145 | 9 | if (isset($options->filtered['configuration'])) { |
|
| 146 | 9 | printf("Configuration read from %s\n\n", $options->filtered['configuration']->getPath()); |
|
| 147 | 9 | } |
|
| 148 | 9 | $this->timer->start(); |
|
| 149 | 9 | $this->colors = $options->colors; |
|
| 150 | 9 | $this->processSkipped = $this->isSkippedIncompleTestCanBeTracked($options); |
|
| 151 | 9 | } |
|
| 152 | |||
| 153 | /** |
||
| 154 | * @param string $string |
||
| 155 | */ |
||
| 156 | 2 | public function println($string = "") |
|
| 157 | { |
||
| 158 | 2 | $this->column = 0; |
|
| 159 | 2 | print("$string\n"); |
|
| 160 | 2 | } |
|
| 161 | |||
| 162 | /** |
||
| 163 | * Prints all results and removes any log files |
||
| 164 | * used for aggregating results |
||
| 165 | */ |
||
| 166 | public function flush() |
||
| 167 | { |
||
| 168 | $this->printResults(); |
||
| 169 | $this->clearLogs(); |
||
| 170 | } |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Print final results |
||
| 174 | */ |
||
| 175 | 2 | public function printResults() |
|
| 176 | { |
||
| 177 | 2 | print $this->getHeader(); |
|
| 178 | 2 | print $this->getErrors(); |
|
| 179 | 2 | print $this->getFailures(); |
|
| 180 | 2 | print $this->getWarnings(); |
|
| 181 | 2 | print $this->getFooter(); |
|
| 182 | 2 | } |
|
| 183 | |||
| 184 | /** |
||
| 185 | * Prints the individual "quick" feedback for run |
||
| 186 | * tests, that is the ".EF" items |
||
| 187 | * |
||
| 188 | * @param ExecutableTest $test |
||
| 189 | */ |
||
| 190 | 12 | public function printFeedback(ExecutableTest $test) |
|
| 191 | { |
||
| 192 | try { |
||
| 193 | 12 | $reader = new Reader($test->getTempFile()); |
|
| 194 | 12 | } catch (\InvalidArgumentException $e) { |
|
| 195 | throw new \RuntimeException(sprintf( |
||
| 196 | "%s\n" . |
||
| 197 | "The process: %s\n" . |
||
| 198 | "This means a PHPUnit process was unable to run \"%s\"\n" , |
||
| 199 | $e->getmessage(), |
||
| 200 | $test->getLastCommand(), |
||
| 201 | $test->getPath() |
||
| 202 | )); |
||
| 203 | } |
||
| 204 | 12 | if (!$reader->hasResults()) { |
|
| 205 | 1 | throw new \RuntimeException(sprintf( |
|
| 206 | "The process: %s\nLog file \"%s\" is empty.\n" . |
||
| 207 | 1 | "This means a PHPUnit process was unable to run \"%s\"\n" . |
|
| 208 | 1 | "Maybe there is more than one class in this file.", |
|
| 209 | 1 | $test->getLastCommand(), |
|
| 210 | 1 | $test->getTempFile(), |
|
| 211 | 1 | $test->getPath() |
|
| 212 | 1 | )); |
|
| 213 | } |
||
| 214 | 11 | $this->results->addReader($reader); |
|
| 215 | 11 | $this->processReaderFeedback($reader, $test->getTestCount()); |
|
| 216 | 11 | $this->printTestWarnings($test); |
|
| 217 | 11 | } |
|
| 218 | |||
| 219 | /** |
||
| 220 | * Returns the header containing resource usage |
||
| 221 | * |
||
| 222 | * @return string |
||
| 223 | */ |
||
| 224 | 3 | public function getHeader() |
|
| 228 | |||
| 229 | /** |
||
| 230 | * Add an array of warning strings. These cause the test run to be shown |
||
| 231 | * as failed |
||
| 232 | */ |
||
| 233 | public function addWarnings(array $warnings) |
||
| 237 | |||
| 238 | /** |
||
| 239 | * Returns warning messages as a string |
||
| 240 | */ |
||
| 241 | 2 | public function getWarnings() |
|
| 245 | |||
| 246 | /** |
||
| 247 | * Whether the test run is successful and has no warnings |
||
| 248 | * |
||
| 249 | * @return bool |
||
| 250 | */ |
||
| 251 | 4 | public function isSuccessful() |
|
| 255 | |||
| 256 | /** |
||
| 257 | * Return the footer information reporting success |
||
| 258 | * or failure |
||
| 259 | * |
||
| 260 | * @return string |
||
| 261 | */ |
||
| 262 | 4 | public function getFooter() |
|
| 263 | { |
||
| 264 | 4 | return $this->isSuccessful() |
|
| 265 | 4 | ? $this->getSuccessFooter() |
|
| 266 | 4 | : $this->getFailedFooter(); |
|
| 267 | } |
||
| 268 | |||
| 269 | /** |
||
| 270 | * Returns the failure messages |
||
| 271 | * |
||
| 272 | * @return string |
||
| 273 | */ |
||
| 274 | 3 | public function getFailures() |
|
| 275 | { |
||
| 276 | 3 | $failures = $this->results->getFailures(); |
|
|
|
|||
| 277 | |||
| 278 | 3 | return $this->getDefects($failures, 'failure'); |
|
| 279 | } |
||
| 280 | |||
| 281 | /** |
||
| 282 | * Returns error messages |
||
| 283 | * |
||
| 284 | * @return string |
||
| 285 | */ |
||
| 286 | 4 | public function getErrors() |
|
| 287 | { |
||
| 288 | 4 | $errors = $this->results->getErrors(); |
|
| 289 | |||
| 290 | 4 | return $this->getDefects($errors, 'error'); |
|
| 291 | } |
||
| 292 | |||
| 293 | /** |
||
| 294 | * Returns the total cases being printed |
||
| 295 | * |
||
| 296 | * @return int |
||
| 297 | */ |
||
| 298 | 2 | public function getTotalCases() |
|
| 302 | |||
| 303 | /** |
||
| 304 | * Process reader feedback and print it. |
||
| 305 | * |
||
| 306 | * @param Reader $reader |
||
| 307 | * @param int $expectedTestCount |
||
| 308 | */ |
||
| 309 | 11 | protected function processReaderFeedback($reader, $expectedTestCount) |
|
| 310 | { |
||
| 311 | 11 | $feedbackItems = $reader->getFeedback(); |
|
| 312 | |||
| 325 | |||
| 326 | /** |
||
| 327 | * Prints test warnings. |
||
| 328 | * |
||
| 329 | * @param ExecutableTest $test |
||
| 330 | */ |
||
| 331 | 11 | protected function printTestWarnings($test) |
|
| 341 | |||
| 342 | /** |
||
| 343 | * Is skipped/incomplete amount can be properly processed. |
||
| 344 | * |
||
| 345 | * @todo Skipped/Incomplete test tracking available only in functional mode for now |
||
| 346 | * or in regular mode but without group/exclude-group filters. |
||
| 347 | * |
||
| 348 | * @return boolean |
||
| 349 | */ |
||
| 350 | 9 | protected function isSkippedIncompleTestCanBeTracked($options) |
|
| 355 | |||
| 356 | /** |
||
| 357 | * Process test overhead. |
||
| 358 | * |
||
| 359 | * In some situations phpunit can return more tests then we expect and in that case |
||
| 360 | * this method correct total amount of tests so paratest progress will be auto corrected. |
||
| 361 | * |
||
| 362 | * @todo May be we need to throw Exception here instead of silent correction. |
||
| 363 | * |
||
| 364 | * @param int $actualTestCount |
||
| 365 | * @param int $expectedTestCount |
||
| 366 | */ |
||
| 367 | 11 | protected function processTestOverhead($actualTestCount, $expectedTestCount) |
|
| 380 | |||
| 381 | /** |
||
| 382 | * Prints S for skipped and incomplete tests. |
||
| 383 | * |
||
| 384 | * If for some reason process return less tests than expected then we threat all remaining |
||
| 385 | * as skipped or incomplete and print them as skipped (S letter) |
||
| 386 | * |
||
| 387 | * @param int $actualTestCount |
||
| 388 | * @param int $expectedTestCount |
||
| 389 | */ |
||
| 390 | 4 | protected function printSkippedAndIncomplete($actualTestCount, $expectedTestCount) |
|
| 399 | |||
| 400 | /** |
||
| 401 | * Prints a single "quick" feedback item and increments |
||
| 402 | * the total number of processed cases and the column |
||
| 403 | * position |
||
| 404 | * |
||
| 405 | * @param $item |
||
| 406 | */ |
||
| 407 | 11 | protected function printFeedbackItem($item) |
|
| 417 | |||
| 418 | /** |
||
| 419 | * Method that returns a formatted string |
||
| 420 | * for a collection of errors or failures |
||
| 421 | * |
||
| 422 | * @param array $defects |
||
| 423 | * @param $type |
||
| 424 | * @return string |
||
| 425 | */ |
||
| 426 | 5 | protected function getDefects(array $defects, $type) |
|
| 446 | |||
| 447 | /** |
||
| 448 | * Prints progress for large test collections |
||
| 449 | */ |
||
| 450 | 9 | protected function getProgress() |
|
| 459 | |||
| 460 | /** |
||
| 461 | * Get the footer for a test collection that had tests with |
||
| 462 | * failures or errors |
||
| 463 | * |
||
| 464 | * @return string |
||
| 465 | */ |
||
| 466 | 3 | private function getFailedFooter() |
|
| 467 | { |
||
| 468 | 3 | $formatString = "FAILURES!\nTests: %d, Assertions: %d, Failures: %d, Errors: %d.\n"; |
|
| 469 | |||
| 470 | 3 | return "\n" . $this->red( |
|
| 471 | 3 | sprintf( |
|
| 472 | 3 | $formatString, |
|
| 473 | 3 | $this->results->getTotalTests(), |
|
| 474 | 3 | $this->results->getTotalAssertions(), |
|
| 475 | 3 | $this->results->getTotalFailures(), |
|
| 476 | 3 | $this->results->getTotalErrors() |
|
| 477 | 3 | ) |
|
| 478 | 3 | ); |
|
| 479 | } |
||
| 480 | |||
| 481 | /** |
||
| 482 | * Get the footer for a test collection containing all successful |
||
| 483 | * tests |
||
| 484 | * |
||
| 485 | * @return string |
||
| 486 | */ |
||
| 487 | 1 | private function getSuccessFooter() |
|
| 514 | |||
| 515 | 1 | private function green($text) |
|
| 524 | |||
| 525 | 3 | private function red($text) |
|
| 526 | { |
||
| 527 | 3 | if ($this->colors) { |
|
| 528 | return "\x1b[37;41m\x1b[2K" |
||
| 529 | . $text |
||
| 530 | . "\x1b[0m\x1b[2K"; |
||
| 531 | } |
||
| 532 | 3 | return $text; |
|
| 533 | } |
||
| 534 | |||
| 535 | /** |
||
| 536 | * Deletes all the temporary log files for ExecutableTest objects |
||
| 537 | * being printed |
||
| 538 | */ |
||
| 539 | private function clearLogs() |
||
| 545 | } |
||
| 546 |
If you implement
__calland you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class.This is often the case, when
__callis implemented by a parent class and only the child class knows which methods exist: