WrapperRunner - Code Metrics - Inspection of "Attempt at fixing failed build on Travis CI" - brianium/paratest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#204)

unknown

created 2016-05-08 15:16 UTC

WrapperRunner A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	193
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

Importance

Changes	5
Bugs	1	Features	1

Metric	Value
wmc	32
lcom	1
cbo	6
dl	0
loc	193
ccs	0
cts	116
cp	0
rs	9.6
c	5
b	1
f	1

12 Methods

Rating	Name	Size	Complexity
A	waitForAllToFinish()	14	4
A	progressedWorkers()	16	4
A	run()	10	1
A	load()	7	2
A	startWorkers()	17	3
B	assignAllPendingTests()	18	5
A	sendStopMessages()	6	2
A	waitForStreamsToChange()	11	2
A	streamsOf()	8	2
A	complete()	12	2
A	setExitCode()	10	3
A	flushWorker()	8	2

<?php
namespace ParaTest\Runners\PHPUnit;

class WrapperRunner extends BaseRunner
{
    const PHPUNIT_FAILURES = 1;
    const PHPUNIT_ERRORS = 2;

    /**
     * @var array
     */
    protected $streams;

    /**
     * @var Worker[]
     */
    protected $workers;

    /**
     * @var array
     */
    protected $modified;


    public function run()
    {
        parent::run();

        $this->startWorkers();
        $this->assignAllPendingTests();
        $this->sendStopMessages();
        $this->waitForAllToFinish();
        $this->complete();
    }

    protected function load()
    {
        if ($this->options->functional) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            throw new \RuntimeException("The `functional` option is not supported yet in the WrapperRunner. Only full classes can be run due to the current PHPUnit commands causing classloading issues.");
        }
        parent::load();
    }

    private function startWorkers()
    {
        $wrapper = realpath(__DIR__ . '/../../../../bin/phpunit-wrapper');
        for ($i = 1; $i <= $this->options->processes; $i++) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $worker = new Worker();
            if ($this->options->noTestTokens) {
                $token = null;
                $uniqueToken = null;
            } else {
                $token = $i;
                $uniqueToken = uniqid();
            }
            $worker->start($wrapper, $token, $uniqueToken);
            $this->streams[] = $worker->stdout();
            $this->workers[] = $worker;
        }
    }

    private function assignAllPendingTests()
    {
        $phpunit = $this->options->phpunit;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $phpunitOptions = $this->options->filtered;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $phpunitOptions['no-globals-backup'] = null;
        while (count($this->pending)) {
            $this->waitForStreamsToChange($this->streams);
            foreach ($this->progressedWorkers() as $worker) {
                if ($worker->isFree()) {
                    $this->flushWorker($worker);
                    $pending = array_shift($this->pending);
                    if ($pending) {
                        $worker->assign($pending, $phpunit, $phpunitOptions);
                    }
                }
            }
        }
    }

    private function sendStopMessages()
    {
        foreach ($this->workers as $worker) {
            $worker->stop();
        }
    }

    private function waitForAllToFinish()
    {
        $toStop = $this->workers;
        while (count($toStop) > 0) {
            $toCheck = $this->streamsOf($toStop);
            $new = $this->waitForStreamsToChange($toCheck);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            foreach ($this->progressedWorkers() as $index => $worker) {
                if (!$worker->isRunning()) {
                    $this->flushWorker($worker);
                    unset($toStop[$index]);
                }
            }
        }
    }

    // put on WorkersPool
    private function waitForStreamsToChange($modified)
    {
        $write = array();
        $except = array();
        $result = stream_select($modified, $write, $except, 1);
        if ($result === false) {
            throw new \RuntimeException("stream_select() returned an error while waiting for all workers to finish.");
        }
        $this->modified = $modified;
        return $result;
    }

    /**
     * put on WorkersPool
     * @return Worker[]
     */
    private function progressedWorkers()
    {
        $result = array();
        foreach ($this->modified as $modifiedStream) {
            $found = null;
            foreach ($this->streams as $index => $stream) {
                if ($modifiedStream == $stream) {
                    $found = $index;
                    break;
                }
            }
            $result[$found] = $this->workers[$found];
        }
        $this->modified = array();
        return $result;
    }

    /**
     * Returns the output streams of a subset of workers.
     * @param array    keys are positions in $this->workers
     * @return array
     */
    private function streamsOf($workers)
    {
        $streams = array();
        foreach (array_keys($workers) as $index) {
            $streams[$index] = $this->streams[$index];
        }
        return $streams;
    }

    private function complete()
    {
        $this->setExitCode();
        $this->printer->printResults();
        $this->interpreter->rewind();
        $this->log();
        $this->logCoverage();
        $readers = $this->interpreter->getReaders();
        foreach ($readers as $reader) {
            $reader->removeLog();
        }
    }


    private function setExitCode()
    {
        if ($this->interpreter->getTotalErrors()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $this->exitcode = self::PHPUNIT_ERRORS;
        } elseif ($this->interpreter->getTotalFailures()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $this->exitcode = self::PHPUNIT_FAILURES;
        } else {
            $this->exitcode = 0;
        }
    }

    private function flushWorker($worker)
    {
        if ($this->hasCoverage()) {
            $this->addCoverageFromFile($worker->getCoverageFileName());
        }
        $worker->printFeedback($this->printer);
        $worker->reset();
    }

  /**
    private function testIsStillRunning($test)
    {
        if(!$test->isDoneRunning()) return true;
        $this->setExitCode($test);
        $test->stop();
        if (static::PHPUNIT_FATAL_ERROR === $test->getExitCode())
            throw new \Exception($test->getStderr(), $test->getExitCode());
        return false;
    }
     */
}


1			<?php
2			namespace ParaTest\Runners\PHPUnit;
3
4			class WrapperRunner extends BaseRunner
5			{
6			const PHPUNIT_FAILURES = 1;
7			const PHPUNIT_ERRORS = 2;
8
9			/**
10			* @var array
11			*/
12			protected $streams;
13
14			/**
15			* @var Worker[]
16			*/
17			protected $workers;
18
19			/**
20			* @var array
21			*/
22			protected $modified;
23
24
25			public function run()
26			{
27			parent::run();
28
29			$this->startWorkers();
30			$this->assignAllPendingTests();
31			$this->sendStopMessages();
32			$this->waitForAllToFinish();
33			$this->complete();
34			}
35
36			protected function load()
37			{
38			if ($this->options->functional) {
			0 ignored issues – show Documentation introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report The property `$functional` is declared protected in `ParaTest\Runners\PHPUnit\Options`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39			throw new \RuntimeException("The `functional` option is not supported yet in the WrapperRunner. Only full classes can be run due to the current PHPUnit commands causing classloading issues.");
40			}
41			parent::load();
42			}
43
44			private function startWorkers()
45			{
46			$wrapper = realpath(__DIR__ . '/../../../../bin/phpunit-wrapper');
47			for ($i = 1; $i <= $this->options->processes; $i++) {
			0 ignored issues – show Documentation introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report The property `$processes` is declared protected in `ParaTest\Runners\PHPUnit\Options`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
48			$worker = new Worker();
49			if ($this->options->noTestTokens) {
50			$token = null;
51			$uniqueToken = null;
52			} else {
53			$token = $i;
54			$uniqueToken = uniqid();
55			}
56			$worker->start($wrapper, $token, $uniqueToken);
57			$this->streams[] = $worker->stdout();
58			$this->workers[] = $worker;
59			}
60			}
61
62			private function assignAllPendingTests()
63			{
64			$phpunit = $this->options->phpunit;
			0 ignored issues – show Documentation introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report The property `$phpunit` is declared protected in `ParaTest\Runners\PHPUnit\Options`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
65			$phpunitOptions = $this->options->filtered;
			0 ignored issues – show Documentation introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report The property `$filtered` is declared protected in `ParaTest\Runners\PHPUnit\Options`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
66			$phpunitOptions['no-globals-backup'] = null;
67			while (count($this->pending)) {
68			$this->waitForStreamsToChange($this->streams);
69			foreach ($this->progressedWorkers() as $worker) {
70			if ($worker->isFree()) {
71			$this->flushWorker($worker);
72			$pending = array_shift($this->pending);
73			if ($pending) {
74			$worker->assign($pending, $phpunit, $phpunitOptions);
75			}
76			}
77			}
78			}
79			}
80
81			private function sendStopMessages()
82			{
83			foreach ($this->workers as $worker) {
84			$worker->stop();
85			}
86			}
87
88			private function waitForAllToFinish()
89			{
90			$toStop = $this->workers;
91			while (count($toStop) > 0) {
92			$toCheck = $this->streamsOf($toStop);
93			$new = $this->waitForStreamsToChange($toCheck);
			0 ignored issues – show Unused Code introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report `$new` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
94			foreach ($this->progressedWorkers() as $index => $worker) {
95			if (!$worker->isRunning()) {
96			$this->flushWorker($worker);
97			unset($toStop[$index]);
98			}
99			}
100			}
101			}
102
103			// put on WorkersPool
104			private function waitForStreamsToChange($modified)
105			{
106			$write = array();
107			$except = array();
108			$result = stream_select($modified, $write, $except, 1);
109			if ($result === false) {
110			throw new \RuntimeException("stream_select() returned an error while waiting for all workers to finish.");
111			}
112			$this->modified = $modified;
113			return $result;
114			}
115
116			/**
117			* put on WorkersPool
118			* @return Worker[]
119			*/
120			private function progressedWorkers()
121			{
122			$result = array();
123			foreach ($this->modified as $modifiedStream) {
124			$found = null;
125			foreach ($this->streams as $index => $stream) {
126			if ($modifiedStream == $stream) {
127			$found = $index;
128			break;
129			}
130			}
131			$result[$found] = $this->workers[$found];
132			}
133			$this->modified = array();
134			return $result;
135			}
136
137			/**
138			* Returns the output streams of a subset of workers.
139			* @param array keys are positions in $this->workers
140			* @return array
141			*/
142			private function streamsOf($workers)
143			{
144			$streams = array();
145			foreach (array_keys($workers) as $index) {
146			$streams[$index] = $this->streams[$index];
147			}
148			return $streams;
149			}
150
151			private function complete()
152			{
153			$this->setExitCode();
154			$this->printer->printResults();
155			$this->interpreter->rewind();
156			$this->log();
157			$this->logCoverage();
158			$readers = $this->interpreter->getReaders();
159			foreach ($readers as $reader) {
160			$reader->removeLog();
161			}
162			}
163
164
165			private function setExitCode()
166			{
167			if ($this->interpreter->getTotalErrors()) {
			0 ignored issues – show Documentation Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report The method `getTotalErrors` does not exist on `object<ParaTest\Logging\LogInterpreter>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
168			$this->exitcode = self::PHPUNIT_ERRORS;
169			} elseif ($this->interpreter->getTotalFailures()) {
			0 ignored issues – show Documentation Bug introduced 2015-12-02 18:19 UTC by Report Bug Copy Issue Report The method `getTotalFailures` does not exist on `object<ParaTest\Logging\LogInterpreter>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
170			$this->exitcode = self::PHPUNIT_FAILURES;
171			} else {
172			$this->exitcode = 0;
173			}
174			}
175
176			private function flushWorker($worker)
177			{
178			if ($this->hasCoverage()) {
179			$this->addCoverageFromFile($worker->getCoverageFileName());
180			}
181			$worker->printFeedback($this->printer);
182			$worker->reset();
183			}
184
185			/**
186			private function testIsStillRunning($test)
187			{
188			if(!$test->isDoneRunning()) return true;
189			$this->setExitCode($test);
190			$test->stop();
191			if (static::PHPUNIT_FATAL_ERROR === $test->getExitCode())
192			throw new \Exception($test->getStderr(), $test->getExitCode());
193			return false;
194			}
195			*/
196			}
197

brianium / paratest

Pull Request — master (#204)

WrapperRunner A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

12 Methods

Duplication Side-by-Side

Filter issues like