TenantService::delete() - Code Metrics - brezzhnev/atlassian-connect-core - Measure and Improve Code Quality continuously with Scrutinizer

TenantService::delete() A
last analyzed 2017-09-06 08:50 UTC

↳ Parent: TenantService

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0

<?php

namespace AtlassianConnectCore\Services;

use AtlassianConnectCore\Models\Tenant;
use AtlassianConnectCore\Repositories\TenantRepository;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
 * Class TenantService
 *
 * @package AtlassianConnectCore\Services
 */
class TenantService
{
    /**
     * @var TenantRepository
     */
    protected $repository;

    /**
     * TenantService constructor.
     *
     * @param TenantRepository $tenantRepository
     */
    public function __construct(TenantRepository $tenantRepository)
    {
        $this->repository = $tenantRepository;
    }

    /**
     * Create or update a tenant
     *
     * @param bool $withTrashed
     *
     * @return \Illuminate\Database\Eloquent\Collection|Tenant[]
     */
    public function all($withTrashed = false)
    {
        return $this->repository->findAll($withTrashed);

    }

    /**
     * Create or update a tenant
     *
     * @param array $attributes
     *
     * @return Tenant
     */
    public function createOrUpdate(array $attributes)
    {
        /** @var Tenant|null $model */
        $model = $this->repository
            ->findWhere(['client_key' => $attributes['client_key']])
            ->first();

        if(!$model) {
            return $this->repository->create($attributes);
        }

        return $this->repository->update($model->id, $attributes);
    }

    /**
     * Update state
     *
     * @param string $clientKey
     * @param string $eventType
     *
     * @return Tenant
     */
    public function updateState($clientKey, $eventType)
    {
        return $this->repository->updateWhere(['client_key' => $clientKey], ['event_type' => $eventType]);
    }

    /**
     * Find a tenant by client key
     *
     * @param string $clientKey
     * @param bool $withTrashed
     *
     * @return Tenant|null
     */
    public function findByClientKey($clientKey, $withTrashed = true)
    {
        return $this->repository
            ->findWhere(['client_key' => $clientKey], $withTrashed)
            ->first();
    }

    /**
     * Find a tenant by client key
     *
     * @param string $clientKey
     * @param bool $withTrashed
     *
     * @return Tenant
     *
     * @throws NotFoundHttpException
     */
    public function findByClientKeyOrFail($clientKey, $withTrashed = true)
    {
        if($tenant = $this->findByClientKey($clientKey, $withTrashed)) {
            return $tenant;
        }

        throw new NotFoundHttpException();
    }

    /**
     * Find not-dummied tenants
     *
     * @return \Illuminate\Database\Eloquent\Collection|Tenant[]
     */
    public function findReals()
    {
        return $this->repository->findWhere(['is_dummy' => false], false);

    }

    /**
     * Delete the tenant
     *
     * @param int $id
     *
     * @return mixed
     */
    public function delete($id)
    {
        if(config('plugin.safeDelete')) {
            return $this->repository->delete($id);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        return $this->repository->forceDelete($id);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * Get dummy tenant
     *
     * @return Tenant|null
     */
    public function dummy()
    {
        return $this->repository->findDummy();
    }

    /**
     * Make tenant dummied
     *
     * @param int $id Tenant ID
     *
     * @return Tenant|null
     */
    public function makeDummy($id)
    {
        if(!$this->repository->findById($id)) {
            throw new NotFoundHttpException();
        }

        return $this->repository->updateWhere(['id' => $id], ['is_dummy' => true]);
    }
}

1			<?php
2
3			namespace AtlassianConnectCore\Services;
4
5			use AtlassianConnectCore\Models\Tenant;
6			use AtlassianConnectCore\Repositories\TenantRepository;
7			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
8
9			/**
10			* Class TenantService
11			*
12			* @package AtlassianConnectCore\Services
13			*/
14			class TenantService
15			{
16			/**
17			* @var TenantRepository
18			*/
19			protected $repository;
20
21			/**
22			* TenantService constructor.
23			*
24			* @param TenantRepository $tenantRepository
25			*/
26			public function __construct(TenantRepository $tenantRepository)
27			{
28			$this->repository = $tenantRepository;
29			}
30
31			/**
32			* Create or update a tenant
33			*
34			* @param bool $withTrashed
35			*
36			* @return \Illuminate\Database\Eloquent\Collection\|Tenant[]
37			*/
38			public function all($withTrashed = false)
39			{
40			return $this->repository->findAll($withTrashed);
			0 ignored issues – show Bug Best Practice introduced 2017-09-04 12:46 UTC by Report Bug Copy Issue Report The expression `return $this->repository->findAll($withTrashed)` returns the type `Illuminate\Database\Eloquent\Collection` which is incompatible with the documented return type `AtlassianConnectCore\Mod...ase\Eloquent\Collection`. Loading history...
41			}
42
43			/**
44			* Create or update a tenant
45			*
46			* @param array $attributes
47			*
48			* @return Tenant
49			*/
50			public function createOrUpdate(array $attributes)
51			{
52			/** @var Tenant\|null $model */
53			$model = $this->repository
54			->findWhere(['client_key' => $attributes['client_key']])
55			->first();
56
57			if(!$model) {
58			return $this->repository->create($attributes);
59			}
60
61			return $this->repository->update($model->id, $attributes);
62			}
63
64			/**
65			* Update state
66			*
67			* @param string $clientKey
68			* @param string $eventType
69			*
70			* @return Tenant
71			*/
72			public function updateState($clientKey, $eventType)
73			{
74			return $this->repository->updateWhere(['client_key' => $clientKey], ['event_type' => $eventType]);
75			}
76
77			/**
78			* Find a tenant by client key
79			*
80			* @param string $clientKey
81			* @param bool $withTrashed
82			*
83			* @return Tenant\|null
84			*/
85			public function findByClientKey($clientKey, $withTrashed = true)
86			{
87			return $this->repository
88			->findWhere(['client_key' => $clientKey], $withTrashed)
89			->first();
90			}
91
92			/**
93			* Find a tenant by client key
94			*
95			* @param string $clientKey
96			* @param bool $withTrashed
97			*
98			* @return Tenant
99			*
100			* @throws NotFoundHttpException
101			*/
102			public function findByClientKeyOrFail($clientKey, $withTrashed = true)
103			{
104			if($tenant = $this->findByClientKey($clientKey, $withTrashed)) {
105			return $tenant;
106			}
107
108			throw new NotFoundHttpException();
109			}
110
111			/**
112			* Find not-dummied tenants
113			*
114			* @return \Illuminate\Database\Eloquent\Collection\|Tenant[]
115			*/
116			public function findReals()
117			{
118			return $this->repository->findWhere(['is_dummy' => false], false);
			0 ignored issues – show Bug Best Practice introduced 2017-09-04 12:46 UTC by Report Bug Copy Issue Report The expression `return $this->repository...ummy' => false), false)` returns the type `Illuminate\Database\Eloquent\Collection` which is incompatible with the documented return type `AtlassianConnectCore\Mod...ase\Eloquent\Collection`. Loading history...
119			}
120
121			/**
122			* Delete the tenant
123			*
124			* @param int $id
125			*
126			* @return mixed
127			*/
128			public function delete($id)
129			{
130			if(config('plugin.safeDelete')) {
131			return $this->repository->delete($id);
			0 ignored issues – show Bug introduced 2017-09-04 12:46 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->repository->delete($id)` targeting `AtlassianConnectCore\Rep...antRepository::delete()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
132			}
133
134			return $this->repository->forceDelete($id);
			0 ignored issues – show Bug introduced 2017-09-04 12:46 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->repository->forceDelete($id)` targeting `AtlassianConnectCore\Rep...pository::forceDelete()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
135			}
136
137			/**
138			* Get dummy tenant
139			*
140			* @return Tenant\|null
141			*/
142			public function dummy()
143			{
144			return $this->repository->findDummy();
145			}
146
147			/**
148			* Make tenant dummied
149			*
150			* @param int $id Tenant ID
151			*
152			* @return Tenant\|null
153			*/
154			public function makeDummy($id)
155			{
156			if(!$this->repository->findById($id)) {
157			throw new NotFoundHttpException();
158			}
159
160			return $this->repository->updateWhere(['id' => $id], ['is_dummy' => true]);
161			}
162			}

brezzhnev / atlassian-connect-core

TenantService::delete() A last analyzed 2017-09-06 08:50 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TenantService::delete() A
last analyzed 2017-09-06 08:50 UTC