AtlassianConnectCore\Console\DummyCommand

Complexity

Total Complexity

4

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	handle()	0	27	2
A	formatTenants()	0	10	1
A	__construct()	0	5	1

<?php

namespace AtlassianConnectCore\Console;

use AtlassianConnectCore\Models\Tenant;
use AtlassianConnectCore\Services\TenantService;
use Illuminate\Console\Command;
use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;

/**
 * Class DummyCommand
 *
 * @package AtlassianConnectCore\Console
 */
class DummyCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'plugin:dummy';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Make your tenant dummy';

    /**
     * @var TenantService
     */
    protected $tenantService;

    /**
     * InstallCommand constructor.
     *
     * @param TenantService $tenantService
     */
    public function __construct(TenantService $tenantService)
    {
        parent::__construct();

        $this->tenantService = $tenantService;
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $tenants = $this->tenantService->findReals();

        $this->table(
            ['ID', 'Client Key (last 22 chars)', 'Product', 'Status', 'Created At'],
            $this->formatTenants($tenants, [

$tenants of type Illuminate\Database\Eloquent\Collection is incompatible with the type AtlassianConnectCore\Models\Tenant[]&Illuminate\Database\Eloquent\Collection expected by parameter $tenants of AtlassianConnectCore\Console\DummyCommand::formatTenants().

                'id', 'client_key', 'product_type', 'event_type', 'created_at'
            ])
        );

        // Make the list of choices
        $choices = $tenants
            ->pluck('id')
            ->toArray();

        $id = $this->ask('Which the tenant should be dummy? (Pass ID)');

        $validator = Validator::make(['value' => $id], ['value' => Rule::in($choices)]);

        if($validator->fails()) {
            return $this->error('Invalid ID provided');

Are you sure the usage of $this->error('Invalid ID provided') targeting Illuminate\Console\Command::error() seems to always return null.

        }

        $this->tenantService->makeDummy($id);

$id of type string is incompatible with the type integer expected by parameter $id of AtlassianConnectCore\Services\TenantService::makeDummy().

        $this->comment('Tenant <info>' . $id . '</info> has been set as dummy');
    }

    /**
     * Format given tenants to columns with specific attributes
     *
     * @param \Illuminate\Database\Eloquent\Collection|Tenant[] $tenants
     * @param array $attributes Attributes need to be returned
     *
     * @return array
     */
    protected function formatTenants($tenants, array $attributes)
    {
        $tenants = collect($tenants->toArray());

        return $tenants->map(function ($tenant) use ($attributes) {

The expression return $tenants->map(function(...) { /* ... */ }) returns the type Illuminate\Support\Collection which is incompatible with the documented return type array.

            // Make the client key shorter for displaying
            $tenant['client_key'] = substr($tenant['client_key'], -22);

            return array_only($tenant, $attributes);
        });
    }
}