ImportSitemapCommand::execute() - Code Metrics - Inspection of "Feat/import sitemap command" - brevia-ai/brevia-bedita - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#14)

by Stefano

created 2024-05-07 15:24 UTC

ImportSitemapCommand::execute() B

↳ Parent: ImportSitemapCommand

Complexity

Conditions	8
Paths	24

Size

Total Lines	61
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
cc	8
eloc	43
c	3
b	1
f	0
nc	24
nop	2
dl	0
loc	61
rs	7.9875

How to fix Long Method

<?php
declare(strict_types=1);

/**
 * BEdita Brevia plugin
 *
 * Copyright 2024 Atlas Srl
 */
namespace Brevia\BEdita\Command;

use BEdita\Core\Utility\LoggedUser;
use Brevia\BEdita\Client\BreviaClient;
use Brevia\BEdita\Utility\ReadCSVTrait;
use Cake\Command\Command;
use Cake\Console\Arguments;
use Cake\Console\ConsoleIo;
use Cake\Console\ConsoleOptionParser;
use Cake\Log\LogTrait;
use Cake\Utility\Hash;

/**
 * Import links from sitemap and create links
 *
 * @property \BEdita\Core\Model\Table\ObjectsTable $Collections
 */
class ImportSitemapCommand extends Command
{
    use LogTrait;
    use ReadCSVTrait;

    /**
     * Brevia API client
     *
     * @var \Brevia\BEdita\Client\BreviaClient
     */
    protected BreviaClient $client;

    /**
     * @inheritDoc
     */
    public $defaultTable = 'Collections';

    /**
     * @inheritDoc
     */
    protected function buildOptionParser(ConsoleOptionParser $parser): ConsoleOptionParser
    {
        return $parser->addOption('sitemap', [
                'help' => 'File path or URL of sitemap to import',
                'short' => 's',
                'required' => true,
            ])
            ->addOption('prefix', [
                'help' => 'Optional path prefix of URLs to import',
                'short' => 'p',
                'required' => false,
            ])
            ->addOption('collection', [
                'help' => 'Collection used to index (use the unique collection name)',
                'short' => 'c',
                'required' => true,
            ]);
    }

    /**
     * @inheritDoc
     */
    public function initialize(): void
    {
        $this->client = new BreviaClient();
    }

    /**
     * @inheritDoc
     */
    public function execute(Arguments $args, ConsoleIo $io)
    {
        $sitemap = $args->getOption('sitemap');
        $content = file_get_contents($sitemap);
        if (!$content) {
            $io->abort(sprintf('Sitemap content not found: %s', $sitemap));
        }

        $name = $args->getOption('collection');
        $response = $this->client->get('/collections', compact('name'));
        $collectionId = Hash::get($response->getJson(), '0.cmetadata.id');
        if (empty($collectionId)) {
            $io->abort(sprintf('Collection not found: %s', $name));
        }
        $collection = $this->Collections->get($collectionId, ['contain' => ['HasDocuments']]);
        $currentUrls = array_filter(array_map(function ($link) {
                $link = $link->getTable()->get($link->id);

                return $link->get('url');
        },
            $collection->has_documents));
        $prefix = $args->getOption('prefix');

        $xml = simplexml_load_string($content);
        $json = json_encode($xml);
        $data = (array)json_decode($json, true);
        $urls = Hash::extract($data, 'url.{n}.loc');
        if (empty($urls)) {
            $io->abort('No URLs found in sitemap');
        }
        $entities = [];
        LoggedUser::setUserAdmin();
        $this->Links = $this->fetchTable('Links');
        foreach ($urls as $url) {
            if (in_array($url, $currentUrls) || ($prefix && strpos($url, $prefix) !== 0)) {
                continue;
            }
            $io->info('Adding link: ' . $url);
            $data = [
                'status' => 'on',
                'title' => $url,
                'url' => $url,
                'extra' => [
                    'brevia' => [
                        'metadata' => [
                            'type' => 'links',
                            'url' => $url,
                        ],
                        'options' => $this->linkOptions($url, (array)$collection->get('link_load_options')),
                    ],
                ],
            ];
            $entity = $this->Links->newEntity($data);
            $entities[] = $this->Links->saveOrFail($entity);
        }
        /** @phpstan-ignore-next-line */
        $this->Collections->addRelated($collection, 'has_documents', $entities);

        $io->out('Done. Link added successfully: ' . count($entities));

        return null;
    }

    /**
     * Get link options
     *
     * @param string $url URL
     * @param array $linkLoadOptions Link load options
     * @return array
     */
    protected function linkOptions(string $url, array $linkLoadOptions): array
    {
        $options = array_filter($linkLoadOptions, function ($o) use ($url) {
            return $o['url'] === $url;
        });
        $selector = Hash::get($options, '0.selector');
        if (!empty($selector)) {
            return compact('selector');
        }
        $options = array_filter($linkLoadOptions, function ($o) use ($url) {
            return strpos($url, $o['url']) === 0;
        });

        return ['selector' => Hash::get($options, '0.selector')];
    }
}


1			<?php
2			declare(strict_types=1);
3
4			/**
5			* BEdita Brevia plugin
6			*
7			* Copyright 2024 Atlas Srl
8			*/
9			namespace Brevia\BEdita\Command;
10
11			use BEdita\Core\Utility\LoggedUser;
12			use Brevia\BEdita\Client\BreviaClient;
13			use Brevia\BEdita\Utility\ReadCSVTrait;
14			use Cake\Command\Command;
15			use Cake\Console\Arguments;
16			use Cake\Console\ConsoleIo;
17			use Cake\Console\ConsoleOptionParser;
18			use Cake\Log\LogTrait;
19			use Cake\Utility\Hash;
20
21			/**
22			* Import links from sitemap and create links
23			*
24			* @property \BEdita\Core\Model\Table\ObjectsTable $Collections
25			*/
26			class ImportSitemapCommand extends Command
27			{
28			use LogTrait;
29			use ReadCSVTrait;
30
31			/**
32			* Brevia API client
33			*
34			* @var \Brevia\BEdita\Client\BreviaClient
35			*/
36			protected BreviaClient $client;
37
38			/**
39			* @inheritDoc
40			*/
41			public $defaultTable = 'Collections';
42
43			/**
44			* @inheritDoc
45			*/
46			protected function buildOptionParser(ConsoleOptionParser $parser): ConsoleOptionParser
47			{
48			return $parser->addOption('sitemap', [
49			'help' => 'File path or URL of sitemap to import',
50			'short' => 's',
51			'required' => true,
52			])
53			->addOption('prefix', [
54			'help' => 'Optional path prefix of URLs to import',
55			'short' => 'p',
56			'required' => false,
57			])
58			->addOption('collection', [
59			'help' => 'Collection used to index (use the unique collection name)',
60			'short' => 'c',
61			'required' => true,
62			]);
63			}
64
65			/**
66			* @inheritDoc
67			*/
68			public function initialize(): void
69			{
70			$this->client = new BreviaClient();
71			}
72
73			/**
74			* @inheritDoc
75			*/
76			public function execute(Arguments $args, ConsoleIo $io)
77			{
78			$sitemap = $args->getOption('sitemap');
79			$content = file_get_contents($sitemap);
80			if (!$content) {
81			$io->abort(sprintf('Sitemap content not found: %s', $sitemap));
82			}
83
84			$name = $args->getOption('collection');
85			$response = $this->client->get('/collections', compact('name'));
86			$collectionId = Hash::get($response->getJson(), '0.cmetadata.id');
87			if (empty($collectionId)) {
88			$io->abort(sprintf('Collection not found: %s', $name));
89			}
90			$collection = $this->Collections->get($collectionId, ['contain' => ['HasDocuments']]);
91			$currentUrls = array_filter(array_map(function ($link) {
92			$link = $link->getTable()->get($link->id);
93
94			return $link->get('url');
95			},
96			$collection->has_documents));
97			$prefix = $args->getOption('prefix');
98
99			$xml = simplexml_load_string($content);
100			$json = json_encode($xml);
101			$data = (array)json_decode($json, true);
102			$urls = Hash::extract($data, 'url.{n}.loc');
103			if (empty($urls)) {
104			$io->abort('No URLs found in sitemap');
105			}
106			$entities = [];
107			LoggedUser::setUserAdmin();
108			$this->Links = $this->fetchTable('Links');
109			foreach ($urls as $url) {
110			if (in_array($url, $currentUrls) \|\| ($prefix && strpos($url, $prefix) !== 0)) {
111			continue;
112			}
113			$io->info('Adding link: ' . $url);
114			$data = [
115			'status' => 'on',
116			'title' => $url,
117			'url' => $url,
118			'extra' => [
119			'brevia' => [
120			'metadata' => [
121			'type' => 'links',
122			'url' => $url,
123			],
124			'options' => $this->linkOptions($url, (array)$collection->get('link_load_options')),
125			],
126			],
127			];
128			$entity = $this->Links->newEntity($data);
129			$entities[] = $this->Links->saveOrFail($entity);
130			}
131			/** @phpstan-ignore-next-line */
132			$this->Collections->addRelated($collection, 'has_documents', $entities);
133
134			$io->out('Done. Link added successfully: ' . count($entities));
135
136			return null;
137			}
138
139			/**
140			* Get link options
141			*
142			* @param string $url URL
143			* @param array $linkLoadOptions Link load options
144			* @return array
145			*/
146			protected function linkOptions(string $url, array $linkLoadOptions): array
147			{
148			$options = array_filter($linkLoadOptions, function ($o) use ($url) {
149			return $o['url'] === $url;
150			});
151			$selector = Hash::get($options, '0.selector');
152			if (!empty($selector)) {
153			return compact('selector');
154			}
155			$options = array_filter($linkLoadOptions, function ($o) use ($url) {
156			return strpos($url, $o['url']) === 0;
157			});
158
159			return ['selector' => Hash::get($options, '0.selector')];
160			}
161			}
162

brevia-ai / brevia-bedita

Pull Request — main (#14)

ImportSitemapCommand::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like