Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
6 | class PhpVersionCheck extends AbstractCheck |
||
7 | { |
||
8 | /** @var string */ |
||
9 | protected $greaterEquals; |
||
10 | |||
11 | /** @var string */ |
||
12 | protected $lessThan; |
||
13 | |||
14 | /** |
||
15 | * |
||
16 | * @param string $label Label |
||
17 | * @param string $greaterEquals minimum PHP version (optional) |
||
18 | * @param string $lessThan PHP version has to be smaller than this (optional) |
||
19 | */ |
||
20 | public function __construct(string $label, string $greaterEquals = null, string $lessThan = null) |
||
26 | |||
27 | public function getPhpVersion(): string |
||
31 | |||
32 | /** |
||
33 | * Check URL |
||
34 | * |
||
35 | * @return Result |
||
36 | */ |
||
37 | public function checkStatus(): Result |
||
54 | } |
||
55 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.