Complex classes like DistanceMatrixRequest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DistanceMatrixRequest, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | class DistanceMatrixRequest implements DistanceMatrixRequestInterface |
||
| 23 | { |
||
| 24 | /** |
||
| 25 | * @var LocationInterface[] |
||
| 26 | */ |
||
| 27 | private $origins = []; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var LocationInterface[] |
||
| 31 | */ |
||
| 32 | private $destinations = []; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var \DateTime|null |
||
| 36 | */ |
||
| 37 | private $departureTime; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var \DateTime|null |
||
| 41 | */ |
||
| 42 | private $arrivalTime; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var string|null |
||
| 46 | */ |
||
| 47 | private $travelMode; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var string|null |
||
| 51 | */ |
||
| 52 | private $avoid; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var string|null |
||
| 56 | */ |
||
| 57 | private $trafficModel; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @var string[] |
||
| 61 | */ |
||
| 62 | private $transitModes = []; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @var string|null |
||
| 66 | */ |
||
| 67 | private $transitRoutingPreference; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * @var string|null |
||
| 71 | */ |
||
| 72 | private $region; |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @var string|null |
||
| 76 | */ |
||
| 77 | private $unitSystem; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * @var string|null |
||
| 81 | */ |
||
| 82 | private $language; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @param LocationInterface[] $origins |
||
| 86 | * @param LocationInterface[] $destinations |
||
| 87 | */ |
||
| 88 | 172 | public function __construct(array $origins, array $destinations) |
|
| 93 | |||
| 94 | /** |
||
| 95 | * @return bool |
||
| 96 | */ |
||
| 97 | 20 | public function hasOrigins() |
|
| 101 | |||
| 102 | /** |
||
| 103 | * @return LocationInterface[] |
||
| 104 | */ |
||
| 105 | 20 | public function getOrigins() |
|
| 109 | |||
| 110 | /** |
||
| 111 | * @param LocationInterface[] $origins |
||
| 112 | */ |
||
| 113 | 172 | public function setOrigins(array $origins) |
|
| 118 | |||
| 119 | /** |
||
| 120 | * @param LocationInterface[] $origins |
||
| 121 | */ |
||
| 122 | 172 | public function addOrigins(array $origins) |
|
| 128 | |||
| 129 | /** |
||
| 130 | * @return bool |
||
| 131 | */ |
||
| 132 | 172 | public function hasOrigin(LocationInterface $origin) |
|
| 136 | |||
| 137 | 172 | public function addOrigin(LocationInterface $origin) |
|
| 143 | |||
| 144 | 4 | public function removeOrigin(LocationInterface $origin) |
|
| 149 | |||
| 150 | /** |
||
| 151 | * @return bool |
||
| 152 | */ |
||
| 153 | 20 | public function hasDestinations() |
|
| 157 | |||
| 158 | /** |
||
| 159 | * @return LocationInterface[] |
||
| 160 | */ |
||
| 161 | 20 | public function getDestinations() |
|
| 165 | |||
| 166 | /** |
||
| 167 | * @param LocationInterface[] $destinations |
||
| 168 | */ |
||
| 169 | 172 | public function setDestinations(array $destinations) |
|
| 174 | |||
| 175 | /** |
||
| 176 | * @param LocationInterface[] $destinations |
||
| 177 | */ |
||
| 178 | 172 | public function addDestinations(array $destinations) |
|
| 184 | |||
| 185 | /** |
||
| 186 | * @return bool |
||
| 187 | */ |
||
| 188 | 172 | public function hasDestination(LocationInterface $destination) |
|
| 192 | |||
| 193 | 172 | public function addDestination(LocationInterface $destination) |
|
| 199 | |||
| 200 | 4 | public function removeDestination(LocationInterface $destination) |
|
| 205 | |||
| 206 | /** |
||
| 207 | * @return bool |
||
| 208 | */ |
||
| 209 | 56 | public function hasDepartureTime() |
|
| 213 | |||
| 214 | /** |
||
| 215 | * @return \DateTime|null |
||
| 216 | */ |
||
| 217 | 12 | public function getDepartureTime() |
|
| 221 | |||
| 222 | 12 | public function setDepartureTime(\DateTime $departureTime = null) |
|
| 226 | |||
| 227 | /** |
||
| 228 | * @return bool |
||
| 229 | */ |
||
| 230 | 56 | public function hasArrivalTime() |
|
| 234 | |||
| 235 | /** |
||
| 236 | * @return \DateTime|null |
||
| 237 | */ |
||
| 238 | 12 | public function getArrivalTime() |
|
| 242 | |||
| 243 | 12 | public function setArrivalTime(\DateTime $arrivalTime = null) |
|
| 247 | |||
| 248 | /** |
||
| 249 | * @return bool |
||
| 250 | */ |
||
| 251 | 56 | public function hasTravelMode() |
|
| 255 | |||
| 256 | /** |
||
| 257 | * @return string|null |
||
| 258 | */ |
||
| 259 | 12 | public function getTravelMode() |
|
| 263 | |||
| 264 | /** |
||
| 265 | * @param string|null $travelMode |
||
| 266 | */ |
||
| 267 | 12 | public function setTravelMode($travelMode = null) |
|
| 271 | |||
| 272 | /** |
||
| 273 | * @return bool |
||
| 274 | */ |
||
| 275 | 56 | public function hasAvoid() |
|
| 279 | |||
| 280 | /** |
||
| 281 | * @return string|null |
||
| 282 | */ |
||
| 283 | 12 | public function getAvoid() |
|
| 287 | |||
| 288 | /** |
||
| 289 | * @param string|null $avoid |
||
| 290 | */ |
||
| 291 | 12 | public function setAvoid($avoid = null) |
|
| 295 | |||
| 296 | /** |
||
| 297 | * @return bool |
||
| 298 | */ |
||
| 299 | 56 | public function hasTrafficModel() |
|
| 303 | |||
| 304 | /** |
||
| 305 | * @return string|null |
||
| 306 | */ |
||
| 307 | 12 | public function getTrafficModel() |
|
| 311 | |||
| 312 | /** |
||
| 313 | * @param string|null $trafficModel |
||
| 314 | */ |
||
| 315 | 12 | public function setTrafficModel($trafficModel) |
|
| 319 | |||
| 320 | /** |
||
| 321 | * @return bool |
||
| 322 | */ |
||
| 323 | 64 | public function hasTransitModes() |
|
| 327 | |||
| 328 | /** |
||
| 329 | * @return string[] |
||
| 330 | */ |
||
| 331 | 20 | public function getTransitModes() |
|
| 335 | |||
| 336 | /** |
||
| 337 | * @param string[] $transitModes |
||
| 338 | */ |
||
| 339 | 12 | public function setTransitModes(array $transitModes) |
|
| 344 | |||
| 345 | /** |
||
| 346 | * @param string[] $transitModes |
||
| 347 | */ |
||
| 348 | 12 | public function addTransitModes(array $transitModes) |
|
| 354 | |||
| 355 | /** |
||
| 356 | * @param string $transitMode |
||
| 357 | * |
||
| 358 | * @return bool |
||
| 359 | */ |
||
| 360 | 20 | public function hasTransitMode($transitMode) |
|
| 364 | |||
| 365 | /** |
||
| 366 | * @param string $transitMode |
||
| 367 | */ |
||
| 368 | 20 | public function addTransitMode($transitMode) |
|
| 374 | |||
| 375 | /** |
||
| 376 | * @param string $transitMode |
||
| 377 | */ |
||
| 378 | 4 | public function removeTransitMode($transitMode) |
|
| 383 | |||
| 384 | /** |
||
| 385 | * @return bool |
||
| 386 | */ |
||
| 387 | 56 | public function hasTransitRoutingPreference() |
|
| 391 | |||
| 392 | /** |
||
| 393 | * @return string|null |
||
| 394 | */ |
||
| 395 | 12 | public function getTransitRoutingPreference() |
|
| 399 | |||
| 400 | /** |
||
| 401 | * @param string|null $transitRoutingPreference |
||
| 402 | */ |
||
| 403 | 12 | public function setTransitRoutingPreference($transitRoutingPreference) |
|
| 407 | |||
| 408 | /** |
||
| 409 | * @return bool |
||
| 410 | */ |
||
| 411 | 56 | public function hasRegion() |
|
| 415 | |||
| 416 | /** |
||
| 417 | * @return string|null |
||
| 418 | */ |
||
| 419 | 12 | public function getRegion() |
|
| 423 | |||
| 424 | /** |
||
| 425 | * @param string|null $region |
||
| 426 | */ |
||
| 427 | 12 | public function setRegion($region = null) |
|
| 431 | |||
| 432 | /** |
||
| 433 | * @return bool |
||
| 434 | */ |
||
| 435 | 56 | public function hasUnitSystem() |
|
| 439 | |||
| 440 | /** |
||
| 441 | * @return string|null |
||
| 442 | */ |
||
| 443 | 12 | public function getUnitSystem() |
|
| 447 | |||
| 448 | /** |
||
| 449 | * @param string|null $unitSystem |
||
| 450 | */ |
||
| 451 | 12 | public function setUnitSystem($unitSystem = null) |
|
| 455 | |||
| 456 | /** |
||
| 457 | * @return bool |
||
| 458 | */ |
||
| 459 | 56 | public function hasLanguage() |
|
| 463 | |||
| 464 | /** |
||
| 465 | * @return string|null |
||
| 466 | */ |
||
| 467 | 12 | public function getLanguage() |
|
| 471 | |||
| 472 | /** |
||
| 473 | * @param string|null $language |
||
| 474 | */ |
||
| 475 | 12 | public function setLanguage($language = null) |
|
| 479 | |||
| 480 | /** |
||
| 481 | * {@inheritdoc} |
||
| 482 | */ |
||
| 483 | public function buildQuery() |
||
| 542 | } |
||
| 543 |