Cnpj::createFromString() - Code Metrics - Inspection of "Fix documentation (#43)" - brazanation/php-documents - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (0e9587)

by Antonio Oertel

created 2018-08-20 19:34 UTC

Cnpj::createFromString() A

↳ Parent: Cnpj

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
nc	1
cc	1
nop	1
crap	1

<?php

namespace Brazanation\Documents;

final class Cnpj extends AbstractDocument
{
    const LENGTH = 14;

    const LABEL = 'CNPJ';

    const REGEX = '/^([\d]{2})([\d]{3})([\d]{3})([\d]{4})([\d]{2})$/';

    const NUMBER_OF_DIGITS = 2;

    /**
     * Cnpj constructor.
     *
     * @param string $cnpj Only accept numbers
     */
    public function __construct($cnpj)
    {
        $cnpj = preg_replace('/\D/', '', $cnpj);
        parent::__construct($cnpj, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
    }

    public static function createFromString($number)
    {
        return parent::tryCreateFromString(self::class, $number, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function format()
    {
        return preg_replace(self::REGEX, '$1.$2.$3/$4-$5', "{$this}");
    }

    /**
     * {@inheritdoc}
     */
    public function calculateDigit($baseNumber)
    {
        $calculator = new DigitCalculator($baseNumber);
        $calculator->useComplementaryInsteadOfModule();
        $calculator->replaceWhen('0', 10, 11);
        $calculator->withModule(DigitCalculator::MODULE_11);
        $firstDigit = $calculator->calculate();
        $calculator->addDigit($firstDigit);
        $secondDigit = $calculator->calculate();

        return "{$firstDigit}{$secondDigit}";
    }
}


1		<?php
2
3		namespace Brazanation\Documents;
4
5		final class Cnpj extends AbstractDocument
6		{
7		const LENGTH = 14;
8
9		const LABEL = 'CNPJ';
10
11		const REGEX = '/^([\d]{2})([\d]{3})([\d]{3})([\d]{4})([\d]{2})$/';
12
13		const NUMBER_OF_DIGITS = 2;
14
15		/**
16		* Cnpj constructor.
17		*
18		* @param string $cnpj Only accept numbers
19		*/
20	51	public function __construct($cnpj)
21		{
22	51	$cnpj = preg_replace('/\D/', '', $cnpj);
23	51	parent::__construct($cnpj, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
24	37	}
25
26	11	public static function createFromString($number)
27		{
28	11	return parent::tryCreateFromString(self::class, $number, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
		0 ignored issues – show Comprehensibility Bug introduced 2018-08-17 02:18 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`tryCreateFromString()` instead of `createFromString()`). Are you sure this is correct? If so, you might want to change this to `$this->tryCreateFromString()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
29		}
30
31		/**
32		* {@inheritdoc}
33		*/
34	4	public function format()
35		{
36	4	return preg_replace(self::REGEX, '$1.$2.$3/$4-$5', "{$this}");
37		}
38
39		/**
40		* {@inheritdoc}
41		*/
42	41	public function calculateDigit($baseNumber)
43		{
44	41	$calculator = new DigitCalculator($baseNumber);
45	41	$calculator->useComplementaryInsteadOfModule();
46	41	$calculator->replaceWhen('0', 10, 11);
47	41	$calculator->withModule(DigitCalculator::MODULE_11);
48	41	$firstDigit = $calculator->calculate();
49	41	$calculator->addDigit($firstDigit);
50	41	$secondDigit = $calculator->calculate();
51
52	41	return "{$firstDigit}{$secondDigit}";
53		}
54		}
55

brazanation / php-documents

Branch — master (0e9587)

Cnpj::createFromString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like