PisPasep::calculateDigit() - Code Metrics - Inspection of "Add new way to create an Document objects" - brazanation/php-documents - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#42)

by Antonio Oertel

created 2018-08-17 02:42 UTC

PisPasep::calculateDigit() A

↳ Parent: PisPasep

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace Brazanation\Documents;

final class PisPasep extends AbstractDocument
{
    const LENGTH = 11;

    const LABEL = 'PisPasep';

    const REGEX = '/^([\d]{3})([\d]{5})([\d]{2})([\d]{1})$/';

    const NUMBER_OF_DIGITS = 1;

    /**
     * PisPasep constructor.
     *
     * @param $number
     */
    public function __construct($number)
    {
        $number = preg_replace('/\D/', '', $number);
        parent::__construct($number, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
    }

    public static function createFromString($number)
    {
        return parent::tryCreateFromString(self::class, $number, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @return string Returns formatted number, such as: 00.00000.00-0
     */
    public function format()
    {
        return preg_replace(self::REGEX, '$1.$2.$3-$4', "{$this}");
    }

    /**
     * {@inheritdoc}
     */
    public function calculateDigit($baseNumber)
    {
        $calculator = new DigitCalculator($baseNumber);
        $calculator->withMultipliersInterval(2, 9);
        $calculator->useComplementaryInsteadOfModule();
        $calculator->replaceWhen('0', 10, 11);
        $calculator->withModule(DigitCalculator::MODULE_11);
        $digit = $calculator->calculate();

        return "{$digit}";
    }
}


1		<?php
2
3		namespace Brazanation\Documents;
4
5		final class PisPasep extends AbstractDocument
6		{
7		const LENGTH = 11;
8
9		const LABEL = 'PisPasep';
10
11		const REGEX = '/^([\d]{3})([\d]{5})([\d]{2})([\d]{1})$/';
12
13		const NUMBER_OF_DIGITS = 1;
14
15		/**
16		* PisPasep constructor.
17		*
18		* @param $number
19		*/
20	22	public function __construct($number)
21		{
22	22	$number = preg_replace('/\D/', '', $number);
23	22	parent::__construct($number, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
24	8	}
25
26	11	public static function createFromString($number)
27		{
28	11	return parent::tryCreateFromString(self::class, $number, self::LENGTH, self::NUMBER_OF_DIGITS, self::LABEL);
		0 ignored issues – show Comprehensibility Bug introduced 2018-08-17 02:18 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`tryCreateFromString()` instead of `createFromString()`). Are you sure this is correct? If so, you might want to change this to `$this->tryCreateFromString()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
29		}
30
31		/**
32		* @return string Returns formatted number, such as: 00.00000.00-0
33		*/
34	4	public function format()
35		{
36	4	return preg_replace(self::REGEX, '$1.$2.$3-$4', "{$this}");
37		}
38
39		/**
40		* {@inheritdoc}
41		*/
42	12	public function calculateDigit($baseNumber)
43		{
44	12	$calculator = new DigitCalculator($baseNumber);
45	12	$calculator->withMultipliersInterval(2, 9);
46	12	$calculator->useComplementaryInsteadOfModule();
47	12	$calculator->replaceWhen('0', 10, 11);
48	12	$calculator->withModule(DigitCalculator::MODULE_11);
49	12	$digit = $calculator->calculate();
50
51	12	return "{$digit}";
52		}
53		}
54

brazanation / php-documents

Pull Request — master (#42)

PisPasep::calculateDigit() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like