It seems like $deleted defined by parameter $deleted on line 69 can also be of type integer; however, OCA\NextNote\Service\NotebookService::find() does only seem to accept boolean, maybe add an additional type check?
This check looks at variables that have been passed in as parameters and are passed out again
to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.
Loading history...
72
73
return new JSONResponse($results);
74
}
75
76
/**
77
* @NoAdminRequired
78
* @NoCSRFRequired
79
* @TODO Add etag / lastmodified
80
* @param $id
81
* @return NotFoundJSONResponse|JSONResponse
82
*/
83
public function get($id) {
84
$result = $this->groupService->find($id);
85
if (!$result) {
86
return new NotFoundJSONResponse();
87
}
88
//@todo Check access
89
$result = $result->jsonSerialize();
90
return new JSONResponse($result);
91
}
92
93
94
/**
95
* @NoAdminRequired
96
* @NoCSRFRequired
97
* @param $name
98
* @param $color
99
* @param $parent_id
100
* @return JSONResponse
101
*/
102
public function create($name, $color, $parent_id) {
103
if ($name == "" || !$name) {
104
return new JSONResponse(['error' => 'name is missing']);
105
}
106
$group = [
107
'parent_id' => $parent_id,
108
'name' => $name,
109
'color' => $color,
110
'guid' => Utils::GUID()
111
];
112
113
if($this->groupService->findByName($name)){
114
return new JSONResponse(['error' => 'Group already exists']);
brantje /
nextnote
brantje
This check looks at variables that have been passed in as parameters and are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.