It seems like $deleted defined by parameter $deleted on line 68 can also be of type integer; however, OCA\NextNote\Service\NotebookService::find() does only seem to accept boolean, maybe add an additional type check?
This check looks at variables that have been passed in as parameters and are passed out again
to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.
Loading history...
71
72
return new JSONResponse($results);
73
}
74
75
/**
76
* @NoAdminRequired
77
* @NoCSRFRequired
78
* @TODO Add etag / lastmodified
79
*/
80
public function get($id) {
81
$result = $this->groupService->find($id);
82
if (!$result) {
83
return new NotFoundJSONResponse();
84
}
85
//@todo Check access
86
$result = $result->jsonSerialize();
87
return new JSONResponse($result);
88
}
89
90
91
/**
92
* @NoAdminRequired
93
* @NoCSRFRequired
94
*/
95
public function create($name, $color, $parent_id) {
96
if ($name == "" || !$name) {
97
return new JSONResponse(['error' => 'name is missing']);
98
}
99
$group = [
100
'parent_id' => $parent_id,
101
'name' => $name,
102
'color' => $color,
103
'guid' => Utils::GUID()
104
];
105
106
if($this->groupService->findByName($name)){
107
return new JSONResponse(['error' => 'Group already exists']);
brantje /
nextnote
brantje
This check looks at variables that have been passed in as parameters and are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.