Application::__construct() - Code Metrics - Inspection of "Rename namespace" - brantje/nextnote - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Sander

created 2017-07-08 14:56 UTC

Application::__construct() A

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines	58
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	58
rs	9.639
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	0

How to fix Long Method

<?php
/**
 * Nextcloud - NextNote
 *
 * @copyright Copyright (c) 2015, Ben Curtis <[email protected]>
 * @copyright Copyright (c) 2017, Sander Brand ([email protected])
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */
namespace OCA\NextNote\AppInfo;

use OC\Files\View;


use OCA\NextNote\Controller\NextNoteApiController;
use OCA\NextNote\Controller\PageController;
use OCP\IConfig;
use OCP\IDBConnection;

use OCP\AppFramework\App;
use OCP\IL10N;
use OCP\Util;

class Application extends App {
	public function __construct() {
		parent::__construct('nextnote');
		$container = $this->getContainer();
		// Allow automatic DI for the View, until we migrated to Nodes API
		$container->registerService(View::class, function () {
			return new View('');
		}, false);
		$container->registerService('isCLI', function () {
			return \OC::$CLI;
		});




		/** Cron
		$container->registerService('CronService', function ($c) {
			return new CronService(
				$c->query('CredentialService'),
				$c->query('Logger'),
				$c->query('Utils'),
				$c->query('NotificationService'),
				$c->query('ActivityService'),
				$c->query('IDBConnection')
			);
		});**/
		/*
		$container->registerService('Db', function () {
			return new Db();
		});*/



		$container->registerService('Logger', function ($c) {
			return $c->query('ServerContainer')->getLogger();
		});

//		 Aliases for the controllers so we can use the automatic DI
		$container->registerAlias('PageController', PageController::class);
		$container->registerAlias('NextNoteApiController', NextNoteApiController::class);


		/*$container->registerAlias('CredentialController', CredentialController::class);
		$container->registerAlias('PageController', PageController::class);
		$container->registerAlias('PageController', PageController::class);
		$container->registerAlias('VaultController', VaultController::class);
		$container->registerAlias('VaultController', VaultController::class);
		$container->registerAlias('CredentialService', CredentialService::class);
		$container->registerAlias('NotificationService', NotificationService::class);
		$container->registerAlias('ActivityService', ActivityService::class);
		$container->registerAlias('VaultService', VaultService::class);
		$container->registerAlias('FileService', FileService::class);
		$container->registerAlias('ShareService', ShareService::class);
		$container->registerAlias('Utils', Utils::class);
		$container->registerAlias('IDBConnection', IDBConnection::class);
		$container->registerAlias('IConfig', IConfig::class);
		$container->registerAlias('SettingsService', SettingsService::class);
		$container->registerAlias('APIMiddleware', APIMiddleware::class);*/
	}

	/**
	 * Register the navigation entry
	 */
	public function registerNavigationEntry() {
		$c = $this->getContainer();
		/** @var \OCP\IServerContainer $server */
		$server = $c->getServer();
		$navigationEntry = function () use ($c, $server) {
			return [
				'id' => $c->getAppName(),
				'order' => 10,
				'name' => $c->query(IL10N::class)->t('Notes'),
				'href' => $server->getURLGenerator()->linkToRoute('nextnote.page.index'),
				'icon' => $server->getURLGenerator()->imagePath($c->getAppName(), 'app.svg'),
			];
		};
		$server->getNavigationManager()->add($navigationEntry);
	}
}

1			<?php
2			/**
3			* Nextcloud - NextNote
4			*
5			* @copyright Copyright (c) 2015, Ben Curtis <[email protected]>
6			* @copyright Copyright (c) 2017, Sander Brand ([email protected])
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23			namespace OCA\NextNote\AppInfo;
24
25			use OC\Files\View;
26
27
28			use OCA\NextNote\Controller\NextNoteApiController;
29			use OCA\NextNote\Controller\PageController;
30			use OCP\IConfig;
31			use OCP\IDBConnection;
32
33			use OCP\AppFramework\App;
34			use OCP\IL10N;
35			use OCP\Util;
36
37			class Application extends App {
38			public function __construct() {
39			parent::__construct('nextnote');
40			$container = $this->getContainer();
41			// Allow automatic DI for the View, until we migrated to Nodes API
42			$container->registerService(View::class, function () {
43			return new View('');
44			}, false);
45			$container->registerService('isCLI', function () {
46			return \OC::$CLI;
47			});
48
49
50
51
52			/** Cron
53			$container->registerService('CronService', function ($c) {
54			return new CronService(
55			$c->query('CredentialService'),
56			$c->query('Logger'),
57			$c->query('Utils'),
58			$c->query('NotificationService'),
59			$c->query('ActivityService'),
60			$c->query('IDBConnection')
61			);
62			});**/
63			/*
64			$container->registerService('Db', function () {
65			return new Db();
66			});*/
67
68
69
70			$container->registerService('Logger', function ($c) {
71			return $c->query('ServerContainer')->getLogger();
72			});
73
74			// Aliases for the controllers so we can use the automatic DI
75			$container->registerAlias('PageController', PageController::class);
76			$container->registerAlias('NextNoteApiController', NextNoteApiController::class);
77
78
79			/*$container->registerAlias('CredentialController', CredentialController::class);
80			$container->registerAlias('PageController', PageController::class);
81			$container->registerAlias('PageController', PageController::class);
82			$container->registerAlias('VaultController', VaultController::class);
83			$container->registerAlias('VaultController', VaultController::class);
84			$container->registerAlias('CredentialService', CredentialService::class);
85			$container->registerAlias('NotificationService', NotificationService::class);
86			$container->registerAlias('ActivityService', ActivityService::class);
87			$container->registerAlias('VaultService', VaultService::class);
88			$container->registerAlias('FileService', FileService::class);
89			$container->registerAlias('ShareService', ShareService::class);
90			$container->registerAlias('Utils', Utils::class);
91			$container->registerAlias('IDBConnection', IDBConnection::class);
92			$container->registerAlias('IConfig', IConfig::class);
93			$container->registerAlias('SettingsService', SettingsService::class);
94			$container->registerAlias('APIMiddleware', APIMiddleware::class);*/
95			}
96
97			/**
98			* Register the navigation entry
99			*/
100			public function registerNavigationEntry() {
101			$c = $this->getContainer();
102			/** @var \OCP\IServerContainer $server */
103			$server = $c->getServer();
104			$navigationEntry = function () use ($c, $server) {
105			return [
106			'id' => $c->getAppName(),
107			'order' => 10,
108			'name' => $c->query(IL10N::class)->t('Notes'),
109			'href' => $server->getURLGenerator()->linkToRoute('nextnote.page.index'),
110			'icon' => $server->getURLGenerator()->imagePath($c->getAppName(), 'app.svg'),
111			];
112			};
113			$server->getNavigationManager()->add($navigationEntry);
114			}
115			}

brantje / nextnote

Pull Request — master (#21)

Application::__construct() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like