Issues in Utils.php - Failed Issues - Inspection of "Sharing" - brantje/nextnote - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#55)

by Sander

created 2018-04-04 15:20 UTC

lib/Utility/Utils.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Nextcloud - namespace OCA\Nextnote
 *
 * @copyright Copyright (c) 2016, Sander Brand ([email protected])
 * @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\NextNote\Utility;

class Utils {
    /**
     * Gets the unix epoch UTC timestamp
     * @return int
     */
    public static $maxPartSize = 2621440;

	public static function getTime() {
		return (new \DateTime())->getTimestamp();
	}
	/**
	 * @return int the current unix time in milliseconds
	 */
	public static function getMicroTime() {
		return microtime(true);
	}

	/**
	 * @param $uid
	 * @return string
	 */
	public static function getNameByUid($uid){
		$u = Utils::getUserInfo($uid);
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
		return $u['display_name'];
	}

	public static function getUserInfo($uid){
		$um = \OC::$server->getUserManager();
		$u = $um->get($uid);
		$user = [
			'display_name' => $u->getDisplayName(),
			'uid' => $uid,
			'avatar' => $u->getAvatarImage(32)
		];
		return $user;
	}

	/**
	 * Splits a string in parts of 5Mb
	 * @param $str
	 * @return array
	 */
	public function splitContent($str) {
		$maxlength = Utils::$maxPartSize; // 5 Megs (2 bytes per character)
		$count = 0;
		$strarray = array();
		while (true) {
			if (strlen($str) <= $maxlength) {
				$strarray[$count++] = $str;
				return $strarray;
			} else {
				$strarray[$count++] = substr($str, 0, $maxlength);
				$str = substr($str, $maxlength);
			}
		}
		return $strarray;
	}

	/**
	 * @param $key
	 * @param $value
	 * @param $array
	 * @return int|null|string
	 * @internal param $ $
	 */
	public static function getItemByProperty($key, $value, $array) {
		foreach ($array as $_key => $val) {
			if ($val[$key] === $value) {
				return $val;
			}
		}
		return null;
	}
}

1			<?php
2			/**
3			* Nextcloud - namespace OCA\Nextnote
4			*
5			* @copyright Copyright (c) 2016, Sander Brand ([email protected])
6			* @copyright Copyright (c) 2016, Marcos Zuriaga Miguel ([email protected])
7			* @license GNU AGPL version 3 or any later version
8			*
9			* This program is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License as
11			* published by the Free Software Foundation, either version 3 of the
12			* License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU Affero General Public License for more details.
18			*
19			* You should have received a copy of the GNU Affero General Public License
20			* along with this program. If not, see <http://www.gnu.org/licenses/>.
21			*
22			*/
23
24			namespace OCA\NextNote\Utility;
25
26			class Utils {
27			/**
28			* Gets the unix epoch UTC timestamp
29			* @return int
30			*/
31			public static $maxPartSize = 2621440;
32
33			public static function getTime() {
34			return (new \DateTime())->getTimestamp();
35			}
36			/**
37			* @return int the current unix time in milliseconds
38			*/
39			public static function getMicroTime() {
40			return microtime(true);
41			}
42
43			/**
44			* @param $uid
45			* @return string
46			*/
47			public static function getNameByUid($uid){
48			$u = Utils::getUserInfo($uid);
			0 ignored issues – show Coding Style introduced 2018-04-04 15:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
49			return $u['display_name'];
50			}
51
52			public static function getUserInfo($uid){
53			$um = \OC::$server->getUserManager();
54			$u = $um->get($uid);
55			$user = [
56			'display_name' => $u->getDisplayName(),
57			'uid' => $uid,
58			'avatar' => $u->getAvatarImage(32)
59			];
60			return $user;
61			}
62
63			/**
64			* Splits a string in parts of 5Mb
65			* @param $str
66			* @return array
67			*/
68			public function splitContent($str) {
69			$maxlength = Utils::$maxPartSize; // 5 Megs (2 bytes per character)
70			$count = 0;
71			$strarray = array();
72			while (true) {
73			if (strlen($str) <= $maxlength) {
74			$strarray[$count++] = $str;
75			return $strarray;
76			} else {
77			$strarray[$count++] = substr($str, 0, $maxlength);
78			$str = substr($str, $maxlength);
79			}
80			}
81			return $strarray;
82			}
83
84			/**
85			* @param $key
86			* @param $value
87			* @param $array
88			* @return int\|null\|string
89			* @internal param $ $
90			*/
91			public static function getItemByProperty($key, $value, $array) {
92			foreach ($array as $_key => $val) {
93			if ($val[$key] === $value) {
94			return $val;
95			}
96			}
97			return null;
98			}
99			}

brantje / nextnote

Pull Request — master (#55)

lib/Utility/Utils.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like