OCA\OwnNote\Service\OwnNoteGroupService

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	53.13 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	deleteGroup()	9	9	2
A	renameGroup()	8	8	2

<?php
/**
 * Nextcloud - passman
 *
 * @copyright Copyright (c) 2016, Sander Brand (brantje@gmail.com)
 * @copyright Copyright (c) 2016, Marcos Zuriaga Miguel (wolfi@wolfi.es)
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\OwnNote\Service;

use OCA\OwnNote\Db\OwnNote;
use OCA\OwnNote\Utility\Evernote;
use OCA\OwnNote\Utility\Utils;
use OCP\IConfig;
use OCP\AppFramework\Db\DoesNotExistException;
use DateTime;
use DOMDocument;
use OC\Files\Filesystem;
use OCA\OwnNote\Db\OwnNoteMapper;
use Punic\Exception;


class OwnNoteGroupService {

	private $noteMapper;
	private $utils;
	private $noteService;

	public function __construct(OwnNoteMapper $noteMapper, Utils $utils, OwnNoteService $noteService) {
		$this->noteMapper = $noteMapper;
		$this->utils = $utils;
		$this->noteService = $noteService;
	}

	public function deleteGroup($FOLDER, $group) {

This method seems to be duplicated in your project.

		// We actually need to just rename all the notes
		$uid = \OC::$server->getUserSession()->getUser()->getUID();
		$results = $this->noteMapper->findNotesByGroup($group, $uid);
		foreach ($results as $result) {
			$this->noteService->renameNote($FOLDER, $result->getId(), $result->getName(), '');

Consider using $result->name. There is an issue with getName() and APC-enabled PHP versions.

		}
		return true;
	}

	public function renameGroup($FOLDER, $group, $newgroup) {

This method seems to be duplicated in your project.

		$uid = \OC::$server->getUserSession()->getUser()->getUID();
		$results = $this->noteMapper->findNotesByGroup($group, $uid);
		foreach ($results as $result) {
			$this->noteService->renameNote($FOLDER, $result->getId(), $result->getName(), $newgroup);

Consider using $result->name. There is an issue with getName() and APC-enabled PHP versions.

		}
		return true;
	}

}