FullUriGenerator::generate() - Code Metrics - bramstroker/zf2-fullpage-cache - Measure and Improve Code Quality continuously with Scrutinizer

FullUriGenerator::generate() A
last analyzed 2017-11-20 13:40 UTC

↳ Parent: FullUriGenerator

Complexity

Conditions	4
Paths	5

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	5
nop	0

<?php
/**
 * @author Bram Gerritsen [email protected]
 * @copyright (c) Bram Gerritsen 2013
 * @license http://opensource.org/licenses/mit-license.php
 */

namespace StrokerCache\IdGenerator;

use StrokerCache\Exception\RuntimeException;

class FullUriGenerator implements IdGeneratorInterface
{

    /**
     * {@inheritDoc}
     *
     * @throws RuntimeException
     */
    public function generate()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($_SERVER['REQUEST_URI'])) {
            throw new RuntimeException("Can't auto-detect current page identity");
        }

        $port = ($_SERVER['SERVER_PORT'] == '80') ? '' : (':'.$_SERVER['SERVER_PORT']);
        $scheme = stripos($_SERVER['SERVER_PROTOCOL'], 'https') === 0 ? 'https' : 'http';

        return md5($scheme . '://'.$_SERVER['HTTP_HOST']. $port . $_SERVER['REQUEST_URI']);
    }
}


1			<?php
2			/**
3			* @author Bram Gerritsen [email protected]
4			* @copyright (c) Bram Gerritsen 2013
5			* @license http://opensource.org/licenses/mit-license.php
6			*/
7
8			namespace StrokerCache\IdGenerator;
9
10			use StrokerCache\Exception\RuntimeException;
11
12			class FullUriGenerator implements IdGeneratorInterface
13			{
14
15			/**
16			* {@inheritDoc}
17			*
18			* @throws RuntimeException
19			*/
20			public function generate()
			0 ignored issues – show Coding Style introduced 2017-08-30 06:50 UTC by Report Bug Copy Issue Report `generate` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
21			{
22			if (!isset($_SERVER['REQUEST_URI'])) {
23			throw new RuntimeException("Can't auto-detect current page identity");
24			}
25
26			$port = ($_SERVER['SERVER_PORT'] == '80') ? '' : (':'.$_SERVER['SERVER_PORT']);
27			$scheme = stripos($_SERVER['SERVER_PROTOCOL'], 'https') === 0 ? 'https' : 'http';
28
29			return md5($scheme . '://'.$_SERVER['HTTP_HOST']. $port . $_SERVER['REQUEST_URI']);
30			}
31			}
32

bramstroker / zf2-fullpage-cache

GitHub Access Token became invalid

FullUriGenerator::generate() A last analyzed 2017-11-20 13:40 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FullUriGenerator::generate() A
last analyzed 2017-11-20 13:40 UTC