AbstractRenderer - Code Metrics - Inspection of "Disable scrutinizer code coverage" - bramstroker/zf2-form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7ab8ec...e52d31 )

by Bram

created 2016-02-20 10:51 UTC

AbstractRenderer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	14
Bugs	4	Features	4

Metric	Value
wmc	11
c	14
b	4
f	4
lcom	1
cbo	2
dl	0
loc	91
rs	10

7 Methods

Rating	Name	Size	Complexity
A	getHttpRouter()	4	1
A	setHttpRouter()	4	1
A	getOptions()	4	1
B	setOptions()	14	5
A	setDefaultOptions()	4	1
A	getFormManager()	4	1
A	setFormManager()	4	1

<?php
/**
 * Abstract form renderer
 *
 * @category  StrokerForm
 * @package   StrokerForm\Renderer
 * @copyright 2012 Bram Gerritsen
 * @version   SVN: $Id$
 */

namespace StrokerForm\Renderer;

use Zend\I18n\Translator\TranslatorAwareInterface;
use Zend\I18n\Translator\Translator;
use Zend\I18n\Translator\TranslatorAwareTrait;
use Zend\I18n\Translator\TranslatorInterface;
use Zend\Mvc\Router\RouteInterface;
use Zend\Stdlib\AbstractOptions;
use StrokerForm\FormManager;

abstract class AbstractRenderer implements RendererInterface, TranslatorAwareInterface
{
    use TranslatorAwareTrait;

    /**
     * @var \Zend\Mvc\Router\RouteInterface
     */
    protected $httpRouter;

    /**
     * @var AbstractOptions
     */
    protected $defaultOptions = array();

    /**
     * @var Options
     */
    protected $options = null;

    /**
     * @var FormManager
     */
    protected $formManager;

    /**
     * @return RouteInterface
     */
    public function getHttpRouter()
    {
        return $this->httpRouter;
    }

    /**
     * @param RouteInterface $httpRouter
     * @return void
     */
    public function setHttpRouter(RouteInterface $httpRouter)
    {
        $this->httpRouter = $httpRouter;
    }

    /**
     * @return AbstractOptions
     */
    public function getOptions()
    {
        return $this->options;
    }

    /**
     * @param array $options
     */
    public function setOptions(array $options = array())
    {
        if ($this->options === null) {
            $this->options = clone $this->defaultOptions;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        }

        foreach ($options as $key => $value) {
            if (isset($this->options->{$key}) && is_array($this->options->{$key})) {
                $options[$key] = $this->options->mergeRecursive($this->options->{$key}, $value);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            }
        }

        $this->options->setFromArray($options);
    }

    /**
     * @param AbstractOptions $options
     */
    public function setDefaultOptions(AbstractOptions $options = null)
    {
        $this->defaultOptions = $options;
    }

    /**
     * @return FormManager
     */
    public function getFormManager()
    {
        return $this->formManager;
    }

    /**
     * @param FormManager $formManager
     */
    public function setFormManager(FormManager $formManager)
    {
        $this->formManager = $formManager;
    }
}


1			<?php
2			/**
3			* Abstract form renderer
4			*
5			* @category StrokerForm
6			* @package StrokerForm\Renderer
7			* @copyright 2012 Bram Gerritsen
8			* @version SVN: $Id$
9			*/
10
11			namespace StrokerForm\Renderer;
12
13			use Zend\I18n\Translator\TranslatorAwareInterface;
14			use Zend\I18n\Translator\Translator;
15			use Zend\I18n\Translator\TranslatorAwareTrait;
16			use Zend\I18n\Translator\TranslatorInterface;
17			use Zend\Mvc\Router\RouteInterface;
18			use Zend\Stdlib\AbstractOptions;
19			use StrokerForm\FormManager;
20
21			abstract class AbstractRenderer implements RendererInterface, TranslatorAwareInterface
22			{
23			use TranslatorAwareTrait;
24
25			/**
26			* @var \Zend\Mvc\Router\RouteInterface
27			*/
28			protected $httpRouter;
29
30			/**
31			* @var AbstractOptions
32			*/
33			protected $defaultOptions = array();
34
35			/**
36			* @var Options
37			*/
38			protected $options = null;
39
40			/**
41			* @var FormManager
42			*/
43			protected $formManager;
44
45			/**
46			* @return RouteInterface
47			*/
48			public function getHttpRouter()
49			{
50			return $this->httpRouter;
51			}
52
53			/**
54			* @param RouteInterface $httpRouter
55			* @return void
56			*/
57			public function setHttpRouter(RouteInterface $httpRouter)
58			{
59			$this->httpRouter = $httpRouter;
60			}
61
62			/**
63			* @return AbstractOptions
64			*/
65			public function getOptions()
66			{
67			return $this->options;
68			}
69
70			/**
71			* @param array $options
72			*/
73			public function setOptions(array $options = array())
74			{
75			if ($this->options === null) {
76			$this->options = clone $this->defaultOptions;
			0 ignored issues – show Documentation Bug introduced 2016-02-20 09:35 UTC by Report Bug Copy Issue Report `clone $this->defaultOptions` is of type `object<Zend\Stdlib\AbstractOptions>`, but the property `$options` was declared to be of type `object<StrokerForm\Renderer\Options>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
77			}
78
79			foreach ($options as $key => $value) {
80			if (isset($this->options->{$key}) && is_array($this->options->{$key})) {
81			$options[$key] = $this->options->mergeRecursive($this->options->{$key}, $value);
			0 ignored issues – show Bug introduced 2016-02-20 09:35 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Zend\Stdlib\AbstractOptions` as the method `mergeRecursive()` does only exist in the following sub-classes of `Zend\Stdlib\AbstractOptions`: `StrokerForm\Renderer\JqueryValidate\Options`, `StrokerForm\Renderer\Options`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
82			}
83			}
84
85			$this->options->setFromArray($options);
86			}
87
88			/**
89			* @param AbstractOptions $options
90			*/
91			public function setDefaultOptions(AbstractOptions $options = null)
92			{
93			$this->defaultOptions = $options;
94			}
95
96			/**
97			* @return FormManager
98			*/
99			public function getFormManager()
100			{
101			return $this->formManager;
102			}
103
104			/**
105			* @param FormManager $formManager
106			*/
107			public function setFormManager(FormManager $formManager)
108			{
109			$this->formManager = $formManager;
110			}
111			}
112

bramstroker / zf2-form

GitHub Access Token became invalid

Push — master ( 7ab8ec...e52d31 )

AbstractRenderer A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like