GreaterThan - Code Metrics - Inspection of "Merge pull request #43 from damanikrish/allow-cust..." - bramstroker/zf2-form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8f8143...6b03f2 )

by Bram

created 2016-09-13 07:52 UTC

GreaterThan A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	32
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getRules()	4	1
A	getMessages()	7	1
A	canHandle()	4	1

<?php
/**
 * GreaterThan
 *
 * @category  StrokerForm
 * @package   StrokerForm\Renderer
 * @copyright 2012 Bram Gerritsen
 * @version   SVN: $Id$
 */

namespace StrokerForm\Renderer\JqueryValidate\Rule;

use Zend\Form\ElementInterface;
use Zend\Validator\ValidatorInterface;
use Zend\Validator\GreaterThan as GreaterThanValidator;

class GreaterThan extends AbstractRule
{
    /**
     * {@inheritDoc}
     */
    public function getRules(ValidatorInterface $validator, ElementInterface $element = null)
    {
        return array('min' => $validator->getMin());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * {@inheritDoc}
     */
    public function getMessages(ValidatorInterface $validator)
    {
        return array(
            'min' =>
                sprintf($this->translateMessage('The input is not greater than %s'), $validator->getMin())
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );
    }

    /**
     * Whether this rule supports certain validators
     *
     * @param ValidatorInterface $validator
     * @return mixed
     */
    public function canHandle(ValidatorInterface $validator)
    {
        return $validator instanceof GreaterThanValidator;
    }
}


GitHub Access Token became invalid

Push — develop ( 8f8143...6b03f2 )

GreaterThan A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

1			<?php
2			/**
3			* GreaterThan
4			*
5			* @category StrokerForm
6			* @package StrokerForm\Renderer
7			* @copyright 2012 Bram Gerritsen
8			* @version SVN: $Id$
9			*/
10
11			namespace StrokerForm\Renderer\JqueryValidate\Rule;
12
13			use Zend\Form\ElementInterface;
14			use Zend\Validator\ValidatorInterface;
15			use Zend\Validator\GreaterThan as GreaterThanValidator;
16
17			class GreaterThan extends AbstractRule
18			{
19			/**
20			* {@inheritDoc}
21			*/
22			public function getRules(ValidatorInterface $validator, ElementInterface $element = null)
23			{
24			return array('min' => $validator->getMin());
			0 ignored issues – show Bug introduced 2016-02-20 09:35 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Validator\ValidatorInterface` as the method `getMin()` does only exist in the following implementations of said interface: `Zend\Validator\Between`, `Zend\Validator\File\Count`, `Zend\Validator\File\FilesSize`, `Zend\Validator\File\Size`, `Zend\Validator\File\WordCount`, `Zend\Validator\GreaterThan`, `Zend\Validator\StringLength`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
25			}
26
27			/**
28			* {@inheritDoc}
29			*/
30			public function getMessages(ValidatorInterface $validator)
31			{
32			return array(
33			'min' =>
34			sprintf($this->translateMessage('The input is not greater than %s'), $validator->getMin())
			0 ignored issues – show Bug introduced 2016-02-20 09:35 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\Validator\ValidatorInterface` as the method `getMin()` does only exist in the following implementations of said interface: `Zend\Validator\Between`, `Zend\Validator\File\Count`, `Zend\Validator\File\FilesSize`, `Zend\Validator\File\Size`, `Zend\Validator\File\WordCount`, `Zend\Validator\GreaterThan`, `Zend\Validator\StringLength`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
35			);
36			}
37
38			/**
39			* Whether this rule supports certain validators
40			*
41			* @param ValidatorInterface $validator
42			* @return mixed
43			*/
44			public function canHandle(ValidatorInterface $validator)
45			{
46			return $validator instanceof GreaterThanValidator;
47			}
48			}
49

bramstroker / zf2-form

GitHub Access Token became invalid

Push — develop ( 8f8143...6b03f2 )

GreaterThan A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like