Rebuild::readAnnotations() - Code Metrics - Inspection of "Merge pull request #10 from brainexe/refactoring" - brainexe/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 030030...90a95a )

by Matze

created 2015-12-15 21:29 UTC

Rebuild::readAnnotations() A

↳ Parent: Rebuild

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	19
ccs	13
cts	13
cp	1
rs	9.4286
cc	2
eloc	12
nc	2
nop	1
crap	2

<?php

namespace BrainExe\Core\DependencyInjection;

use BrainExe\Annotations\Annotations\Service;
use BrainExe\Annotations\Loader;
use BrainExe\Core\Core;
use BrainExe\Core\DependencyInjection\CompilerPass\GlobalCompilerPass;

use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper;
use Symfony\Component\DependencyInjection\Container;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Dumper\PhpDumper;

use Symfony\Component\Finder\Finder;
use Symfony\Component\Finder\SplFileInfo;

/**
 * @Service("Core.Rebuild", public=false)
 */
class Rebuild
{

    /**
     * @param bool $boot
     * @return Container|ContainerBuilder
     */
    public function rebuildDIC($boot = true)

    {
        $containerBuilder = new ContainerBuilder();

        $this->readAnnotations($containerBuilder);

        $containerBuilder->addCompilerPass(new GlobalCompilerPass());
        $containerBuilder->compile();

        $this->dumpContainer($containerBuilder);

        if ($boot) {
            $core = new Core();
            return $core->boot();
        }

        return $containerBuilder;
    }

    /**
     * @param ContainerBuilder $container
     */
    protected function readAnnotations(ContainerBuilder $container)
    {
        $annotationLoader = new Loader($container);
        $appFinder = new Finder();

        $appFinder->directories()
            ->in([ROOT, CORE_ROOT, BRAINEXE_VENDOR_ROOT])
            ->depth("<=1")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ->name('src');

        $annotationLoader->load('src/');
        $annotationLoader->load(CORE_ROOT);

        foreach ($appFinder as $dir) {
            /** @var SplFileInfo $dir */
            $dirName = $dir->getPathname();
            $annotationLoader->load($dirName);
        }
    }

    /**
     * @param ContainerBuilder $container
     */
    protected function dumpContainer(ContainerBuilder $container)
    {
        $randomId      = mt_rand();
        $className     = sprintf('dic_%d', $randomId);
        $containerFile = 'cache/dic.php';

        $dumper = new PhpDumper($container);
        $dumper->setProxyDumper(new ProxyDumper());

        $containerContent = $dumper->dump(['class' => $className]);
        file_put_contents('cache/dic.php', $containerContent);
        file_put_contents('cache/dic.txt', $className);
        @chmod($containerFile, 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $debug = $container->getParameter('debug');
        file_put_contents(
            ROOT . 'cache/config.json',
            json_encode(
                $container->getParameterBag()->all(),
                $debug ? JSON_PRETTY_PRINT : null
            )
        );
    }
}


1		<?php
2
3		namespace BrainExe\Core\DependencyInjection;
4
5		use BrainExe\Annotations\Annotations\Service;
6		use BrainExe\Annotations\Loader;
7		use BrainExe\Core\Core;
8		use BrainExe\Core\DependencyInjection\CompilerPass\GlobalCompilerPass;
9
10		use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper;
11		use Symfony\Component\DependencyInjection\Container;
12		use Symfony\Component\DependencyInjection\ContainerBuilder;
13		use Symfony\Component\DependencyInjection\Dumper\PhpDumper;
14
15		use Symfony\Component\Finder\Finder;
16		use Symfony\Component\Finder\SplFileInfo;
17
18		/**
19		* @Service("Core.Rebuild", public=false)
20		*/
21		class Rebuild
22		{
23
24		/**
25		* @param bool $boot
26		* @return Container\|ContainerBuilder
27		*/
28	2	public function rebuildDIC($boot = true)
		0 ignored issues – show Coding Style introduced 2015-11-22 21:06 UTC by Report Bug Copy Issue Report This method is not in camel caps format. This check looks for method names that are not written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection seeker becomes `databaseConnectionSeeker`. Loading history...
29		{
30	2	$containerBuilder = new ContainerBuilder();
31
32	2	$this->readAnnotations($containerBuilder);
33
34	2	$containerBuilder->addCompilerPass(new GlobalCompilerPass());
35	2	$containerBuilder->compile();
36
37	2	$this->dumpContainer($containerBuilder);
38
39	2	if ($boot) {
40	1	$core = new Core();
41	1	return $core->boot();
42		}
43
44	1	return $containerBuilder;
45		}
46
47		/**
48		* @param ContainerBuilder $container
49		*/
50	2	protected function readAnnotations(ContainerBuilder $container)
51		{
52	2	$annotationLoader = new Loader($container);
53	2	$appFinder = new Finder();
54
55	2	$appFinder->directories()
56	2	->in([ROOT, CORE_ROOT, BRAINEXE_VENDOR_ROOT])
57	2	->depth("<=1")
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-22 21:06 UTC by Report Bug Copy Issue Report The string literal `<=1` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
58	2	->name('src');
59
60	2	$annotationLoader->load('src/');
61	2	$annotationLoader->load(CORE_ROOT);
62
63	2	foreach ($appFinder as $dir) {
64		/** @var SplFileInfo $dir */
65	2	$dirName = $dir->getPathname();
66	2	$annotationLoader->load($dirName);
67		}
68	2	}
69
70		/**
71		* @param ContainerBuilder $container
72		*/
73	2	protected function dumpContainer(ContainerBuilder $container)
74		{
75	2	$randomId = mt_rand();
76	2	$className = sprintf('dic_%d', $randomId);
77	2	$containerFile = 'cache/dic.php';
78
79	2	$dumper = new PhpDumper($container);
80	2	$dumper->setProxyDumper(new ProxyDumper());
81
82	2	$containerContent = $dumper->dump(['class' => $className]);
83	2	file_put_contents('cache/dic.php', $containerContent);
84	2	file_put_contents('cache/dic.txt', $className);
85	2	@chmod($containerFile, 0777);
		0 ignored issues – show Security Best Practice introduced 2015-12-02 19:46 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
86
87	2	$debug = $container->getParameter('debug');
88	2	file_put_contents(
89	2	ROOT . 'cache/config.json',
90		json_encode(
91	2	$container->getParameterBag()->all(),
92	2	$debug ? JSON_PRETTY_PRINT : null
93		)
94		);
95	2	}
96		}
97

brainexe / core

Push — master ( 030030...90a95a )

Rebuild::readAnnotations() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like