ChannelStreamHandler::setChannel() - Code Metrics - Inspection of "added more tests" - brainexe/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 38f1ea...fd6c7c )

by Matze

created 2016-06-05 12:05 UTC

ChannelStreamHandler::setChannel() A

↳ Parent: ChannelStreamHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace BrainExe\Core\Logger;

use Monolog\Handler\StreamHandler;
use Monolog\Logger;

class ChannelStreamHandler extends StreamHandler
{

    /**
     * @var string
     */
    private $channel;

    /**
     * @param string $stream
     * @param bool|int $level
     * @param string|null $channel
     * @param bool $bubble
     */
    public function __construct(
        $stream,
        $level = Logger::DEBUG,
        $channel = null,
        $bubble = true
    ) {
        parent::__construct($stream, $level, $bubble);


        $formatter = new Formatter(
            null,
            null,
            false,
            true
        );

        $this->setFormatter(
            $formatter
        );

        $this->channel = $channel;
    }

    /**
     * @param string $channel
     */
    public function setChannel(string $channel)
    {
        $this->channel = $channel;
    }

    /**
     * {@inheritdoc}
     */
    public function isHandling(array $record) : bool
    {
        if (count($record) == 1) {
            return parent::isHandling($record);
        }

        if (!parent::isHandling($record)) {
            return false;
        }

        if (empty($this->channel)) {
            return empty($record['context']['channel']);
        }

        if (empty($record['context']['channel'])) {
            return false;
        }

        $supported = $this->channel === $record['context']['channel'];

        return $supported;
    }
}


1		<?php
2
3		namespace BrainExe\Core\Logger;
4
5		use Monolog\Handler\StreamHandler;
6		use Monolog\Logger;
7
8		class ChannelStreamHandler extends StreamHandler
9		{
10
11		/**
12		* @var string
13		*/
14		private $channel;
15
16		/**
17		* @param string $stream
18		* @param bool\|int $level
19		* @param string\|null $channel
20		* @param bool $bubble
21		*/
22	10	public function __construct(
23		$stream,
24		$level = Logger::DEBUG,
25		$channel = null,
26		$bubble = true
27		) {
28	10	parent::__construct($stream, $level, $bubble);
		0 ignored issues – show Bug introduced 2016-02-27 22:10 UTC by Report Bug Copy Issue Report It seems like `$level` defined by parameter `$level` on line 24 can also be of type `boolean`; however, `Monolog\Handler\StreamHandler::__construct()` does only seem to accept `integer`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
29
30	10	$formatter = new Formatter(
31	10	null,
32	10	null,
33	10	false,
34	10	true
35		);
36
37	10	$this->setFormatter(
38		$formatter
39		);
40
41	10	$this->channel = $channel;
42	10	}
43
44		/**
45		* @param string $channel
46		*/
47	7	public function setChannel(string $channel)
48		{
49	7	$this->channel = $channel;
50	7	}
51
52		/**
53		* {@inheritdoc}
54		*/
55	9	public function isHandling(array $record) : bool
56		{
57	9	if (count($record) == 1) {
58	3	return parent::isHandling($record);
59		}
60
61	8	if (!parent::isHandling($record)) {
62	1	return false;
63		}
64
65	7	if (empty($this->channel)) {
66	2	return empty($record['context']['channel']);
67		}
68
69	5	if (empty($record['context']['channel'])) {
70	1	return false;
71		}
72
73	4	$supported = $this->channel === $record['context']['channel'];
74
75	4	return $supported;
76		}
77		}
78

brainexe / core

Push — master ( 38f1ea...fd6c7c )

ChannelStreamHandler::setChannel() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like